Gnome Calendar has white corners

Status changed to 'Confirmed' because the bug affects multiple users.

Please:

1. Include a screen-shot of the bug.
2. Set this bug status back to confirmed.

Thank you.

Attached a screenshot.

Screenshot was uploaded

This should be fixed in Xenial. An LTS should look more polished!

White corners are, I think, because g-cal has it's own CSS file "gtk-styles.css". Line 5 of this file sets .views to have a background colour of @theme_base_color.

Our CSS tries to override this on the GcalWindow object and set the colour to transparent. I think this is being over-ridden in turn by the hard-coded (?) gtk-styles.css. Setting our override CSS to GcalWindow.views is not effective.

In gcal-applicaiton.c:

#define CSS_FILE "resource:///org/gnome/calendar/gtk-styles.css"

Why are we using CSD at all? With gtk3-nocsd (https://github.com/PCMan/gtk3-nocsd) it works quite well. Screenshot: http://i.imgur.com/bb4EfOU.png

Why should disable headerbar under unity and patch menubar just like we do for gedit and other apps.

Applying this patch to gtk-styles.css in gnome-calendar and then adding the corresponding patch to the theme "fixes" the issue.

Removing the .views CSS from the gtk-styles.css in Calendar and moving it to our Ubuntu theme's calendar.css. This needs to be applied in conjunction with the patch to gnome-calendar's gtk-styles.css

Fixed in gnome-calendar 3.20.2.

The yakkety changelog has a wrong LP bug number,

gnome-calendar (3.20.2-0ubuntu1) yakkety; urgency=medium

  * New upstream version
    - Use the theme's CSS instead of our custom one (lp: #565267)

It should be 1565267.

The changelog missed Bug #1573636. It is fixed in 3.20.2.

Bug still present in Xenial. 3.20.1 is the default installation in the LTS.

https://launchpad.net/ubuntu/+source/gnome-calendar/3.20.2-0ubuntu1

Hello motang, or anyone else affected,

Accepted gnome-calendar into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-calendar/3.20.2-0ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Actually I'm not sure if it should be marked as verification-done.

That's because as far as I can see it only resolves the problem for Ubuntu default themes Ambiance and Radiance all the other 3rd party themes still render incorrectly. Even Adwaita the default GNOME theme renders incorrectly.

Well, no plan to block something which is better just because it's not perfect. We can do another update to fix remaining issues later

I have been testing it on one of my install that pre-release updates enabled and so far it has been good.

This bug was fixed in the package gnome-calendar - 3.20.2-0ubuntu0.1

---------------
gnome-calendar (3.20.2-0ubuntu0.1) xenial; urgency=medium

  * New upstream version
    - Use the theme's CSS instead of our custom one (lp: #1565267)
  * debian/patches/use_gtk_318.patch:
    - refreshed for the new version
  * debian/patches/dont_require_schemas.patch:
    - restore upstream commit which was reverted to not depends
      on a schemas that doesn't exist under Unity

 -- Sebastien Bacher <email address hidden> Thu, 12 May 2016 09:18:36 +0200

The verification of the Stable Release Update for gnome-calendar has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.