Enable translation import queue approval through API

As in the previous API bug, I'm also adding a task for the ubuntu-translations project. Not a bug per-se, but as the queue which sees most activity and is most looked after is the Ubuntu one, I'd like the UTC team to be in the loop.

Here's the example code I've used to test the imports queue API:

In [1]: from launchpadlib.launchpad import Launchpad

In [2]: launchpad = Launchpad.login_with('ul10n-tools', 'staging')

In [3]: ubuntu = launchpad.distributions['ubuntu']
The authorization page:
 (https://staging.launchpad.net/+authorize-token?oauth_token=xqCfwPc9tZfCLL36WKT6&allow_permission=DESKTOP_INTEGRATION)
should be opening in your browser. Use your browser to authorize
this program to access Launchpad on your behalf.

Waiting to hear from Launchpad about your decision...

In [4]: current = ubuntu.current_series

In [5]: oldest_entries = current.getTranslationImportQueueEntries(file_extension = '.pot', import_status = 'Needs Review')[:10]

In [6]: oldest = oldest_entries[0]

In [7]: print oldest.path
src/libstdc++-v3/po/libstdc++.pot

In [8]: print oldest.sourcepackage.name
gcj-4.5

In [9]: print oldest.status
Needs Review

In [10]: oldest.setStatus(new_status = 'Approved')
---------------------------------------------------------------------------
Unauthorized Traceback (most recent call last)

/home/dpm/<ipython console> in <module>()

/usr/lib/python2.7/dist-packages/lazr/restfulclient/resource.pyc in __call__(self, *args, **kwargs)
    556 extra_headers = { 'Content-type' : media_type }
    557 response, content = self.root._browser._request(
--> 558 url, in_representation, http_method, extra_headers=extra_headers)
    559
    560 if response.status == 201:

/usr/lib/python2.7/dist-packages/lazr/restfulclient/_browser.pyc in _request(self, url, data, method, media_type, extra_headers)
    279 error = error_for(response, content)
    280 if error is not None:
--> 281 raise error
    282 return response, content
    283

Unauthorized: HTTP Error 401: Unauthorized
Response headers:
---
content-length: 0
content-type: text/plain
date: Fri, 15 Apr 2011 07:49:13 GMT
server: zope.server.http (HTTP)
status: 401
vary: Accept,Accept-Encoding
via: 1.1 wildcard.staging.launchpad.net
x-lazr-notifications: []
x-powered-by: Zope (www.zope.org), Python (www.python.org)
---
Response body:
---

---

As others have noted, it's important to check that oldest.import_into is not None when you call setStatus. That's the one check that's done outside of the normal authentication system for this call.

By the way, import_into is not a field you can set — it's computed from other fields. I'm not sure how launchpadlib deals with the need to re-compute it; you may have to re-load the object, which in turn I suppose may run into launchpadlib caching.

But assuming that import_into is not None, and that you authorized launchpadlib to perform write actions on your behalf, and that you are logged in using your normal account (which is privileged to make this change) then that would mean that your user identity is not being passed to the API method.

@Emanuelle: I assumed you are a spammer. If I was wrong, please let us know who you are. Otherwise: Go away!