[browser] In landscape mode (phone), the app should go full screen
Bug #1426347 reported by
Giorgio Venturi
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu UX |
Fix Committed
|
High
|
James Mulholland | ||
| webbrowser-app |
Invalid
|
Medium
|
Unassigned | ||
| webbrowser-app (Ubuntu) |
In Progress
|
Medium
|
Riccardo Padovani | ||
Bug Description
In landscape mode (on the phone form factor) there is a limited real estate available, therefore it is beneficial to go full screen and free up valuable space for the content.
On tablet FFs this is not an issue and the behaviour should be the default (i.e. indicators are shown)
Related branches
lp://qastaging/~rpadovani/webbrowser-app/go-fullscreen-landscape-phone
- PS Jenkins bot: Approve (continuous-integration)
- Olivier Tilloy: Needs Fixing
-
Diff: 31 lines (+14/-0)1 file modifiedsrc/app/BrowserWindow.qml (+14/-0)
| Changed in ubuntu-ux: | |
| status: | New → Fix Committed |
| importance: | Undecided → Medium |
| importance: | Medium → High |
| assignee: | nobody → Giorgio Venturi (giorgio-venturi) |
Revision history for this message
| Olivier Tilloy (osomon) wrote | #1 |
| Changed in webbrowser-app: | |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
Revision history for this message
| Giorgio Venturi (giorgio-venturi-deactivatedaccount) wrote | #2 |
| Changed in webbrowser-app: | |
| status: | Confirmed → In Progress |
| assignee: | nobody → Riccardo Padovani (rpadovani) |
Revision history for this message
| Oliver Grawert (ogra) wrote | #3 |
| Changed in ubuntu-ux: | |
| assignee: | Giorgio Venturi (giorgio-venturi) → James Mulholland (jamesjosephmulholland) |
| Changed in webbrowser-app (Ubuntu): | |
| status: | New → In Progress |
| importance: | Undecided → Medium |
| assignee: | nobody → Riccardo Padovani (rpadovani) |
| Changed in webbrowser-app: | |
| assignee: | Riccardo Padovani (rpadovani) → nobody |
| status: | In Progress → Invalid |
To post a comment you must log in.
To be clear: "go fullscreen" means make the app’s window fullscreen, it doesn’t mean hiding the chrome.
Note: we currently don’t have any way to detect a tablet form factor in the code. It’s either "mobile" or "desktop".
What would be a good heuristic on screen sizes to determine whether a device is a phone or a tablet?