Ubuntu

A bug's can_expire attribute is confusing

Bug #595124 reported by Brad Figg
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Brian Murray
Launchpad itself 10.08
Ubuntu
Invalid
Undecided
Unassigned

Bug Description

My example is bug #203251. This bug reached a stage where can_expire was set. If just a comment is added to the bug, can_expire is not unset. If the status of the bug is changed from "Incomplete" to "Triaged" then can_expire *is* unset. However, as soon as the status is set back to "Incomplete" can_expire is set again.

Related branches

lp://qastaging/~brian-murray/launchpad/595124
Leonard Richardson (community): Approve
Diff: 443 lines (+164/-41)
12 files modified
lib/lp/bugs/browser/bugtask.py (+7/-4)
lib/lp/bugs/configure.zcml (+2/-1)
lib/lp/bugs/doc/bug.txt (+6/-6)
lib/lp/bugs/doc/bugtask-expiration.txt (+30/-7)
lib/lp/bugs/interfaces/bug.py (+18/-2)
lib/lp/bugs/model/bug.py (+36/-9)
lib/lp/bugs/model/bugtask.py (+1/-1)
lib/lp/bugs/stories/bugs/xx-incomplete-bugs.txt (+16/-6)
lib/lp/bugs/stories/webservice/xx-bug.txt (+42/-0)
lib/lp/bugs/templates/bug-listing-expirable.pt (+3/-3)
lib/lp/bugs/templates/bugtask-index.pt (+1/-1)
lib/lp/bugs/tests/bug.py (+2/-1)
Brian Murray (brian-murray)
Changed in ubuntu:
status: New → Invalid
Revision history for this message
Brian Murray (brian-murray) wrote :

bug = launchpad.bugs[203251]
In [3]: bug.can_expire
Out[3]: True
In [4]: bug.date_last_updated
Out[4]: datetime.datetime(2010, 6, 15, 21, 53, 48, 256877, tzinfo=TimeZone(0))

I wonder how often the can_expire attribute of a bug report is updated.

Changed in malone:
status: New → Confirmed
Revision history for this message
Deryck Hodge (deryck) wrote :

Setting this back to New to make sure I take a look today.

Changed in malone:
status: Confirmed → New
Revision history for this message
Deryck Hodge (deryck) wrote :

I've had a look now. can_expire is a wrapper around findExpirableBugTasks, which only looks at date_last_updated and not date_last_message. We should extend the query in findExpirableBugTasks to consider date_last_message.

While I think this is an easy bug to fix, I'm hesitant to tag it trivial, as I have this theory that ultimately no malone bug is trivial. But this is an easy one, definitely.

Changed in malone:
importance: Undecided → High
tags: added: dhrb easy
Changed in malone:
status: New → Triaged
Revision history for this message
Brian Murray (brian-murray) wrote :

date_last_updated is not the issue. In comment 1 you can see that date_last_updated is recent and less than 60 days old.

Revision history for this message
Brian Murray (brian-murray) wrote :

Some documentation, at least in lib/lp/bugs/doc/bugtask-expiration.txt, about can_expire indicates that it only should indicate if the bug *may* expire.

"IBug specifies two properties related to bug expiration. can_expire
tells you whether one or more of the bug's bug tasks may be expired, if
the bug doesn't get any more activity."

Revision history for this message
Brian Murray (brian-murray) wrote :

So if can_expire really means may expire than the documentation should be updated to reflect that. However, the following test passes and I'm unsure why.

    # Add a comment to the bug report and see if it can still expire
    >>> from lp.bugs.tests.bug import create_old_bug
    >>> ubuntu_bugtask2 = create_old_bug('expirable_distro', 351, ubuntu)
    >>> ubuntu_bugtask2.bug.can_expire
    True
    >>> from lp.testing.factory import LaunchpadObjectFactory
    >>> factory = LaunchpadObjectFactory()
    >>> factory.makeBugComment(bug=ubuntu_bugtask2.bug)
    <Message at...
    >>> ubuntu_bugtask2.bug.can_expire
    False

Brian Murray (brian-murray)
summary: - Launchpad's can_expire not being reset when comments added.
+ Launchpad's can_expire is confusing
summary: - Launchpad's can_expire is confusing
+ A bug's can_expire attribute is confusing
Deryck Hodge (deryck)
Changed in malone:
assignee: nobody → Brian Murray (brian-murray)
status: Triaged → Fix Committed
milestone: none → 10.08
Revision history for this message
Ursula Junque (ursinha) wrote : Bug fixed by a commit

Fixed in stable r11108 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11108>.

tags: added: qa-needstesting
Brian Murray (brian-murray)
tags: added: qa-ok
removed: qa-needstesting
Julian Edwards (julian-edwards)
Changed in malone:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.