The langpack.mk rule needs to handle X-GNOME-FullName[ll] keys to strip translations

Bug #453297 reported by David Planella
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Translations
Fix Released
High
David Planella
cdbs (Ubuntu)
Fix Released
Undecided
Martin Pitt

Bug Description

Binary package hint: cdbs

Some GNOME applications seem to have started using the X-GNOME-FullName key, also for translations. Here's an example from /usr/share/applications/rhythmbox.desktop:

[Desktop Entry]
Name=Rhythmbox
GenericName=Music Player
X-GNOME-FullName=Rhythmbox Music Player
X-GNOME-FullName[af]=Rhythmbox-musiekspeler
X-GNOME-FullName[ar]=مشغل الموسيقى أنغام
[...]

The part of the langpack.mk rule dealing with stripping translations does not currently have those into account, resulting in translations being present in the installed .desktop files. Here's the relevant extract:

  for d in $$(find debian/$(cdbs_curpkg) -type f \( -name "*.desktop" -o -name "*.directory" \) ); do \
      echo "langpack.mk: Replacing translations with domain $$DOMAIN in $$d..."; \
      sed -ri '/^(Name|GenericName|Comment)\[/d' $$d; \
      echo "X-Ubuntu-Gettext-Domain=$$DOMAIN" >> $$d; \

I believe langpack.mk should add X-GNOME-FullName to the sed line in order to strip those translations as expected.

David Planella (dpm)
tags: added: i18n needs-desktop-entry-i18n
Revision history for this message
David Planella (dpm) wrote :

According to comments on the ubuntu-translators list [1] and further confirmation, this also seems to cause translations in the desktop fine done in Ubuntu but not present upstream not to be used. Russian is an example.

[1] https://lists.ubuntu.com/archives/ubuntu-translators/2009-October/003052.html

David Planella (dpm)
Changed in ubuntu-translations:
status: New → Triaged
importance: Undecided → High
assignee: nobody → David Planella (dpm)
Revision history for this message
Martin Pitt (pitti) wrote : Re: [Bug 453297] [NEW] The langpack.mk rule needs to handle X-GNOME-FullName[ll] keys to strip translations

 status inprogress
 assignee pitti

Martin Pitt (pitti)
Changed in cdbs (Ubuntu):
assignee: nobody → Martin Pitt (pitti)
status: New → In Progress
Martin Pitt (pitti)
Changed in cdbs (Ubuntu):
status: In Progress → Fix Committed
Changed in ubuntu-translations:
status: Triaged → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package cdbs - 0.4.62+nmu1ubuntu2

---------------
cdbs (0.4.62+nmu1ubuntu2) lucid; urgency=low

  * 1/rules/langpack.mk.in: Strip X-GNOME-FullName fields, too. Thanks to
    David Planella! (LP: #453297)
 -- Martin Pitt <email address hidden> Sun, 15 Nov 2009 06:54:19 -0600

Changed in cdbs (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.