checkbox-gui runs whitelists I did not select (default whitelist selection broken)
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Checkbox GUI (Legacy) |
Fix Released
|
High
|
Sylvain Pineau | ||
| checkbox (Ubuntu) |
Fix Released
|
High
|
Sylvain Pineau | ||
Bug Description
This is a trusty system with checkbox-gui -0.17.6-0ubuntu1.
How to reproduce:
1- Launch checkbox-gui
2- Select the sniff whitelist
Expected result:
- only sniff tests
Actual result:
- sniff tests *plus* all the tests in the default whitelist.
I think the code attempts to select the default whitelist, but it only updates the internal state, not the visual representation (default should have a check mark). If started from console, I can see it changing all whitelists to "false" and at the end saying:
'default' "/plainbox/
But again, this is not reflected visually in the window. Thus, it's confusing when I select the sniff whitelist thinking I'll get only sniff tests, but internally checkbox-gui did select default too and gives me a union of tests.
A workaround is to select the whitelist I want (say, sniff), then selecting and deselecting "default" again, this updates the internal state correctly and runs only what I need.
Related branches
- Sylvain Pineau (community): Approve
-
Diff: 19 lines (+1/-1)1 file modifiedplainbox-gui/canonical-driver-test-suite/qml/SuiteSelectionView.qml (+1/-1)
- Sylvain Pineau (community): Approve
-
Diff: 19 lines (+1/-1)1 file modifiedcheckbox-gui/checkbox-gui/qml/SuiteSelectionView.qml (+1/-1)
- Daniel Manrique (community): Approve
- Ubuntu branches: Pending requested
-
Diff: 49 lines (+11/-2)3 files modifiedcheckbox-gui/checkbox-gui/qml/ManualInteractionDialog.qml (+1/-1)
checkbox-gui/checkbox-gui/qml/SuiteSelectionView.qml (+1/-1)
debian/changelog (+9/-0)
| Daniel Manrique (roadmr) wrote | #1 |
| Changed in checkbox: | |
| assignee: | nobody → Sylvain Pineau (sylvain-pineau) |
| Changed in checkbox (Ubuntu): | |
| assignee: | nobody → Sylvain Pineau (sylvain-pineau) |
| Changed in checkbox: | |
| status: | New → In Progress |
| Changed in checkbox (Ubuntu): | |
| status: | New → In Progress |
| Changed in checkbox: | |
| importance: | Undecided → High |
| Changed in checkbox (Ubuntu): | |
| importance: | Undecided → High |
| Sylvain Pineau (sylvain-pineau) wrote | #2 |
| Changed in checkbox-ihv-ng: | |
| status: | New → In Progress |
| importance: | Undecided → High |
| assignee: | nobody → Sylvain Pineau (sylvain-pineau) |
| Sylvain Pineau (sylvain-pineau) wrote | #3 |
| Changed in checkbox-ihv-ng: | |
| status: | In Progress → Fix Committed |
| Changed in checkbox: | |
| status: | In Progress → Fix Committed |
| Ubuntu Foundations Team Bug Bot (crichton) wrote | #4 |
| tags: | added: patch |
| Changed in checkbox-ihv-ng: | |
| milestone: | none → version1.7 |
| Changed in checkbox (Ubuntu): | |
| status: | In Progress → Fix Committed |
| Changed in checkbox: | |
| milestone: | none → 2014-mar-14 |
| Launchpad Janitor (janitor) wrote | #5 |
| Changed in checkbox (Ubuntu): | |
| status: | Fix Committed → Fix Released |
| Changed in checkbox-ihv-ng: | |
| status: | Fix Committed → Fix Released |
| no longer affects: | checkbox |
| Changed in checkbox-gui: | |
| status: | New → Fix Released |
| importance: | Undecided → High |
| assignee: | nobody → Sylvain Pineau (sylvain-pineau) |
I think this bug snuck in when we made the default whitelist selected by default:
https:/
setting the check property to true in the whitelistModel doesn't seem to update the visual representation :(