Ubuntu
cmake-extras package

Modules installed in CMAKE_ROOT

Bug #1563573 reported by Michał Sawicz on 2016-03-29

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	cmake-extras (Ubuntu)	Fix Released	High	Pete Woods

Bug Description

Every time cmake is upgraded, we need to rebuild cmake-extras to put the modules in the correct place, even though it's just about the paths.

I believe the installation in CMAKE_ROOT is wrong (only cmake-data installs there), we should instead install in /usr/lib/cmake/ (or /usr/lib/<arch>/cmake/ when files are arch-dependent).

Otherwise, we'd need versioned dependencies to prevent broken cmake + cmake-extras installations.

ProblemType: Bug
DistroRelease: Ubuntu 16.04
Package: cmake-extras 0.6+16.04.20160215-0ubuntu2
ProcVersionSignature: Ubuntu 4.4.0-15.31-generic 4.4.6
Uname: Linux 4.4.0-15-generic x86_64
ApportVersion: 2.20-0ubuntu3
Architecture: amd64
CurrentDesktop: Unity
Date: Tue Mar 29 23:42:12 2016
Dependencies:

PackageArchitecture: all
SourcePackage: cmake-extras
UpgradeStatus: No upgrade log present (probably fresh install)

Tags:

Related branches

lp://qastaging/~pete-woods/mcloud/cmake-extras-compatibility

Merged into lp://qastaging/mcloud at revision 15

Gary.Wang: Approve on 2016-12-12

Michi Henning (community): Approve on 2016-12-09

lp://qastaging/~pete-woods/keeper/cmake-extras-compatibility

Rejected for merging into lp://qastaging/keeper

Michi Henning (community): Approve on 2016-12-09

lp://qastaging/~pete-woods/indicator-display/cmake-extras-compatibility

Merged into lp://qastaging/indicator-display at revision 23

Michi Henning (community): Approve on 2016-12-09

unity-api-1-bot: Needs Fixing (continuous-integration) on 2016-12-07

lp://qastaging/~pete-woods/unity-scopes-shell/cmake-extras-compatibility

Merged into lp://qastaging/unity-scopes-shell at revision 361

Michi Henning (community): Approve on 2016-12-09

unity-api-1-bot: Needs Fixing (continuous-integration) on 2016-12-08

lp://qastaging/~pete-woods/unity-scope-click/cmake-extras-compatibility

Merged into lp://qastaging/unity-scope-click at revision 511

dobey (community): Approve on 2016-12-09

unity-api-1-bot: Pending (continuous-integration) requested 2016-12-09

Michi Henning: Pending requested 2016-12-09

lp://qastaging/~pete-woods/ubuntu-settings-components/cmake-extras-compatibility

Merged into lp://qastaging/ubuntu-settings-components at revision 181

Michi Henning (community): Approve on 2016-12-09

Unity8 CI Bot: Needs Fixing (continuous-integration) on 2016-12-07

lp://qastaging/~pete-woods/qtmir/cmake-extras-compatibility

Merged into lp://qastaging/qtmir at revision 584

Unity8 CI Bot (community): Approve (continuous-integration) on 2016-12-09

Michi Henning (community): Approve on 2016-12-09

lp://qastaging/~pete-woods/policykit-unity8/cmake-extras-compatibility

Merged into lp://qastaging/policykit-unity8 at revision 19

Michi Henning (community): Approve on 2016-12-09

unity-api-1-bot: Needs Fixing (continuous-integration) on 2016-12-07

lp://qastaging/~pete-woods/pay-service/cmake-extras-compatibility

Merged into lp://qastaging/pay-service at revision 142

dobey (community): Approve on 2016-12-09

Michi Henning (community): Approve on 2016-12-09

unity-api-1-bot: Needs Fixing (continuous-integration) on 2016-12-09

lp://qastaging/~pete-woods/hud/cmake-extras-compatibility

Merged into lp://qastaging/hud at revision 411

Indicator Applet Developers: Pending requested 2016-12-07

lp://qastaging/~pete-woods/indicator-network/cmake-extras-compatibility

Merged into lp://qastaging/indicator-network at revision 654

dobey (community): Approve on 2016-12-15

lp://qastaging/~pete-woods/indicator-sound/cmake-extras-compatibility

Merged into lp://qastaging/indicator-sound at revision 544

unity-api-1-bot: Needs Fixing (continuous-integration) on 2016-12-09

Indicator Applet Developers: Pending requested 2016-12-07

lp://qastaging/~pete-woods/thumbnailer/cmake-extras-compatibility

Merged into lp://qastaging/thumbnailer at revision 155

Michi Henning (community): Approve on 2017-02-13

lp://qastaging/~pete-woods/ubuntu-app-launch/cmake-extras-compatibility

Merged into lp://qastaging/ubuntu-app-launch at revision 271

unity-api-1-bot: Approve (continuous-integration) on 2017-01-05

Ted Gould (community): Approve on 2016-12-08

lp://qastaging/~pete-woods/libqtdbusmock/cmake-extras-compatibility

Merged into lp://qastaging/libqtdbusmock at revision 46

Unity Team: Pending requested 2016-12-07

lp://qastaging/~pete-woods/libqtdbustest/cmake-extras-compatibility

Merged into lp://qastaging/libqtdbustest at revision 41

Unity Team: Pending requested 2016-12-07

lp://qastaging/~pete-woods/mediascanner2/cmake-extras-compatibility

Merged into lp://qastaging/mediascanner2 at revision 340

Michi Henning (community): Approve on 2016-12-08

unity-api-1-bot: Needs Fixing (continuous-integration) on 2016-12-07

lp://qastaging/~pete-woods/persistent-cache-cpp/cmake-extras-compatibility

Merged into lp://qastaging/persistent-cache-cpp

Michi Henning (community): Approve on 2016-12-08

lp://qastaging/~pete-woods/storage-framework/cmake-extras-compatibility

Rejected for merging into lp://qastaging/storage-framework

Michi Henning (community): Disapprove on 2017-01-12

lp://qastaging/~pete-woods/cmake-extras/drop-deprecated-macros-lp1563573

Merged into lp://qastaging/cmake-extras at revision 73

Charles Kerr (community): Approve on 2017-04-03

lp://qastaging/~ci-train-bot/cmake-extras/cmake-extras-ubuntu-zesty-2688

Revision history for this message

Michał Sawicz (saviq) wrote on 2016-03-29:

JournalErrors.txt Edit (85.5 KiB, text/plain; charset="utf-8")
ProcEnviron.txt Edit (344 bytes, text/plain; charset="utf-8")

Revision history for this message

Michi Henning (michihenning) wrote on 2016-03-30:

We can install in /usr/lib/cmake/cmake-extras, but that is not backward compatible.

cmake looks in CMAKE_MODULE_PATH for additional modules but, by default, CMAKE_MODULE_PATH is empty, so the extra modules are not found. The only place cmake looks at by default appears to be ${CMAKE_ROOT}/Modules, unfortunately.

We can make this change, but all projects using cmake-extras will have to set CMAKE_MODULE_PATH explicitly:

set(CMAKE_MODULE_PATH /usr/lib/cmake/cmake-extras)

Revision history for this message

Michał Sawicz (saviq) wrote on 2016-03-30:

I just looked at other projects that install cmake bits, and the two locations common between them are those:

$ dpkg -S /usr/lib/cmake
libjsoncpp-dev:amd64: /usr/lib/cmake

$ dpkg -S /usr/lib/x86_64-linux-gnu/cmake/Qt5
qtbase5-dev:amd64: /usr/lib/x86_64-linux-gnu/cmake/Qt5

While nothing else than cmake itself and cmake-extras installs in the versioned directory:

$ dpkg -S /usr/share/cmake-3.5
cmake-data, cmake-extras: /usr/share/cmake-3.5

By "not backwards compatible", what do you mean? I don't think we need to be compatible further back than... our current cmake TBH.

Pete Woods (pete-woods) on 2016-12-09

Changed in cmake-extras (Ubuntu):
importance:	Undecided → High
assignee:	nobody → Pete Woods (pete-woods)
status:	New → In Progress

Pete Woods (pete-woods) on 2017-04-29

Changed in cmake-extras (Ubuntu):
status:	In Progress → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Bug attachments

Add attachment

Remote bug watches

Bug watches keep track of this bug in other bug trackers.

Ubuntucmake-extras package

Modules installed in CMAKE_ROOT

Bug Description

Related branches

Other bug subscribers

Bug attachments

Remote bug watches

Ubuntu
cmake-extras package