incomplete dkms package dependencies

Here's a patch that adds 'dpkg-dev' and 'debhelper' to the Depends field of debian/control.

The attachment "Add 'dpkg-dev' and 'debhelper' to Depends in debian/control" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

I really don't want these pulled in on the myriads of systems that DKMS ends up on. This feature of DKMS isn't used as commonly as DKMS is used to just install /build packages. I would much rather see a patch that would install these packages on demand if they're missing than pull it in for everyone.

So should it be suggests or recommends instead

Sincerely,
kroq-gar78

I'm fine with it being a suggests, but recommends are pulled in by default in ubuntu.

Pavel,
You'll have to fill out the "Impact" section in the description. I'm not sure what to put there ;)

Thanks! I'll do the rest.

Sincerely,
kroq-gar78

On Mon, May 28, 2012 at 10:29 AM, Pavel Zeldin <email address hidden>wrote:

> ** Description changed:
>
> [Impact]
> - <fill me in with explanation of severity and frequency of bug on users
> and justification for backporting the fix to the stable release>
> + "dkms mkdeb" fails with: "make: dh_testdir: Command not found".
> + This affects only those users who use dkms to create driver packages.
> Majority of dkms users only install .deb packages and are not affected by
> this.
>
> [Development Fix]
> <fill me in with an explanation of how the bug has been addressed in the
> development branch, including the relevant version numbers of packages
> modified in order to implement the fix. >
>
> [Stable Fix]
> <fill me in by pointing out a minimal patch applicable to the stable
> version of the package.>
>
> [Text Case]
> <fill me in with detailed *instructions* on how to reproduce the bug.
> This will be used by people later on to verify the updated package fixes
> the problem.>
> 1.
> 2.
> 3.
> - Broken Behavior:
> - Fixed Behavior:
> + Broken Behavior:
> + Fixed Behavior:
>
> [Regression Potential]
> <fill me in with a discussion of likelihood and potential severity of
> regressions and how users could get inadvertently affected.>
>
> [Original Report]dpkg-dev and debhelper are required when using dkms to
> create a package.
>
> ProblemType: Bug
> ApportVersion: 2.0.1-0ubuntu6
> Architecture: i386
> Date: Fri Apr 27 14:13:54 2012
> Dependencies:
> binutils 2.22-6ubuntu1
> coreutils 8.13-3ubuntu3
> cpp 4:4.6.3-1ubuntu5
> cpp-4.6 4.6.3-1ubuntu5
> debconf 1.5.42ubuntu1
> dpkg 1.16.1.2ubuntu7
> gcc 4:4.6.3-1ubuntu5
> gcc-4.6 4.6.3-1ubuntu5
> gcc-4.6-base 4.6.3-1ubuntu5
> libacl1 2.2.51-5ubuntu1
> libattr1 1:2.4.46-5ubuntu1
> libbz2-1.0 1.0.6-1
> libc-bin 2.15-0ubuntu10
> libc6 2.15-0ubuntu10
> libgcc1 1:4.6.3-1ubuntu5
> libgmp10 2:5.0.2+dfsg-2ubuntu1
> libgomp1 4.6.3-1ubuntu5
> liblzma5 5.1.1alpha+20110809-3
> libmpc2 0.9-4
> libmpfr4 3.1.0-3ubuntu2
> libquadmath0 4.6.3-1ubuntu5
> libselinux1 2.1.0-4.1ubuntu1
> libstdc++6 4.6.3-1ubuntu5
> make 3.81-8.1ubuntu1
> module-init-tools 3.16-1ubuntu2
> multiarch-support 2.15-0ubuntu10
> patch 2.6.1-3
> perl-base 5.14.2-6ubuntu2
> tar 1.26-4ubuntu1
> tzdata 2012b-1
> xz-utils 5.1.1alpha+20110809-3
> zlib1g 1:1.2.3.4.dfsg-3ubuntu4
> DistroRelease: Ubuntu 12.04
> InstallationMedia: Ubuntu-Server 12.04 LTS "Precise Pangolin" - Release
> i386 (20120424.1)
> Package: dkms 2.2.0.3-1ubuntu3
> PackageArchitecture: all
> ProcEnviron:
> LC_CTYPE=en_CA.UTF-8
> TERM=xterm
> LC_COLLATE=en_CA.UTF-8
> LANG=en_US.UTF-8
> LC_MESSAGES=en_CA.UTF-8
> SHELL=/bin/bash
> ProcVersionSignature: Ubuntu 3.2.0-24.37-generic-pae 3.2.14
> SourcePackage: dkms
> Tags: precise
> Uname: Linux 3.2.0-24-generic-pae i686
> UpgradeStatus: No upgrade log present (probably fresh install)
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/989998
>
> Title:
> incomplete dkms package dependencies
>
> Status in “d...

Eh, just kidding. You'll have to do the "Test Case" part, too, but it seems
like you almost got it with what you put in the "Impact" section. Sorry
about that!

Sincerely,
kroq-gar78

On Mon, May 28, 2012 at 10:44 AM, Aditya Vaidya <email address hidden>wrote:

> Thanks! I'll do the rest.
>
> Sincerely,
> kroq-gar78
>
>
>
> On Mon, May 28, 2012 at 10:29 AM, Pavel Zeldin <email address hidden>wrote:
>
>> ** Description changed:
>>
>> [Impact]
>> - <fill me in with explanation of severity and frequency of bug on users
>> and justification for backporting the fix to the stable release>
>> + "dkms mkdeb" fails with: "make: dh_testdir: Command not found".
>> + This affects only those users who use dkms to create driver packages.
>> Majority of dkms users only install .deb packages and are not affected by
>> this.
>>
>> [Development Fix]
>> <fill me in with an explanation of how the bug has been addressed in the
>> development branch, including the relevant version numbers of packages
>> modified in order to implement the fix. >
>>
>> [Stable Fix]
>> <fill me in by pointing out a minimal patch applicable to the stable
>> version of the package.>
>>
>> [Text Case]
>> <fill me in with detailed *instructions* on how to reproduce the bug.
>> This will be used by people later on to verify the updated package fixes
>> the problem.>
>> 1.
>> 2.
>> 3.
>> - Broken Behavior:
>> - Fixed Behavior:
>> + Broken Behavior:
>> + Fixed Behavior:
>>
>> [Regression Potential]
>> <fill me in with a discussion of likelihood and potential severity of
>> regressions and how users could get inadvertently affected.>
>>
>> [Original Report]dpkg-dev and debhelper are required when using dkms to
>> create a package.
>>
>> ProblemType: Bug
>> ApportVersion: 2.0.1-0ubuntu6
>> Architecture: i386
>> Date: Fri Apr 27 14:13:54 2012
>> Dependencies:
>> binutils 2.22-6ubuntu1
>> coreutils 8.13-3ubuntu3
>> cpp 4:4.6.3-1ubuntu5
>> cpp-4.6 4.6.3-1ubuntu5
>> debconf 1.5.42ubuntu1
>> dpkg 1.16.1.2ubuntu7
>> gcc 4:4.6.3-1ubuntu5
>> gcc-4.6 4.6.3-1ubuntu5
>> gcc-4.6-base 4.6.3-1ubuntu5
>> libacl1 2.2.51-5ubuntu1
>> libattr1 1:2.4.46-5ubuntu1
>> libbz2-1.0 1.0.6-1
>> libc-bin 2.15-0ubuntu10
>> libc6 2.15-0ubuntu10
>> libgcc1 1:4.6.3-1ubuntu5
>> libgmp10 2:5.0.2+dfsg-2ubuntu1
>> libgomp1 4.6.3-1ubuntu5
>> liblzma5 5.1.1alpha+20110809-3
>> libmpc2 0.9-4
>> libmpfr4 3.1.0-3ubuntu2
>> libquadmath0 4.6.3-1ubuntu5
>> libselinux1 2.1.0-4.1ubuntu1
>> libstdc++6 4.6.3-1ubuntu5
>> make 3.81-8.1ubuntu1
>> module-init-tools 3.16-1ubuntu2
>> multiarch-support 2.15-0ubuntu10
>> patch 2.6.1-3
>> perl-base 5.14.2-6ubuntu2
>> tar 1.26-4ubuntu1
>> tzdata 2012b-1
>> xz-utils 5.1.1alpha+20110809-3
>> zlib1g 1:1.2.3.4.dfsg-3ubuntu4
>> DistroRelease: Ubuntu 12.04
>> InstallationMedia: Ubuntu-Server 12.04 LTS "Precise Pangolin" - Release
>> i386 (20120424.1)
>> Package: dkms 2.2.0.3-1ubuntu3
>> PackageArchitecture: all
>> ProcEnviron:
>> LC_CTYPE=en_CA.UTF-8
>> TERM=xterm
>> LC_COLLATE=en_CA.UTF-8
>> LANG=en_US.UTF-8
>> LC_MESSAGES=en_CA.UTF-8
>> SHELL=/bin/bash
>> ProcVersionSignature: Ubuntu 3.2.0-24.37-gen...

Should this be '-1ubuntu3.1' or '-1ubuntu4'? Someone told me to do a '.1'
on one other bug which was dependency-related.

Sincerely,
kroq-gar78

On Mon, May 28, 2012 at 10:55 AM, kroq-gar78 <email address hidden>wrote:

> ** Description changed:
>
> [Impact]
> "dkms mkdeb" fails with: "make: dh_testdir: Command not found".
> This affects only those users who use dkms to create driver packages.
> Majority of dkms users only install .deb packages and are not affected by
> this.
>
> [Development Fix]
> - <fill me in with an explanation of how the bug has been addressed in the
> development branch, including the relevant version numbers of packages
> modified in order to implement the fix. >
> + The packages "dpkg-dev" and "debhelper" were added to the "Suggests"
> field in debian/control.
>
> [Stable Fix]
> - <fill me in by pointing out a minimal patch applicable to the stable
> version of the package.>
> + Install the packages "dpkg-dev" and "debhelper" using apt-get, Synaptic,
> aptitude, etc.
>
> [Text Case]
> <fill me in with detailed *instructions* on how to reproduce the bug.
> This will be used by people later on to verify the updated package fixes
> the problem.>
> 1.
> 2.
> 3.
> +
> Broken Behavior:
> Fixed Behavior:
>
> [Regression Potential]
> - <fill me in with a discussion of likelihood and potential severity of
> regressions and how users could get inadvertently affected.>
> + The regression potential is minimal because, if it would cause a
> regression, apt-get would likely know anyway because of the "Breaks" field
> in debian/control.
>
> - [Original Report]dpkg-dev and debhelper are required when using dkms to
> + [Original Report] dpkg-dev and debhelper are required when using dkms to
> create a package.
>
> ProblemType: Bug
> ApportVersion: 2.0.1-0ubuntu6
> Architecture: i386
> Date: Fri Apr 27 14:13:54 2012
> Dependencies:
> binutils 2.22-6ubuntu1
> coreutils 8.13-3ubuntu3
> cpp 4:4.6.3-1ubuntu5
> cpp-4.6 4.6.3-1ubuntu5
> debconf 1.5.42ubuntu1
> dpkg 1.16.1.2ubuntu7
> gcc 4:4.6.3-1ubuntu5
> gcc-4.6 4.6.3-1ubuntu5
> gcc-4.6-base 4.6.3-1ubuntu5
> libacl1 2.2.51-5ubuntu1
> libattr1 1:2.4.46-5ubuntu1
> libbz2-1.0 1.0.6-1
> libc-bin 2.15-0ubuntu10
> libc6 2.15-0ubuntu10
> libgcc1 1:4.6.3-1ubuntu5
> libgmp10 2:5.0.2+dfsg-2ubuntu1
> libgomp1 4.6.3-1ubuntu5
> liblzma5 5.1.1alpha+20110809-3
> libmpc2 0.9-4
> libmpfr4 3.1.0-3ubuntu2
> libquadmath0 4.6.3-1ubuntu5
> libselinux1 2.1.0-4.1ubuntu1
> libstdc++6 4.6.3-1ubuntu5
> make 3.81-8.1ubuntu1
> module-init-tools 3.16-1ubuntu2
> multiarch-support 2.15-0ubuntu10
> patch 2.6.1-3
> perl-base 5.14.2-6ubuntu2
> tar 1.26-4ubuntu1
> tzdata 2012b-1
> xz-utils 5.1.1alpha+20110809-3
> zlib1g 1:1.2.3.4.dfsg-3ubuntu4
> DistroRelease: Ubuntu 12.04
> InstallationMedia: Ubuntu-Server 12.04 LTS "Precise Pangolin" - Release
> i386 (20120424.1)
> Package: dkms 2.2.0.3-1ubuntu3
> PackageArchitecture: all
> ProcEnviron:
> LC_CTYPE=en_CA.UTF-8
> TERM=xterm
> LC_COLLATE=en_CA.UTF-8
> LANG=en_US.UTF-8
> LC_MESSAGES=en_CA.UTF-8
> SHELL=/bin/bash
> ProcVersionSignature: Ubuntu 3.2.0-24.37-generic-pae 3....

Pavel,

Can you update the test case portion of the description? Thanks. After that, I'll resubmit the merge request.

Also, can somebody target this bug for Precise? Thanks.

To reproduce this bug:
1. Download test tarball which contains trivial kernel module, Makefile and dkms.conf
wget https://bugs.launchpad.net/ubuntu/+source/dkms/+bug/989998/+attachment/3217817/+files/bug989998_test.tbz

2. Untar and put into /usr/src
sudo tar -C /usr/src -xvf bug989998_test.tbz

3. Try to build .deb
for cmd in add build mktarball mkdeb; do sudo dkms $cmd bug989998/0.0; done

Observe mkdeb step fail:
...
Copying DKMS tarball into DKMS tree...
Building binary package.../usr/sbin/dkms: line 81: dpkg-buildpackage: command not found
(bad exit status: 127)
Error! There was a problem creating your deb.

I've uploaded this change to quantal.

This isn't appropriate for an SRU to precise, so I'm marking it as such.

Thanks!

This bug was fixed in the package dkms - 2.2.0.3-1ubuntu5

---------------
dkms (2.2.0.3-1ubuntu5) quantal; urgency=low

  * debian/control: added 'dpkg-dev' and 'debhelper' to Suggests (LP:
    #989998)
 -- Aditya Vaidya <email address hidden> Wed, 11 Jul 2012 08:28:02 -0400