Ubuntu
firefox package

Firefox and Thunderbird don't appear in the (new) appstream metadata

Bug #1639863 reported by Iain Lane
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
firefox (Ubuntu)
Fix Released
Medium
Olivier Tilloy
thunderbird (Ubuntu)
Fix Released
Medium
Olivier Tilloy

Bug Description

The new generator doesn't understand symlinks unfortunately, so Firefox and Thunderbird don't appear.

http://appstream.staging.ubuntu.com/zesty/main/issues/firefox.html

laney@nightingale> ls /usr/share/pixmaps/firefox.png
lrwxrwxrwx 1 root root 46 Oct 25 15:34 /usr/share/pixmaps/firefox.png -> ../../lib/firefox/browser/icons/mozicon128.png

To make them work, /usr/share/pixmaps/firefox.png should be a real file. It could either be a copy of the file, or /usr/lib/firefox/browser/icons/mozicon128.png could be a symlink.

Iain Lane (laney)
Changed in firefox (Ubuntu):
assignee: nobody → FanJun Kong - ( BH1SCW ) (fjkong)
Changed in thunderbird (Ubuntu):
assignee: nobody → FanJun Kong - ( BH1SCW ) (fjkong)
FanJun Kong - ( BH1SCW ) (fjkong)
Changed in firefox (Ubuntu):
status: New → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in thunderbird (Ubuntu):
status: New → Confirmed
Revision history for this message
AsciiWolf (asciiwolf) wrote :

Any update? It seems that the issue is still present in latest Ubuntu Focal: https://appstream.ubuntu.com/focal/main/issues/firefox.html

Revision history for this message
Olivier Tilloy (osomon) wrote :

Unassigning and resetting the status as this doesn't appear to have been worked on.

Changed in firefox (Ubuntu):
assignee: FanJun Kong - ( BH1SCW ) (fjkong) → nobody
Changed in thunderbird (Ubuntu):
assignee: FanJun Kong - ( BH1SCW ) (fjkong) → nobody
Changed in firefox (Ubuntu):
status: In Progress → Confirmed
Revision history for this message
Olivier Tilloy (osomon) wrote :

I'm not familiar with the generator code (I don't even know where it lives to be honest). How hard would it be to make it understand symlinks? (I'm not opposed to implementing Laney's suggestion though, I just want to get a better understanding of the problem).

Revision history for this message
Iain Lane (laney) wrote :

The appstream-generator (https://github.com/ximion/appstream-generator) uses the 'md5sums' file present in .deb archives to retrieve the list of contents, and this file doesn't contain information for symlinks - that's why the icon can't be found. It does that for speed, since reading the contents from the actual data.tar.gz/xz would require reading the entire file and that would be too slow.

So the patch to read the symlink would be technically easy, but I don't think it would be accepted.

Revision history for this message
Olivier Tilloy (osomon) wrote :

slightly related: bug #1871723

Olivier Tilloy (osomon)
Changed in firefox (Ubuntu):
assignee: nobody → Olivier Tilloy (osomon)
importance: Undecided → Medium
status: Confirmed → In Progress
Revision history for this message
Olivier Tilloy (osomon) wrote :

Fixed with https://bazaar.launchpad.net/~mozillateam/firefox/firefox.focal/revision/1375.

Changed in firefox (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Olivier Tilloy (osomon) wrote :

Fixed with https://bazaar.launchpad.net/~mozillateam/thunderbird/thunderbird.groovy/revision/531.

Changed in thunderbird (Ubuntu):
assignee: nobody → Olivier Tilloy (osomon)
importance: Undecided → Medium
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package thunderbird - 1:68.7.0+build1-0ubuntu4

---------------
thunderbird (1:68.7.0+build1-0ubuntu4) groovy; urgency=medium

  * Do not install an xpm icon
    - debian/rules

 -- Olivier Tilloy <email address hidden> Wed, 29 Apr 2020 19:20:23 +0200

Changed in thunderbird (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package firefox - 76.0+build2-0ubuntu0.19.10.1

---------------
firefox (76.0+build2-0ubuntu0.19.10.1) eoan; urgency=medium

  * New upstream stable release (76.0+build2)

  * Fix the extraction of langpack names on xenial
    - debian/build/xpi-id.py

 -- Olivier Tilloy <email address hidden> Thu, 30 Apr 2020 14:01:11 +0200

Changed in firefox (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package firefox - 76.0+build2-0ubuntu0.18.04.1

---------------
firefox (76.0+build2-0ubuntu0.18.04.1) bionic; urgency=medium

  * New upstream stable release (76.0+build2)

  * Replace hardcoded occurrence of "firefox" with $(MOZ_PKG_NAME)
    - debian/build/rules.mk
  * Fix the extraction of langpack names on xenial
    - debian/build/xpi-id.py

 -- Olivier Tilloy <email address hidden> Thu, 30 Apr 2020 13:57:37 +0200

Changed in firefox (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package firefox - 76.0+build2-0ubuntu0.16.04.1

---------------
firefox (76.0+build2-0ubuntu0.16.04.1) xenial; urgency=medium

  * New upstream stable release (76.0+build2)

 -- Olivier Tilloy <email address hidden> Thu, 30 Apr 2020 13:50:34 +0200

Changed in firefox (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.