| 2011-04-21 01:08:51 |
Nils Maier |
bug |
|
|
added bug |
| 2011-04-21 01:12:44 |
Nils Maier |
bug task added |
|
globalmenu-extension |
|
| 2011-04-21 03:12:58 |
Nils Maier |
branch linked |
|
lp:~testnutzer123/globalmenu-extension/js-scope-fixes |
|
| 2011-04-21 11:10:33 |
Chris Coulson |
globalmenu-extension: importance |
Undecided |
High |
|
| 2011-04-21 11:10:36 |
Chris Coulson |
globalmenu-extension: status |
New |
Triaged |
|
| 2011-04-21 11:10:45 |
Chris Coulson |
affects |
firefox (Ubuntu) |
ubuntu |
|
| 2011-04-21 11:10:53 |
Chris Coulson |
nominated for series |
|
Ubuntu Natty |
|
| 2011-04-21 11:10:53 |
Chris Coulson |
bug task added |
|
Ubuntu Natty |
|
| 2011-04-21 11:10:59 |
Chris Coulson |
Ubuntu Natty: status |
New |
Triaged |
|
| 2011-04-21 11:11:02 |
Chris Coulson |
Ubuntu Natty: importance |
Undecided |
High |
|
| 2011-04-21 11:11:24 |
Chris Coulson |
nominated for series |
|
Ubuntu Oneiric |
|
| 2011-04-21 11:11:24 |
Chris Coulson |
bug task added |
|
Ubuntu Oneiric |
|
| 2011-04-21 11:11:32 |
Chris Coulson |
Ubuntu Oneiric: importance |
Undecided |
Medium |
|
| 2011-04-21 11:11:34 |
Chris Coulson |
Ubuntu Oneiric: status |
New |
Triaged |
|
| 2011-04-21 11:11:40 |
Chris Coulson |
Ubuntu Natty: milestone |
|
natty-updates |
|
| 2011-04-21 11:11:48 |
Chris Coulson |
affects |
Ubuntu Natty |
firefox (Ubuntu Natty) |
|
| 2011-04-21 11:12:10 |
Chris Coulson |
bug task added |
|
thunderbird (Ubuntu) |
|
| 2011-04-21 11:12:18 |
Chris Coulson |
thunderbird (Ubuntu Natty): importance |
Undecided |
High |
|
| 2011-04-21 11:12:20 |
Chris Coulson |
thunderbird (Ubuntu Natty): status |
New |
Triaged |
|
| 2011-04-21 11:12:22 |
Chris Coulson |
thunderbird (Ubuntu Oneiric): status |
New |
Triaged |
|
| 2011-04-21 11:12:25 |
Chris Coulson |
thunderbird (Ubuntu Oneiric): importance |
Undecided |
Medium |
|
| 2011-04-21 11:12:28 |
Chris Coulson |
thunderbird (Ubuntu Natty): milestone |
|
natty-updates |
|
| 2011-04-21 11:12:37 |
Chris Coulson |
firefox (Ubuntu Natty): assignee |
|
Chris Coulson (chrisccoulson) |
|
| 2011-04-21 11:12:39 |
Chris Coulson |
thunderbird (Ubuntu Natty): assignee |
|
Chris Coulson (chrisccoulson) |
|
| 2011-04-21 11:27:29 |
Chris Coulson |
nominated for series |
|
globalmenu-extension/1.0 |
|
| 2011-04-21 11:27:29 |
Chris Coulson |
bug task added |
|
globalmenu-extension/1.0 |
|
| 2011-04-21 11:27:29 |
Chris Coulson |
nominated for series |
|
globalmenu-extension/trunk |
|
| 2011-04-21 11:27:29 |
Chris Coulson |
bug task added |
|
globalmenu-extension/trunk |
|
| 2011-04-21 11:27:40 |
Chris Coulson |
globalmenu-extension/1.0: importance |
Undecided |
High |
|
| 2011-04-21 11:27:42 |
Chris Coulson |
globalmenu-extension/1.0: status |
New |
Triaged |
|
| 2011-04-21 11:27:45 |
Chris Coulson |
globalmenu-extension/trunk: importance |
High |
Medium |
|
| 2011-04-21 11:27:49 |
Chris Coulson |
globalmenu-extension/1.0: assignee |
|
Chris Coulson (chrisccoulson) |
|
| 2011-04-21 11:27:51 |
Chris Coulson |
globalmenu-extension/1.0: milestone |
|
1.0.3 |
|
| 2011-04-21 11:27:54 |
Chris Coulson |
globalmenu-extension/trunk: milestone |
|
2.0 |
|
| 2011-04-21 15:29:47 |
Chris Coulson |
globalmenu-extension/trunk: status |
Triaged |
Fix Committed |
|
| 2011-04-21 15:30:39 |
Launchpad Janitor |
branch linked |
|
lp:globalmenu-extension |
|
| 2011-04-21 15:39:13 |
Launchpad Janitor |
branch linked |
|
lp:globalmenu-extension/1.0 |
|
| 2011-04-21 15:39:42 |
Chris Coulson |
globalmenu-extension/1.0: status |
Triaged |
Fix Committed |
|
| 2011-04-21 16:06:22 |
Chris Coulson |
globalmenu-extension/1.0: status |
Fix Committed |
Fix Released |
|
| 2011-04-21 16:12:50 |
Launchpad Janitor |
branch linked |
|
lp:firefox/4.0 |
|
| 2011-04-21 16:16:21 |
Chris Coulson |
firefox (Ubuntu Oneiric): status |
Triaged |
Fix Committed |
|
| 2011-04-21 16:16:42 |
Chris Coulson |
firefox (Ubuntu Natty): status |
Triaged |
Fix Committed |
|
| 2011-04-21 16:23:14 |
Launchpad Janitor |
branch linked |
|
lp:~mozillateam/firefox/firefox-4.0.natty |
|
| 2011-04-21 16:29:12 |
Launchpad Janitor |
branch linked |
|
lp:thunderbird/3.1 |
|
| 2011-04-21 16:30:47 |
Chris Coulson |
thunderbird (Ubuntu Oneiric): status |
Triaged |
Fix Committed |
|
| 2011-04-21 16:30:49 |
Chris Coulson |
thunderbird (Ubuntu Natty): status |
Triaged |
Fix Committed |
|
| 2011-04-21 16:31:24 |
Launchpad Janitor |
branch linked |
|
lp:~mozillateam/thunderbird/thunderbird.natty |
|
| 2011-04-21 19:25:07 |
Micah Gersten |
description |
Binary package hint: firefox
The globalmenu extension overlays browser.xul and loads firefoxMenu.js, adding a lot of new variables/functions to the shared scope, at least:
nsIObserverService !
uIGlobalMenuLoader
uIGlobalMenuService
observer !
Observer() !
onLoad() !
onUnload() !
PlacesMenuUnityImpl()
HistoryMenuUnityImpl()
(! marks names with high chance of conflicts)
This is a problem as the regular browser code, all other extensions overlaying the browser window and this extension share the same scope, i.e. the same namespace.
If other extensions happen to define the same scope-global names, then conflicts will occur. Whoever loads last wins. Hence there is a high probability of heisenbugs (depending on the other extensions a user installs).
I'm a volunteer addons.mozilla.org editor, performing required code reviews an extension, this would be a definite show-stopper bug to any public listing.
You can either "hide" your stuff within a function, use some "namespace" variable, or a mixture of both, e.g.:
if (!com) var com = {};
if (!com.canonical) com.canonical = {};
(function() {
// local/"hidden" stuff
function load() {
removeEventListener("load", load, false);
...
}
addEventListener("load", load, false);
// globally visible
this.Unity = { // |this| is com.canonical
PlacesMenuUnityImpl: ...
};
}).call(com.canonical);
(in the xul overlay you would then change all references to PlacesMenuUnityImpl to com.canonical.Unity.PlacesMenuUnityImpl)
Also see:
https://developer.mozilla.org/en/XUL_School/JavaScript_Object_Management |
REASON FOR SRU:
Polluting the global namespace isn't friendly and will break either the globalmenu extension or other extensions that people install.
--------------------------------------------------
Binary package hint: firefox
The globalmenu extension overlays browser.xul and loads firefoxMenu.js, adding a lot of new variables/functions to the shared scope, at least:
nsIObserverService !
uIGlobalMenuLoader
uIGlobalMenuService
observer !
Observer() !
onLoad() !
onUnload() !
PlacesMenuUnityImpl()
HistoryMenuUnityImpl()
(! marks names with high chance of conflicts)
This is a problem as the regular browser code, all other extensions overlaying the browser window and this extension share the same scope, i.e. the same namespace.
If other extensions happen to define the same scope-global names, then conflicts will occur. Whoever loads last wins. Hence there is a high probability of heisenbugs (depending on the other extensions a user installs).
I'm a volunteer addons.mozilla.org editor, performing required code reviews an extension, this would be a definite show-stopper bug to any public listing.
You can either "hide" your stuff within a function, use some "namespace" variable, or a mixture of both, e.g.:
if (!com) var com = {};
if (!com.canonical) com.canonical = {};
(function() {
// local/"hidden" stuff
function load() {
removeEventListener("load", load, false);
...
}
addEventListener("load", load, false);
// globally visible
this.Unity = { // |this| is com.canonical
PlacesMenuUnityImpl: ...
};
}).call(com.canonical);
(in the xul overlay you would then change all references to PlacesMenuUnityImpl to com.canonical.Unity.PlacesMenuUnityImpl)
Also see:
https://developer.mozilla.org/en/XUL_School/JavaScript_Object_Management |
|
| 2011-04-29 21:16:10 |
Launchpad Janitor |
firefox (Ubuntu Natty): status |
Fix Committed |
Fix Released |
|
| 2011-05-01 00:02:14 |
Launchpad Janitor |
branch linked |
|
lp:ubuntu/natty-security/firefox |
|
| 2011-05-03 22:08:14 |
Antonis Kanouras |
bug |
|
|
added subscriber Antonis Kanouras |
| 2011-05-05 03:05:04 |
Launchpad Janitor |
thunderbird (Ubuntu Natty): status |
Fix Committed |
Fix Released |
|
| 2011-05-05 03:26:13 |
Launchpad Janitor |
branch linked |
|
lp:ubuntu/natty-security/thunderbird |
|
| 2011-05-05 09:23:46 |
Micah Gersten |
firefox (Ubuntu Oneiric): status |
Fix Committed |
Fix Released |
|
| 2011-05-05 09:24:05 |
Micah Gersten |
thunderbird (Ubuntu Oneiric): status |
Fix Committed |
Fix Released |
|
| 2011-05-05 10:24:22 |
Launchpad Janitor |
branch linked |
|
lp:ubuntu/thunderbird |
|
| 2011-06-05 12:47:32 |
Chris Coulson |
globalmenu-extension/trunk: status |
Fix Committed |
Fix Released |
|
