| 2022-07-07 07:44:23 |
Alexandre Ghiti |
bug |
|
|
added bug |
| 2022-07-07 08:08:50 |
Alexandre Ghiti |
description |
https://bugs.launchpad.net/ubuntu/+source/flash-kernel/+bug/1863145 introduced a test at the beginning of main() to skip flash-kernel completely if we are in a container: that logic breaks the creation of RISC-V images where we need flash-kernel to run in order to install the dtb at the right location for update-grub.
So introduce a new environment variable that allows to bypass this test in such circumstances: FK_FORCE_CONTAINER must be equal to "yes" to skip the test and allow flash-kernel to run. |
https://bugs.launchpad.net/ubuntu/+source/flash-kernel/+bug/1863145 introduced a test at the beginning of main() to skip flash-kernel completely if we are in a container: that logic breaks the creation of RISC-V images where we need flash-kernel to run in order to install the dtb at the right location for update-grub.
So introduce a new environment variable that allows to bypass this test in such circumstances: FK_FORCE_CONTAINER must be equal to "yes" to skip the test and allow flash-kernel to run.
[Impact]
RISC-V images build needs to run flash-kernel to install the dtb for update-grub
to find. Currently, Ubuntu has a delta that prevents flash-kernel to run in a
container but our infrastructure runs the images build inside a container which
breaks the installation of the dtb on RISC-V images.
We fix this by adding a new environment variable which will be set to "yes" only
when building a RISC-V image.
[Test Plan]
To reproduce this bug, we only need to launch livecd-rootfs inside a LXC container.
To test this fix, I'll patch livecd-rootfs in order to set the new environment
variable and we'll trigger a new build of a RISC-V image from launchpad.
[Where problems could occur]
We must take care at not breaking other images builds, so great attention to the
patch must be paid so that it only changes the current behaviour when we set
the environment variable. The chosen variable name is specific enough as it likely
won't be used (i.e.: FK_FORCE_CONTAINER).
[Other Info]
This patch is needed in Jammy as we intend to publish new RISC-V images for 22.04.1. |
|
| 2022-07-07 08:09:31 |
Alexandre Ghiti |
description |
https://bugs.launchpad.net/ubuntu/+source/flash-kernel/+bug/1863145 introduced a test at the beginning of main() to skip flash-kernel completely if we are in a container: that logic breaks the creation of RISC-V images where we need flash-kernel to run in order to install the dtb at the right location for update-grub.
So introduce a new environment variable that allows to bypass this test in such circumstances: FK_FORCE_CONTAINER must be equal to "yes" to skip the test and allow flash-kernel to run.
[Impact]
RISC-V images build needs to run flash-kernel to install the dtb for update-grub
to find. Currently, Ubuntu has a delta that prevents flash-kernel to run in a
container but our infrastructure runs the images build inside a container which
breaks the installation of the dtb on RISC-V images.
We fix this by adding a new environment variable which will be set to "yes" only
when building a RISC-V image.
[Test Plan]
To reproduce this bug, we only need to launch livecd-rootfs inside a LXC container.
To test this fix, I'll patch livecd-rootfs in order to set the new environment
variable and we'll trigger a new build of a RISC-V image from launchpad.
[Where problems could occur]
We must take care at not breaking other images builds, so great attention to the
patch must be paid so that it only changes the current behaviour when we set
the environment variable. The chosen variable name is specific enough as it likely
won't be used (i.e.: FK_FORCE_CONTAINER).
[Other Info]
This patch is needed in Jammy as we intend to publish new RISC-V images for 22.04.1. |
https://bugs.launchpad.net/ubuntu/+source/flash-kernel/+bug/1863145 introduced a test at the beginning of main() to skip flash-kernel completely if we are in a container: that logic breaks the creation of RISC-V images where we need flash-kernel to run in order to install the dtb at the right location for update-grub.
So introduce a new environment variable that allows to bypass this test in such circumstances: FK_FORCE_CONTAINER must be equal to "yes" to skip the test and allow flash-kernel to run.
[Impact]
RISC-V images build needs to run flash-kernel to install the dtb for update-grub to find. Currently, Ubuntu has a delta that prevents flash-kernel to run in a container but our infrastructure runs the images build inside a container which breaks the installation of the dtb on RISC-V images.
We fix this by adding a new environment variable which will be set to "yes" only when building a RISC-V image.
[Test Plan]
To reproduce this bug, we only need to launch livecd-rootfs inside a LXC container.
To test this fix, I'll patch livecd-rootfs in order to set the new environment variable and we'll trigger a new build of a RISC-V image from launchpad.
[Where problems could occur]
We must take care at not breaking other images builds, so great attention to the patch must be paid so that it only changes the current behaviour when we set the environment variable. The chosen variable name is specific enough as it likely won't be used (i.e.: FK_FORCE_CONTAINER).
[Other Info]
This patch is needed in Jammy as we intend to publish new RISC-V images for 22.04.1. |
|
| 2022-07-11 11:28:26 |
Alexandre Ghiti |
attachment added |
|
debdiff_kinetic https://bugs.launchpad.net/ubuntu/+source/flash-kernel/+bug/1980929/+attachment/5602367/+files/debdiff_kinetic |
|
| 2022-07-11 11:28:45 |
Alexandre Ghiti |
attachment added |
|
debdiff_jammy https://bugs.launchpad.net/ubuntu/+source/flash-kernel/+bug/1980929/+attachment/5602368/+files/debdiff_jammy |
|
| 2022-07-11 11:37:18 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~alexghiti/livecd-rootfs/+git/livecd-rootfs/+merge/426623 |
|
| 2022-07-11 13:56:15 |
Dave Jones |
description |
https://bugs.launchpad.net/ubuntu/+source/flash-kernel/+bug/1863145 introduced a test at the beginning of main() to skip flash-kernel completely if we are in a container: that logic breaks the creation of RISC-V images where we need flash-kernel to run in order to install the dtb at the right location for update-grub.
So introduce a new environment variable that allows to bypass this test in such circumstances: FK_FORCE_CONTAINER must be equal to "yes" to skip the test and allow flash-kernel to run.
[Impact]
RISC-V images build needs to run flash-kernel to install the dtb for update-grub to find. Currently, Ubuntu has a delta that prevents flash-kernel to run in a container but our infrastructure runs the images build inside a container which breaks the installation of the dtb on RISC-V images.
We fix this by adding a new environment variable which will be set to "yes" only when building a RISC-V image.
[Test Plan]
To reproduce this bug, we only need to launch livecd-rootfs inside a LXC container.
To test this fix, I'll patch livecd-rootfs in order to set the new environment variable and we'll trigger a new build of a RISC-V image from launchpad.
[Where problems could occur]
We must take care at not breaking other images builds, so great attention to the patch must be paid so that it only changes the current behaviour when we set the environment variable. The chosen variable name is specific enough as it likely won't be used (i.e.: FK_FORCE_CONTAINER).
[Other Info]
This patch is needed in Jammy as we intend to publish new RISC-V images for 22.04.1. |
https://bugs.launchpad.net/ubuntu/+source/flash-kernel/+bug/1863145 introduced a test at the beginning of main() to skip flash-kernel completely if we are in a container: that logic breaks the creation of RISC-V images where we need flash-kernel to run in order to install the dtb at the right location for update-grub.
So introduce a new environment variable that allows to bypass this test in such circumstances: FK_FORCE_CONTAINER must be equal to "yes" to skip the test and allow flash-kernel to run.
[Impact]
RISC-V images build needs to run flash-kernel to install the dtb for update-grub to find. Currently, Ubuntu has a delta that prevents flash-kernel to run in a container but our infrastructure runs the images build inside a container which breaks the installation of the dtb on RISC-V images.
We fix this by adding a new environment variable which will be set to "yes" only when building a RISC-V image.
[Test Plan]
To reproduce this bug, we only need to launch livecd-rootfs inside a LXC container.
To test this fix, I'll patch livecd-rootfs in order to set the new environment variable and we'll trigger a new build of a RISC-V image from launchpad.
[Where problems could occur]
We must take care at not breaking other images builds, or boot on the cloud images (the reason for initial introduction of the container test in LP: #1863145), so great attention to the patch must be paid so that it only changes the current behaviour when we set the environment variable. The chosen variable name is specific enough as it likely won't be used (i.e.: FK_FORCE_CONTAINER).
[Other Info]
This patch is needed in Jammy as we intend to publish new RISC-V images for 22.04.1. |
|
| 2022-07-13 14:12:08 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~alexghiti/livecd-rootfs/+git/livecd-rootfs/+merge/426825 |
|
| 2022-07-14 12:21:07 |
Dave Jones |
nominated for series |
|
Ubuntu Kinetic |
|
| 2022-07-14 12:21:07 |
Dave Jones |
bug task added |
|
flash-kernel (Ubuntu Kinetic) |
|
| 2022-07-14 12:21:07 |
Dave Jones |
nominated for series |
|
Ubuntu Jammy |
|
| 2022-07-14 12:21:07 |
Dave Jones |
bug task added |
|
flash-kernel (Ubuntu Jammy) |
|
| 2022-07-14 12:39:00 |
Łukasz Zemczak |
bug task added |
|
livecd-rootfs (Ubuntu) |
|
| 2022-07-14 13:34:24 |
Dave Jones |
summary |
Allow to bypass container exit test |
[SRU] Allow to bypass container exit test |
|
| 2022-07-14 13:37:49 |
Dave Jones |
description |
https://bugs.launchpad.net/ubuntu/+source/flash-kernel/+bug/1863145 introduced a test at the beginning of main() to skip flash-kernel completely if we are in a container: that logic breaks the creation of RISC-V images where we need flash-kernel to run in order to install the dtb at the right location for update-grub.
So introduce a new environment variable that allows to bypass this test in such circumstances: FK_FORCE_CONTAINER must be equal to "yes" to skip the test and allow flash-kernel to run.
[Impact]
RISC-V images build needs to run flash-kernel to install the dtb for update-grub to find. Currently, Ubuntu has a delta that prevents flash-kernel to run in a container but our infrastructure runs the images build inside a container which breaks the installation of the dtb on RISC-V images.
We fix this by adding a new environment variable which will be set to "yes" only when building a RISC-V image.
[Test Plan]
To reproduce this bug, we only need to launch livecd-rootfs inside a LXC container.
To test this fix, I'll patch livecd-rootfs in order to set the new environment variable and we'll trigger a new build of a RISC-V image from launchpad.
[Where problems could occur]
We must take care at not breaking other images builds, or boot on the cloud images (the reason for initial introduction of the container test in LP: #1863145), so great attention to the patch must be paid so that it only changes the current behaviour when we set the environment variable. The chosen variable name is specific enough as it likely won't be used (i.e.: FK_FORCE_CONTAINER).
[Other Info]
This patch is needed in Jammy as we intend to publish new RISC-V images for 22.04.1. |
https://bugs.launchpad.net/ubuntu/+source/flash-kernel/+bug/1863145 introduced a test at the beginning of main() to skip flash-kernel completely if we are in a container: that logic breaks the creation of RISC-V images where we need flash-kernel to run in order to install the dtb at the right location for update-grub.
So introduce a new environment variable that allows to bypass this test in such circumstances: FK_FORCE_CONTAINER must be equal to "yes" to skip the test and allow flash-kernel to run.
[Impact]
RISC-V images build needs to run flash-kernel to install the dtb for update-grub to find. Currently, Ubuntu has a delta that prevents flash-kernel to run in a container but our infrastructure runs the images build inside a container which breaks the installation of the dtb on RISC-V images.
We fix this by adding a new environment variable which will be set to "yes" only when building a RISC-V image.
[Test Plan]
To reproduce this bug, we need to launch livecd-rootfs inside a LXC container.
To test this fix, I'll patch livecd-rootfs in order to set the new environment variable and we'll trigger a new build of a RISC-V image from launchpad.
Additionally, an Ubuntu Server image should be spun up in a LXC container, and flash-kernel from the -proposed pocket should be executed to ensure it does *not* run:
* Launch an Ubuntu Jammy image in LXD: lxc launch ubuntu:j test-fk
* Shell into the instance: lxc exec test-fk bash
* Enable proposed (https://wiki.ubuntu.com/Testing/EnableProposed)
* Update flash-kernel to the proposed version: apt install -t jammy-proposed flash-kernel
* Run flash-kernel if the update did not already: flash-kernel
* Ensure it exited cleanly without doing anything (echo $? and check /boot looks the same?)
[Where problems could occur]
We must take care at not breaking other images builds, or boot on the cloud images (the reason for initial introduction of the container test in LP: #1863145), so great attention to the patch must be paid so that it only changes the current behaviour when we set the environment variable. The chosen variable name is specific enough as it likely won't be used (i.e.: FK_FORCE_CONTAINER).
[Other Info]
This patch is needed in Jammy as we intend to publish new RISC-V images for 22.04.1. |
|
| 2022-07-14 13:48:39 |
Łukasz Zemczak |
livecd-rootfs (Ubuntu Jammy): status |
New |
Fix Committed |
|
| 2022-07-14 13:48:40 |
Łukasz Zemczak |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2022-07-14 13:48:42 |
Łukasz Zemczak |
bug |
|
|
added subscriber SRU Verification |
| 2022-07-14 13:48:45 |
Łukasz Zemczak |
tags |
|
verification-needed verification-needed-jammy |
|
| 2022-07-14 15:35:26 |
Launchpad Janitor |
flash-kernel (Ubuntu Kinetic): status |
New |
Fix Released |
|
| 2022-07-14 22:49:23 |
Łukasz Zemczak |
flash-kernel (Ubuntu Jammy): status |
New |
Fix Committed |
|
| 2022-07-21 17:19:58 |
Launchpad Janitor |
livecd-rootfs (Ubuntu Kinetic): status |
New |
Fix Released |
|
| 2022-07-27 18:10:04 |
Łukasz Zemczak |
tags |
verification-needed verification-needed-jammy |
verification-done verification-done-jammy |
|
| 2022-07-27 18:10:33 |
Łukasz Zemczak |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2022-07-27 18:10:31 |
Launchpad Janitor |
livecd-rootfs (Ubuntu Jammy): status |
Fix Committed |
Fix Released |
|
| 2022-07-28 13:42:12 |
Launchpad Janitor |
flash-kernel (Ubuntu Jammy): status |
Fix Committed |
Fix Released |
|
