Character limit does not respect selected services

Bug #1168457 reported by Frederik Elwert
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
friends-app (Ubuntu)
In Progress
High
Kai Mast

Bug Description

When posting new messages, the character limit does not take the active services into account. E.g., when having twitter disabled and only posting to facebook, the limit of 140 characters is still applied.

Gwibber had the same bug, it is bug #522986. But in Friends this is somehow more severe, as Gwibber allowed to post over-length entries, so one could ignore the 140 limit for facebook-only posts. In Friends, one cannot post entries that exceed the limit.

ProblemType: Bug
DistroRelease: Ubuntu 13.04
Package: friends-app 0.90.0bzr13.04.11-0ubuntu1
ProcVersionSignature: Ubuntu 3.8.0-17.27-generic 3.8.6
Uname: Linux 3.8.0-17-generic i686
ApportVersion: 2.9.2-0ubuntu8
Architecture: i386
CheckboxSubmission: 688d20c2367428cd47393f8945b33f66
CheckboxSystem: b845c366ea09c60efa3a45c1b5b21525
Date: Fri Apr 12 17:38:45 2013
InstallationDate: Installed on 2011-08-05 (616 days ago)
InstallationMedia: Ubuntu 11.10 "Oneiric Ocelot" - Alpha i386 (20110803.1)
MarkForUpload: True
SourcePackage: friends-app
UpgradeStatus: Upgraded to raring on 2013-04-05 (6 days ago)

Revision history for this message
Frederik Elwert (frederik-elwert) wrote :
Revision history for this message
Robert Bruce Park (robru) wrote :

Huh, strange. A few weeks ago friends-app didn't do any length checking at all ;-) I'm not sure when this creeped in.

Changed in friends-app (Ubuntu):
status: New → Triaged
importance: Undecided → High
assignee: nobody → Ken VanDine (ken-vandine)
Revision history for this message
Kai Mast (kai-mast) wrote :

I removed the counter in my new-postview branch. Have to check if it is resolved there (at least on the Conversation page).

Revision history for this message
Kai Mast (kai-mast) wrote :

Mh what would be the desired way to do this?

The EntryField now has a property for the maximum message length. Ideally, this should come from qml-friends but we could also hardcode it in friends-app for now as a workaround (same as isMicroblogging ).

Revision history for this message
Robert Bruce Park (robru) wrote :

Tough to say. I think the *ideal* solution would be to define the maximum message lengths in *friends* itself, since that's there most of the platform-specific info is encapsulated. The only problem is that there's no good way to communicate that from friends to friends-app. So, it would require a pretty massive overhaul to be able to communicate those between (like, we'd need to add methods to the dbus interface, which requires a painful transition).

At this point, I'd just as well code it directly in friends-app, because a) it's not something that's likely to change, so there's little value in being able to query it from the services, and b) it's the path of least resistence.

Revision history for this message
Kai Mast (kai-mast) wrote :

Okay. I'll propose a branch soon ;)

Changed in friends-app (Ubuntu):
status: Triaged → In Progress
assignee: Ken VanDine (ken-vandine) → Kai Mast (kai-mast)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.