UIFe: update for the new snap store naming and icon

We are not uploading the App Center SVG to Yaru — at least not in time —, are we?

If so this is less trivial of a change because we will need to include it in the patch file and just replace the value

  <property name="icon-name">snapcraft-symbolic</property>

directly in gis-apps-page.ui.

In this case I propose simply ensuring the naming of the App Center is correct in those two locations and leaving the image as-is for this release.

screenshot of the UI before the change for reference

Without quotation marks, merge request in Salsa: https://salsa.debian.org/gnome-team/gnome-initial-setup/-/merge_requests/15.

Please don't mark freeze exception bugs 'in progress' before they've been approved by the release team. Freeze bugs are process bugs and the bug state is used by the team to identify pending requests.

As this is about fixing a string which today is factually incorrect because it uses the wrong name for an app, UIFe granted.

Please automate as much as possible the update of translations by identifying those which include '"Ubuntu Software"' (with quotes) in the translation and replace this string with 'App Center'. This will give a better experience for users at release time for languages whose translators do not have time to review the string between now and release, vs having the string entirely untranslated.

(Translation teams may choose to translate 'App Center' into their language despite having chosen to leave "Ubuntu Software" untranslated, both because "Ubuntu Software" is quoted and because Ubuntu is a proper name. Nevertheless, it's better to give them an initial find-and-replace translation than not.)

I can confirm that there are no remaining instances of >Ubuntu Software<
in the entire code base.

uploaded, I haven't include strings changes in the upload but will rather reupload a translations tarball with edited strings directly to launchpad which is easier to do

This bug was fixed in the package gnome-initial-setup - 45.0-1ubuntu3

---------------
gnome-initial-setup (45.0-1ubuntu3) mantic; urgency=medium

  * debian/patches/0001-Add-Ubuntu-mode-with-special-pages.patch:
    - update the 'Ready to go' screen for the ubuntu software -> app center
      change in mantic (lp: #2036981)

 -- Nathan Pratta Teodosio <email address hidden> Tue, 26 Sep 2023 11:20:36 +0200

> but it should be a trivial change for translators since only the appname is changing

This late change also affects documentation, and let me make it very clear: This kind of change in the documentation is anything but "trivial" for translators, since the name of the thing is often embedded in long strings (aka paragraphs).

It has been discussed at discourse for several weeks, and waiting with the decision so long indicates poor planning and a lack of consideration towards the volunteers who help with translation.

@Gunnar, right, I'm sorry about that. The store software was changed before UIF though and the request there only concern a string/icon in the initial setup page ... do we really have documentation with specific references to string on that wizard step?

@Sebastien: I hope I haven't misunderstood it. But we have docs saying e.g. "Click on the Ubuntu Software icon in the dock...", and we refer to the application as "Ubuntu Software" so the name of the thing has been Ubuntu Software all since Mark(?) made that decision around final freeze for 16.04 (bug #1570479).

And now the "thing" will be called App Center instead, if I understand it correctly.

@Gunnar, yes, but that's a change that landed earlier in the cycle and not what the bug you are commenting on is about...

In that case I apologize for my harsh tone in comment #12.

Exactly when did it land, and how was it announced? Apparently I missed that announcement.

The ubuntu-docs update fixes the source strings, but the translations are all invalidated by this despite the fact that many of them leave the string <app>Ubuntu Software</app> untranslated.

I want us to automate search/replace on <app>Ubuntu Software</app> to <app>App Center</app> so that we don't invalidate all of the existing translations for ubuntu-docs, this close to release. (Same concern that I expressed for gnome-initial-setup itself.) This is a little trickier because of the various multiline msgstrs in the .po files. I'll see if we can get this going today/tomorrow.

I will be taking care of auto-updating the translation strings.

Thanks Steve and Zixing Liu! Want to mention that the translators were notified about the name change:

https://lists.ubuntu.com/archives/ubuntu-translators/2023-September/007900.html

https://lists.ubuntu.com/archives/ubuntu-translators/2023-September/007902.html

But I suppose that it won't make a difference if some translators attend to it before some search/replace operation. In such cases there will simply not be anything to replace...

This bug was fixed in the package ubuntu-docs - 23.10.3

---------------
ubuntu-docs (23.10.3) mantic; urgency=medium

  * For languages where existing strings were translated keeping the name
    "Ubuntu Software" verbatim, replace this with the new name "App Center"
    to avoid unnecessarily regressing translation coverage. Translation
    teams might choose to translate the name "App Center" where they left
    "Ubuntu Software" untranslated, but leave this to reviews after the fact
    so that doc translations aren't regressed for release in the meantime.
    Thanks, Zixing Liu <email address hidden>.

 -- Steve Langasek <email address hidden> Tue, 26 Sep 2023 22:26:05 -0700