Activity log for bug #2039475

Date Who What changed Old value New value Message
2023-10-16 17:00:44 Sergio Costas bug added bug
2023-10-16 17:01:35 Sergio Costas attachment added patch.diff https://bugs.launchpad.net/ubuntu/+source/gnome-shell-extension-desktop-icons/+bug/2039475/+attachment/5709973/+files/patch.diff
2023-10-16 20:18:35 Ubuntu Foundations Team Bug Bot tags patch
2023-10-16 20:18:37 Ubuntu Foundations Team Bug Bot bug added subscriber Ubuntu Review Team
2023-10-18 08:04:12 Daniel van Vugt tags patch mantic patch
2023-10-18 08:04:36 Daniel van Vugt affects gnome-shell-extension-desktop-icons (Ubuntu) gnome-shell-extension-desktop-icons-ng (Ubuntu)
2023-10-18 14:06:13 Jeremy Bícha gnome-shell-extension-desktop-icons-ng (Ubuntu): status New Fix Committed
2023-10-18 14:09:33 Jeremy Bícha bug added subscriber Jeremy Bícha
2023-10-18 15:43:39 Sergio Costas description The port to Gnome Shell 45 of Desktop Icons had a bug that prevents it from honoring the Dock size when in "IntelliHide" mode, thus allowing to put icons under it. This bug has been fixed in upstream, so it should be ported to Mantic. [Impact] The port to Gnome Shell 45 of Desktop Icons had a bug that prevents it from honoring the Dock size when in "IntelliHide" mode, thus allowing to put icons under it. It has been fixed in upstream by fixing in DING the implementation of the protocol that allows other extensions (like Dash-to-dock, Dash-to-panel, Hide-top-bar and more) to notify DING which zones are being used by them and thus allow to avoid putting icons there, which would be unreachable when the panel/dock/bar are visible. [Test plan] Go to the extensions properties of Dash-to-dock or Ubuntu-dock and ensure that the "IntelliHide" option (which hides the dock when a window is below it, and shows it again when there's only "empty desktop" below it) is ENABLED, the option "panel mode: extend up to the screen borders" is DISABLED, and the "maximum size of the dock" is BELOW 100% (90% is fine). In an empty desktop (this is, without any window) the dock should be visible, with some free space in each side (top and bottom if the dock is vertical; left and right if it is horizontal) where the underlying desktop can be seen. Now, open any window and maximize it; the dock should hide, thus allowing the window to fill the whole screen. Close the window. The dock should appear again. Try to move a desktop icon (any icon; a folder, a file, the trash, the personal folder... any is right) into the free zone of any of the sides. If the patch works, it should NOT be possible to place the icon there; if the bug is present, then it will be possible to place the icon there. It must be also test if it is possible to put an icon in any place of the "free" desktop surface (this is: any zone that won't be obscured by a bar, dock or panel). [Where problems could occur] If there are problems, they can show in several ways: - the bugfix doesn't work, and thus it will still be possible to put icons in zones that should be forbidden - DING might fail and no icons would be visible - DING might wrongly interpret the data sent by other extensions, reducing too much the usable zone.
2023-10-18 15:46:55 Jeremy Bícha nominated for series Ubuntu Mantic
2023-10-18 15:46:55 Jeremy Bícha bug task added gnome-shell-extension-desktop-icons-ng (Ubuntu Mantic)
2023-10-18 15:48:08 Jeremy Bícha description [Impact] The port to Gnome Shell 45 of Desktop Icons had a bug that prevents it from honoring the Dock size when in "IntelliHide" mode, thus allowing to put icons under it. It has been fixed in upstream by fixing in DING the implementation of the protocol that allows other extensions (like Dash-to-dock, Dash-to-panel, Hide-top-bar and more) to notify DING which zones are being used by them and thus allow to avoid putting icons there, which would be unreachable when the panel/dock/bar are visible. [Test plan] Go to the extensions properties of Dash-to-dock or Ubuntu-dock and ensure that the "IntelliHide" option (which hides the dock when a window is below it, and shows it again when there's only "empty desktop" below it) is ENABLED, the option "panel mode: extend up to the screen borders" is DISABLED, and the "maximum size of the dock" is BELOW 100% (90% is fine). In an empty desktop (this is, without any window) the dock should be visible, with some free space in each side (top and bottom if the dock is vertical; left and right if it is horizontal) where the underlying desktop can be seen. Now, open any window and maximize it; the dock should hide, thus allowing the window to fill the whole screen. Close the window. The dock should appear again. Try to move a desktop icon (any icon; a folder, a file, the trash, the personal folder... any is right) into the free zone of any of the sides. If the patch works, it should NOT be possible to place the icon there; if the bug is present, then it will be possible to place the icon there. It must be also test if it is possible to put an icon in any place of the "free" desktop surface (this is: any zone that won't be obscured by a bar, dock or panel). [Where problems could occur] If there are problems, they can show in several ways: - the bugfix doesn't work, and thus it will still be possible to put icons in zones that should be forbidden - DING might fail and no icons would be visible - DING might wrongly interpret the data sent by other extensions, reducing too much the usable zone. [Impact] The port to Gnome Shell 45 of Desktop Icons had a bug that prevents it from honoring the Dock size when in "IntelliHide" mode, thus allowing to put icons under it. It has been fixed in upstream by fixing in DING the implementation of the protocol that allows other extensions (like Dash-to-dock, Dash-to-panel, Hide-top-bar and more) to notify DING which zones are being used by them and thus allow to avoid putting icons there, which would be unreachable when the panel/dock/bar are visible. [Test plan] Go to the extensions properties of Dash-to-dock or Ubuntu-dock and ensure that the "IntelliHide" option (which hides the dock when a window is below it, and shows it again when there's only "empty desktop" below it) is ENABLED, the option "panel mode: extend up to the screen borders" is DISABLED, and the "maximum size of the dock" is BELOW 100% (90% is fine). In an empty desktop (this is, without any window) the dock should be visible, with some free space in each side (top and bottom if the dock is vertical; left and right if it is horizontal) where the underlying desktop can be seen. Now, open any window and maximize it; the dock should hide, thus allowing the window to fill the whole screen. Close the window. The dock should appear again. Try to move a desktop icon (any icon; a folder, a file, the trash, the personal folder... any is right) into the free zone of any of the sides. If the patch works, it should NOT be possible to place the icon there; if the bug is present, then it will be possible to place the icon there. It must be also test if it is possible to put an icon in any place of the "free" desktop surface (this is: any zone that won't be obscured by a bar, dock or panel). [Where problems could occur] If there are problems, they can show in several ways: - the bugfix doesn't work, and thus it will still be possible to put icons in zones that should be forbidden - DING might fail and no icons would be visible - DING might wrongly interpret the data sent by other extensions, reducing too much the usable zone. [ Other info ] It seems easiest to take the new upstream release (47.0.5 -> 47.0.7) which includes this single code commit, plus translation updates.
2023-10-19 10:13:56 Jeremy Bícha gnome-shell-extension-desktop-icons-ng (Ubuntu Mantic): status Fix Committed In Progress
2023-10-27 00:33:00 Jeremy Bícha gnome-shell-extension-desktop-icons-ng (Ubuntu): status In Progress Fix Committed
2023-10-27 08:31:28 Launchpad Janitor gnome-shell-extension-desktop-icons-ng (Ubuntu): status Fix Committed Fix Released
2023-11-02 22:49:13 Mauricio Faria de Oliveira gnome-shell-extension-desktop-icons-ng (Ubuntu Mantic): status In Progress Incomplete
2023-11-02 22:49:17 Mauricio Faria de Oliveira bug added subscriber Mauricio Faria de Oliveira