gnome-shell logs errors when ejecting SD card

Bug #1951599 reported by Bin Li
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OEM Priority Project
Fix Released
High
Bin Li
gnome-shell-extension-ubuntu-dock (Ubuntu)
Fix Released
Medium
Marco Trevisan (Treviño)
Impish
Fix Released
Medium
Marco Trevisan (Treviño)

Bug Description

[ Impact ]

When I click eject SD card in Files(nautilus), I found the gnome-shell reported some crash logs.

[ Test case ]

- Mount a device
- Eject the device
- No errors should be shown and the device re-mountable

[ Regression Potential ]

Devices could be leaked if gc doesn't work as expected

---

Nov 19 22:43:57 binli-ThinkPad-X1-Extreme-Gen-3 gnome-shell[2357]: Object .Gjs_components_autorunManager_AutorunSource (0x55a9d8e846e0), has been already deallocated — impossible to emit any signal on it. This might be caused by the object having been destroyed from C code using something such as destroy(), dispose(), or remove() vfuncs.
Nov 19 22:43:57 binli-ThinkPad-X1-Extreme-Gen-3 gnome-shell[2357]: Object Gio.Settings (0x55a9db521970), has been already deallocated — impossible to access it. This might be caused by the object having been destroyed from C code using something such as destroy(), dispose(), or remove() vfuncs.
Nov 19 22:43:57 binli-ThinkPad-X1-Extreme-Gen-3 gnome-shell[2357]: == Stack trace for context 0x55a9d8a00120 ==
Nov 19 22:43:57 binli-ThinkPad-X1-Extreme-Gen-3 gnome-shell[2357]: #0 7ffc0b63cc20 b resource:///org/gnome/shell/ui/messageTray.js:785 (bc6f58577e0 @ 149)
Nov 19 22:43:57 binli-ThinkPad-X1-Extreme-Gen-3 gnome-shell[2357]: #1 55a9d8f150b0 i resource:///org/gnome/shell/ui/components/autorunManager.js:270 (1ec3f0bf4060 @ 69)
Nov 19 22:43:57 binli-ThinkPad-X1-Extreme-Gen-3 gnome-shell[2357]: #2 55a9d8f15018 i resource:///org/gnome/shell/ui/components/autorunManager.js:176 (1ec3f0bf4290 @ 25)
Nov 19 22:43:57 binli-ThinkPad-X1-Extreme-Gen-3 gnome-shell[2357]: #3 7ffc0b63d8c0 b self-hosted:850 (1ec3f0b2a650 @ 454)

Revision history for this message
Bin Li (binli) wrote :
Bin Li (binli)
tags: added: oem-priority originate-from-1947095 sutton
Changed in oem-priority:
assignee: nobody → Bin Li (binli)
importance: Undecided → High
status: New → In Progress
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

That doesn't seem to be a crash, just a recurring error with a stack trace.

summary: - gnome-shell will crash when eject SDCard
+ gnome-shell logs errors when ejecting SD card
description: updated
Revision history for this message
Daniel van Vugt (vanvugt) wrote :
Revision history for this message
Bin Li (binli) wrote :

@daniel,

Thanks for your feedback, but it didn't work for this issue.

I doubt it's related nautilus, when I click the eject icon in nautilus to umount the sdcard, the item of sdcard is still there, as "4.0 GB Volume", and the sdcard was removed successfuly from kernel's log.
So if click the eject icon again, it will show an error "Unable to eject 4.0 GB Volume", "Error ejecting /dev/mmcblk0: Command-line 'eject /dev/mmcblk0' exited with non-zero..".

Revision history for this message
Bin Li (binli) wrote (last edit ):

@daniel,

 Oh, I checked the log, found the error messages in description was gone, so the patch fixed the error messages, although it didn't fix the eject issue in nautilus.

https://github.com/micheleg/dash-to-dock/commit/d8dbbd8f776ec64d65f9938c2b597104c09ca86f

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

OK so the first issue covered by the Bug Description is fixed by the above commit. We should make this bug about that only.

The second issue you didn't mention until comment #4 so that should probably be moved to a new bug.

affects: gnome-shell (Ubuntu) → gnome-shell-extension-ubuntu-dock (Ubuntu)
Changed in gnome-shell-extension-dashtodock (Ubuntu):
status: New → Fix Committed
tags: added: fixed-in-72 fixed-upstream
Changed in gnome-shell-extension-dashtodock (Ubuntu):
importance: Undecided → Medium
Changed in gnome-shell-extension-ubuntu-dock (Ubuntu):
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
Bin Li (binli) wrote :

@daniel,

 Agree with it, and could we SRU this fix into gnome-shell-extension-ubuntu-dock 68ubuntu1 in focal? Thanks!

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Ubuntu-dock is problematic in that only Marco has commit access so usually we're waiting for him on that. Otherwise if we distro-patch then it's out of sync with git.

Also I feel like the above fix should have resolved other bugs in Launchpad but can't find any linked.

Bin Li (binli)
Changed in oem-priority:
status: In Progress → Triaged
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (5.7 KiB)

This bug was fixed in the package gnome-shell-extension-ubuntu-dock - 72~ubuntu1

---------------
gnome-shell-extension-ubuntu-dock (72~ubuntu1) jammy; urgency=medium

  [ Marco Trevisan (Treviño) ]
  * Revert "extension: Disable starting in the overview"
  * locations: Do not manually dispose objects (LP: #1949352, LP: #1951599)
  * po/es.po: Remove duplicated entry for Quit translation
  * docking: Delay dash animation callback at actual completion
  * utils: Fix variable in error template string
  * appIcons: In case we have no window to activate, let's just present it
  * docking: Do not try to re-add a Meta.Later if one is already queued
  * docking: Optionally disable animation to overview on startup
  * dash: Track hover on separator item so that it can contribute to scrolling
  * dash: Remove the scroll view visibility idle if triggering actor is
    destroyed
  * docking: Handle monitoring of discrete GPU not to leak signals
  * appIcons: Random cleanups to use more relevant variable names
  * appIcons: Compare workspaces instead of their indexes
  * appIcons: Ensure we only consider as urgent the ones respecting our rules
  * appIcons: Use new-window action only when requested, avoiding duplication
  * appIcons: Fixed logic on handling preview click actions (LP: #1947445)
  * stylesheet: Use some better naming for start marging value
  * stylesheet: Use scss generation for overview-icon background
  * stylesheet: Set the dash-separator color in both horizontal and vertical
    mode
  * windowPreview: Try generating previews clones on meta later only if have
    valid size (LP: 1949572)
  * utils: Remove handlers in reversed order
  * Dash: Update appIcon geometry on parent geometry changes
  * docking: Reduce the space used by the window picker / app grid
  * cleanup: Use cached settings values instead of doing C calls
  * locations: Use shell domain to translate reused strings
  * locations: Use native GIcon as location Apps-icons (LP: #1874578)
  * locations: Use native Gio.FileMonitor rate limit instead of a custom idle
  * locations: Fix typo on FileManager app (un)wrapping functions
  * locations: Fix handling of location apps on isolated workspaces mode
  * locations: Also destroy all removable devices on Removables manager
    destruction
  * locations: Only emit changed signal if a monitored device has been removed
  * locations: Only update Trash icon on changes
  * locations: Remove unmounted locations by value
  * locations: Use native AppInfo's and Shell mount operations
  * metadata: Add support for gnome-shell 42
  * fileManager1API: Cleanup the code to get windows from location path
  * fileManager1API: Keep windows paths cached so we can monitor changes
  * utils: Add support for (un)blocking signals handlers
  * locations: Smart managing wrapped windows backed applications signal
    connections
  * locations: Use proxy properties to expose private items to public object
  * locations: Chain up to parent destroy() function if any
  * locations: Manage sources as part of DtdData
  * locations: Manage windows changes in base class
  * cleanup: Move shellAppCompare under Utils as it's a generic tool
  * locations: Keep...

Read more...

Changed in gnome-shell-extension-ubuntu-dock (Ubuntu):
status: Triaged → Fix Released
Changed in gnome-shell-extension-dashtodock (Ubuntu Impish):
importance: Undecided → Medium
status: New → Fix Committed
Changed in gnome-shell-extension-ubuntu-dock (Ubuntu Impish):
importance: Undecided → Medium
description: updated
no longer affects: gnome-shell-extension-dashtodock (Ubuntu Impish)
Changed in gnome-shell-extension-ubuntu-dock (Ubuntu Impish):
status: New → In Progress
Changed in gnome-shell-extension-ubuntu-dock (Ubuntu):
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
Changed in gnome-shell-extension-ubuntu-dock (Ubuntu Impish):
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Bin, or anyone else affected,

Accepted gnome-shell-extension-ubuntu-dock into impish-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-shell-extension-ubuntu-dock/70~ubuntu3.21.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-impish to verification-done-impish. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-impish. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in gnome-shell-extension-ubuntu-dock (Ubuntu Impish):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-impish
Revision history for this message
Bin Li (binli) wrote :

On impish, I tried the new version of gnome-shell-extenstion-ubuntu-dock, I couldn't find this recurring error any more, this issue is fixed on impish.

Upgrade: gnome-shell-extension-ubuntu-dock:amd64 (70~ubuntu3, 70~ubuntu3.21.10.1)

tags: added: verification-done-impish
removed: verification-needed-impish
tags: added: verification-done
removed: verification-needed
Revision history for this message
Chris Halse Rogers (raof) wrote : Update Released

The verification of the Stable Release Update for gnome-shell-extension-ubuntu-dock has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-shell-extension-ubuntu-dock - 70~ubuntu3.21.10.1

---------------
gnome-shell-extension-ubuntu-dock (70~ubuntu3.21.10.1) impish; urgency=medium

  [ Marco Trevisan (Treviño) ]
  * locations: Do not manually dispose objects (LP: #1949352, #1951599)
  * windowPreview: Try generating previews clones on meta later only if have valid size
    (LP: #1949572)
  * locations: Use native GIcon as location Apps-icons (LP: #1874578)
  * debian: Update branch info for impish

  [ nename0 ]
  * Cleanup nautilus listeners (LP: #1949352)

  [ Pepijn Bogaard ]
  * appIcons: Fixed logic on handling preview click actions (LP: #1947445)

 -- Marco Trevisan (Treviño) <email address hidden> Tue, 25 Jan 2022 01:08:43 +0100

Changed in gnome-shell-extension-ubuntu-dock (Ubuntu Impish):
status: Fix Committed → Fix Released
Bin Li (binli)
Changed in oem-priority:
status: Triaged → Fix Released
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

dashtodock is no longer in the Ubuntu archive.

Changed in gnome-shell-extension-dashtodock (Ubuntu):
status: Fix Committed → Won't Fix
no longer affects: gnome-shell-extension-dashtodock (Ubuntu)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.