Ubuntu
googletest package

googletest 1.8.0-2 (on zesty) breaks existing builds [add_library cannot create target "gmock" ...]

Bug #1644062 reported by Michi Henning on 2016-11-23

This bug affects 5 people

	Status	Importance	Assigned to	Milestone
Mir	Fix Released	Critical	Chris Halse Rogers	Mir 0.26.0
0.25	Fix Released	Critical	Chris Halse Rogers	Mir 0.25.0
cmake-extras (Ubuntu)	Fix Released	Critical	Michi Henning
content-hub (Ubuntu)	Fix Released	Critical	Ken VanDine
googletest (Ubuntu)	Won't Fix	Critical	Unassigned
mir (Ubuntu)	Fix Released	Critical	Chris Halse Rogers
unity (Ubuntu)	Fix Released	Critical	Marco Trevisan (Treviño)

Bug Description

After upgrading to 1.8.0-2 (from 1.7.0-4), our previously-working builds break:

CMake Error at /usr/src/googletest/googletest/cmake/internal_utils.cmake:149 (add_library):
   add_library cannot create target "gmock" because another target with the
   same name already exists. The existing target is a static library created
   in source directory "/usr/src/googletest/googlemock". See documentation
   for policy CMP0002 for more details.
Call Stack (most recent call first):
   /usr/src/googletest/googletest/cmake/internal_utils.cmake:172 (cxx_library_with_type)
   /usr/src/gmock/CMakeLists.txt:84 (cxx_library)

CMake Error at /usr/src/googletest/googletest/cmake/internal_utils.cmake:149 (add_library):
   add_library cannot create target "gmock_main" because another target with
   the same name already exists. The existing target is a static library
   created in source directory "/usr/src/googletest/googlemock". See
   documentation for policy CMP0002 for more details.
Call Stack (most recent call first):
   /usr/src/googletest/googletest/cmake/internal_utils.cmake:172 (cxx_library_with_type)
   /usr/src/gmock/CMakeLists.txt:89 (cxx_library)

CMake Error at /usr/src/gmock/CMakeLists.txt:106 (install):
install TARGETS given target "gmock" which does not exist in this
directory.

The CMakeLists.txt in our project that triggers this error does this:

set(old_cxx_flags ${CMAKE_CXX_FLAGS})
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -g -Wno-old-style-cast -Wno-missing-field-initializers")
find_package(GMock)
set(CMAKE_CXX_FLAGS ${old_cxx_flags})

This used to work fine, but no breaks on zesty.

Related branches

lp://qastaging/~michihenning/cmake-extras/gtest-fixes

Merged into lp://qastaging/cmake-extras at revision 44

James Henstridge: Approve on 2016-11-23

lp://qastaging/~mir-team/mir/gmock-1.8-support-part-1

Merged into lp://qastaging/mir at revision 3849

Chris Halse Rogers: Approve on 2016-11-28

Mir CI Bot: Approve (continuous-integration) on 2016-11-25

lp://qastaging/~raof/mir/fix-googletest-zesty-build

Merged into lp://qastaging/mir at revision 3845

Daniel van Vugt: Approve on 2016-11-25

Mir CI Bot: Approve (continuous-integration) on 2016-11-24

lp://qastaging/~ken-vandine/content-hub/gtest_1_8

Merged into lp://qastaging/content-hub at revision 308

Arthur Mello (community): Approve on 2016-11-29

system-apps-ci-bot: Needs Fixing (continuous-integration) on 2016-11-28

lp://qastaging/~3v1n0/unity/gtest-1.8-fixes

Merged into lp://qastaging/unity at revision 4210

Andrea Azzarone (community): Approve on 2016-12-01

Diff: 3283 lines (+442/-450)

68 files modified

CMakeLists.txt (+1/-49)
UnityCore/CMakeLists.txt (+2/-1)
tests/CMakeLists.txt (+34/-4)
tests/autopilot/unity/tests/test_dash.py (+4/-4)
tests/test-gestures/CMakeLists.txt (+2/-2)
tests/test-gestures/test_gesture_broker.cpp (+3/-3)
tests/test_action_handle.cpp (+12/-12)
tests/test_animation_utils.cpp (+4/-4)
tests/test_application_launcher_icon.cpp (+4/-4)
tests/test_bamf_application.cpp (+3/-3)
tests/test_categories.cpp (+3/-3)
tests/test_connection_manager.cpp (+10/-10)
tests/test_dashview.cpp (+1/-1)
tests/test_dashview_impl.cpp (+3/-3)
tests/test_dbus_indicators.cpp (+4/-4)
tests/test_decorations_input_mixer.cpp (+7/-7)
tests/test_decorations_widgets.cpp (+5/-5)
tests/test_delta_tracker.cpp (+6/-6)
tests/test_desktop_launcher_icon.cpp (+1/-1)
tests/test_device_launcher_section.cpp (+1/-1)
tests/test_favorite_store_gsettings.cpp (+5/-5)
tests/test_favorite_store_private.cpp (+4/-4)
tests/test_file_manager_launcher_icon.cpp (+3/-3)
tests/test_filter_widgets.cpp (+1/-1)
tests/test_glib_dbus_object.cpp (+2/-2)
tests/test_glib_dbus_server.cpp (+17/-17)
tests/test_glib_object.cpp (+10/-10)
tests/test_glib_signals.cpp (+3/-3)
tests/test_glib_source.cpp (+45/-45)
tests/test_glib_variant.cpp (+9/-9)
tests/test_gnome_session_manager.cpp (+1/-1)
tests/test_grabhandle.cpp (+2/-2)
tests/test_gsettings_scopes.cpp (+32/-32)
tests/test_hud_button.cpp (+2/-2)
tests/test_hud_private.cpp (+6/-6)
tests/test_hud_view.cpp (+1/-1)
tests/test_indicator.cpp (+6/-6)
tests/test_indicator_appmenu.cpp (+3/-3)
tests/test_indicator_entry.cpp (+3/-3)
tests/test_indicators.cpp (+11/-11)
tests/test_introspection_data.cpp (+40/-40)
tests/test_keyboard_util.cpp (+8/-0)
tests/test_launcher_controller.cpp (+11/-10)
tests/test_launcher_model.cpp (+6/-6)
tests/test_layout_system.cpp (+9/-9)
tests/test_lockscreen_controller.cpp (+4/-4)
tests/test_panel_controller.cpp (+3/-3)
tests/test_panel_indicator_entry_dropdown_view.cpp (+10/-10)
tests/test_pointer_barrier.cpp (+2/-2)
tests/test_previews.cpp (+2/-2)
tests/test_previews_application.cpp (+1/-1)
tests/test_previews_generic.cpp (+1/-1)
tests/test_previews_movie.cpp (+1/-1)
tests/test_previews_music.cpp (+1/-1)
tests/test_previews_social.cpp (+1/-1)
tests/test_quicklist_view.cpp (+1/-1)
tests/test_results.cpp (+10/-10)
tests/test_scope.cpp (+6/-6)
tests/test_scope_view.cpp (+12/-12)
tests/test_session_view.cpp (+4/-4)
tests/test_shortcut_model.cpp (+4/-4)
tests/test_shortcut_view.cpp (+3/-3)
tests/test_switcher_controller_slow.cpp (+5/-5)
tests/test_texture_cache.cpp (+2/-2)
tests/test_trash_launcher_icon.cpp (+6/-6)
tests/test_ubus.cpp (+6/-6)
tests/test_unity_window_style.cpp (+3/-3)
tests/test_volume_launcher_icon.cpp (+4/-4)

lp://qastaging/~ci-train-bot/mir/mir-ubuntu-zesty-2180 (Merged)

lp://qastaging/~ci-train-bot/mir/mir-ubuntu-zesty-2369 (Merged)

lp://qastaging/~ci-train-bot/mir/mir-ubuntu-xenial-2736

lp://qastaging/~ci-train-bot/mir/mir-ubuntu-yakkety-2783.1

lp://qastaging/~ci-train-bot/mir/mir-ubuntu-yakkety-2783

lp://qastaging/~unity-team/unity/x-sru5

Merged into lp://qastaging/unity/7.4 at revision 4115

Andrea Azzarone (community): Approve on 2017-07-27

Diff: 12627 lines (+4713/-1916)

190 files modified

AUTHORS (+2/-0)
CMakeLists.txt (+9/-98)
ChangeLog (+663/-0)
UnityCore/CMakeLists.txt (+2/-1)
UnityCore/DBusIndicators.cpp (+1/-1)
UnityCore/GLibDBusProxy.cpp (+12/-8)
UnityCore/GLibDBusProxy.h (+2/-2)
UnityCore/GLibSignal-inl.h (+10/-2)
UnityCore/GLibSignal.cpp (+75/-29)
UnityCore/GLibSignal.h (+16/-11)
UnityCore/GnomeSessionManager.cpp (+127/-39)
UnityCore/GnomeSessionManager.h (+1/-0)
UnityCore/GnomeSessionManagerImpl.h (+4/-0)
UnityCore/SessionManager.h (+1/-0)
UnityCore/Variant.cpp (+30/-0)
UnityCore/Variant.h (+1/-0)
config.h.cmake (+3/-2)
dash/ResultRendererTile.cpp (+1/-1)
data/CMakeLists.txt (+37/-1)
data/com.canonical.Unity.gschema.xml (+5/-0)
data/unity7.conf.in (+2/-19)
debian/changelog (+78/-0)
debian/control (+2/-1)
debian/rules (+3/-0)
debian/unity.install (+3/-0)
debian/unity.migrations (+1/-0)
decorations/DecoratedWindow.cpp (+2/-9)
decorations/DecorationsForceQuitDialog.cpp (+4/-2)
decorations/DecorationsMenuLayout.cpp (+35/-37)
decorations/DecorationsMenuLayout.h (+3/-2)
decorations/DecorationsPriv.h (+0/-1)
decorations/DecorationsWindowButton.cpp (+2/-1)
launcher/EdgeBarrierController.cpp (+32/-117)
launcher/EdgeBarrierControllerPrivate.h (+1/-6)
launcher/FileManagerLauncherIcon.cpp (+30/-0)
launcher/FileManagerLauncherIcon.h (+8/-0)
launcher/Launcher.cpp (+36/-32)
launcher/Launcher.h (+1/-0)
launcher/LauncherOptions.cpp (+22/-22)
launcher/StorageLauncherIcon.cpp (+7/-12)
launcher/Tooltip.cpp (+6/-6)
launcher/Tooltip.h (+1/-2)
lockscreen/BackgroundSettings.cpp (+18/-13)
lockscreen/KylinLockScreenShield.cpp (+1/-19)
lockscreen/KylinLockScreenShield.h (+0/-3)
lockscreen/KylinUserPromptView.cpp (+15/-15)
lockscreen/KylinUserPromptView.h (+2/-3)
lockscreen/LockScreenAbstractPromptView.h (+5/-3)
lockscreen/LockScreenBaseShield.cpp (+14/-7)
lockscreen/LockScreenBaseShield.h (+4/-6)
lockscreen/LockScreenController.cpp (+91/-38)
lockscreen/LockScreenController.h (+12/-2)
lockscreen/LockScreenPanel.cpp (+26/-57)
lockscreen/LockScreenPanel.h (+5/-9)
lockscreen/LockScreenPromptFactory.cpp (+4/-3)
lockscreen/LockScreenPromptFactory.h (+3/-1)
lockscreen/LockScreenShield.cpp (+8/-17)
lockscreen/LockScreenShield.h (+4/-3)
lockscreen/LockScreenShieldFactory.cpp (+2/-2)
lockscreen/LockScreenShieldFactory.h (+3/-3)
lockscreen/SuspendInhibitorManager.cpp (+2/-0)
lockscreen/SuspendInhibitorManager.h (+1/-0)
lockscreen/UserAuthenticator.h (+2/-0)
lockscreen/UserAuthenticatorPam.cpp (+41/-33)
lockscreen/UserAuthenticatorPam.h (+9/-8)
lockscreen/UserPromptView.cpp (+51/-15)
lockscreen/UserPromptView.h (+7/-4)
panel/PanelController.cpp (+1/-2)
panel/PanelIndicatorEntryView.cpp (+10/-0)
panel/PanelMenuView.cpp (+1/-7)
panel/PanelMenuView.h (+0/-2)
panel/PanelView.cpp (+14/-121)
panel/PanelView.h (+4/-12)
plugins/unityshell/src/unityshell.cpp (+117/-95)
plugins/unityshell/src/unityshell.h (+9/-2)
plugins/unityshell/unityshell.xml.in (+0/-6)
services/CMakeLists.txt (+1/-1)
services/panel-main.c (+36/-0)
services/panel-service.c (+86/-10)
services/panel-service.h (+2/-0)
services/unity-panel-service-lockscreen.conf.in (+3/-1)
services/unity-panel-service-lockscreen.service.in (+7/-0)
services/unity-panel-service.conf.in (+3/-1)
shutdown/StandaloneSession.cpp (+1/-0)
tests/CMakeLists.txt (+473/-292)
tests/MockCategories.h (+24/-14)
tests/MockResults.h (+32/-7)
tests/autopilot/unity/tests/test_dash.py (+4/-4)
tests/data/external.gschema.xml (+7/-1)
tests/test-gestures/CMakeLists.txt (+5/-3)
tests/test-gestures/test_gesture_broker.cpp (+3/-3)
tests/test_action_handle.cpp (+12/-12)
tests/test_animation_utils.cpp (+4/-4)
tests/test_application_launcher_icon.cpp (+4/-4)
tests/test_bamf_application.cpp (+28/-3)
tests/test_categories.cpp (+3/-3)
tests/test_connection_manager.cpp (+10/-10)
tests/test_dashview.cpp (+1/-1)
tests/test_dashview_impl.cpp (+3/-3)
tests/test_dbus_indicators.cpp (+4/-4)
tests/test_decorations_input_mixer.cpp (+7/-7)
tests/test_decorations_widgets.cpp (+5/-5)
tests/test_delta_tracker.cpp (+6/-6)
tests/test_desktop_launcher_icon.cpp (+1/-1)
tests/test_device_launcher_section.cpp (+1/-1)
tests/test_edge_barrier_controller.cpp (+2/-0)
tests/test_favorite_store_gsettings.cpp (+5/-5)
tests/test_favorite_store_private.cpp (+4/-4)
tests/test_file_manager_launcher_icon.cpp (+202/-0)
tests/test_filter_widgets.cpp (+1/-1)
tests/test_glib_dbus_object.cpp (+2/-2)
tests/test_glib_dbus_server.cpp (+17/-17)
tests/test_glib_object.cpp (+10/-10)
tests/test_glib_signals.cpp (+201/-63)
tests/test_glib_source.cpp (+45/-45)
tests/test_glib_variant.cpp (+9/-9)
tests/test_gnome_session_manager.cpp (+10/-3)
tests/test_grabhandle.cpp (+2/-2)
tests/test_gsettings_scopes.cpp (+32/-32)
tests/test_hud_button.cpp (+2/-2)
tests/test_hud_private.cpp (+6/-6)
tests/test_hud_view.cpp (+1/-1)
tests/test_icon_loader.cpp (+32/-32)
tests/test_indicator.cpp (+6/-6)
tests/test_indicator_appmenu.cpp (+3/-3)
tests/test_indicator_entry.cpp (+3/-3)
tests/test_indicators.cpp (+11/-11)
tests/test_introspection_data.cpp (+40/-40)
tests/test_keyboard_util.cpp (+8/-0)
tests/test_launcher_controller.cpp (+14/-11)
tests/test_launcher_model.cpp (+6/-6)
tests/test_layout_system.cpp (+9/-9)
tests/test_lockscreen_controller.cpp (+9/-7)
tests/test_mock_session_manager.h (+1/-0)
tests/test_panel_controller.cpp (+5/-3)
tests/test_panel_indicator_entry_dropdown_view.cpp (+10/-10)
tests/test_panel_view.cpp (+2/-0)
tests/test_pointer_barrier.cpp (+2/-2)
tests/test_previews.cpp (+2/-2)
tests/test_previews_application.cpp (+2/-2)
tests/test_previews_generic.cpp (+1/-1)
tests/test_previews_movie.cpp (+1/-1)
tests/test_previews_music.cpp (+1/-1)
tests/test_previews_music_payment.cpp (+1/-1)
tests/test_previews_payment.cpp (+1/-0)
tests/test_previews_social.cpp (+1/-1)
tests/test_quicklist_view.cpp (+1/-1)
tests/test_results.cpp (+10/-10)
tests/test_scope.cpp (+6/-6)
tests/test_scope_view.cpp (+12/-12)
tests/test_session_view.cpp (+4/-4)
tests/test_shortcut_model.cpp (+4/-4)
tests/test_shortcut_view.cpp (+3/-3)
tests/test_showdesktop_handler.cpp (+13/-5)
tests/test_switcher_controller_slow.cpp (+5/-5)
tests/test_tabiterator.cpp (+0/-6)
tests/test_texture_cache.cpp (+2/-2)
tests/test_thumbnail_generator.cpp (+5/-5)
tests/test_trash_launcher_icon.cpp (+6/-6)
tests/test_ubus.cpp (+6/-6)
tests/test_unity_window_style.cpp (+3/-3)
tests/test_volume_launcher_icon.cpp (+4/-4)
tools/CMakeLists.txt (+13/-3)
tools/compiz-profile-selector.in (+49/-0)
tools/compiz_config_profile_setter.c (+228/-0)
tools/migration-scripts/06_unity_set_lowgfx_mode_settings_v1 (+95/-0)
tools/unity.cmake (+23/-7)
tools/upstart-prestart-check (+17/-0)
unity-shared/BGHash.cpp (+22/-59)
unity-shared/BGHash.h (+3/-4)
unity-shared/BackgroundEffectHelper.cpp (+3/-4)
unity-shared/CMakeLists.txt (+1/-0)
unity-shared/DashStyle.cpp (+2/-2)
unity-shared/GnomeFileManager.cpp (+4/-2)
unity-shared/InputMonitor.cpp (+423/-0)
unity-shared/InputMonitor.h (+67/-0)
unity-shared/MenuManager.cpp (+157/-1)
unity-shared/MenuManager.h (+4/-0)
unity-shared/SigcSlotHash.h (+70/-0)
unity-shared/StandaloneWindowManager.cpp (+3/-0)
unity-shared/StandaloneWindowManager.h (+1/-0)
unity-shared/ThumbnailGenerator.cpp (+1/-1)
unity-shared/UScreen.cpp (+9/-0)
unity-shared/UScreen.h (+2/-0)
unity-shared/UnitySettings.cpp (+147/-14)
unity-shared/UnitySettings.h (+1/-1)
unity-shared/UpstartWrapper.cpp (+11/-6)
unity-shared/WindowManager.h (+1/-0)
unity-shared/XWindowManager.cpp (+6/-0)
unity-shared/XWindowManager.h (+1/-0)

~rbalint/aethercast:master

Merged into aethercast:master at revision e6065a32af38abad0858bc1376c3f85dc2f767a2

Balint Reczey: Approve on 2017-03-23

Simon Fels: Approve on 2017-03-22

Daniel van Vugt (vanvugt) on 2016-11-23

Changed in googletest (Ubuntu):
importance:	Undecided → Critical

Revision history for this message

Launchpad Janitor (janitor) wrote on 2016-11-23:

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in googletest (Ubuntu):
status:	New → Confirmed

Daniel van Vugt (vanvugt) on 2016-11-23

summary:

- 1.8.0-2 breaks existing builds
+ googletest 1.8.0-2 (on zesty) breaks existing builds

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2016-11-23: Re: googletest 1.8.0-2 (on zesty) breaks existing builds

WORKAROUND:

1. Uninstall 'googletest' and friends.
2. Install the previous version:
https://launchpad.net/ubuntu/+archive/primary/+files/libgtest-dev_1.7.0-4ubuntu1_amd64.deb
https://launchpad.net/ubuntu/+archive/primary/+files/google-mock_1.7.0-18092013-2.1_amd64.deb

summary:

- googletest 1.8.0-2 (on zesty) breaks existing builds
+ googletest 1.8.0-2 (on zesty) breaks existing builds [add_library cannot
+ create target "gmock" ...]

Revision history for this message

Michi Henning (michihenning) wrote on 2016-11-23:

Here is a cmake-extras change that deals with the broken googletest:

https://code.launchpad.net/~michihenning/cmake-extras/gtest-fixes/+merge/311565

Daniel van Vugt (vanvugt) on 2016-11-23

Changed in cmake-extras (Ubuntu):
assignee:	nobody → Michi Henning (michihenning)
status:	New → In Progress

Michi Henning (michihenning) on 2016-11-23

Changed in cmake-extras (Ubuntu):
status:	In Progress → Fix Committed
status:	Fix Committed → In Progress

Revision history for this message

Michi Henning (michihenning) wrote on 2016-11-23:

Fix is in silo 2225.

Revision history for this message

Launchpad Janitor (janitor) wrote on 2016-11-23:

This bug was fixed in the package cmake-extras - 0.7+17.04.20161123.5-0ubuntu1

---------------
cmake-extras (0.7+17.04.20161123.5-0ubuntu1) zesty; urgency=medium

* Fixes for gtest 1.8.0. (LP: #1644062) (LP: #1644062)

-- Michi Henning <email address hidden> Wed, 23 Nov 2016 06:25:33 +0000

Changed in cmake-extras (Ubuntu):
status:	In Progress → Fix Released

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2016-11-23:

Hmm, looks like Mir won't benefit from that fix (doesn't use cmake-extras). Another fix will be required still.

Revision history for this message

Michi Henning (michihenning) wrote on 2016-11-23:

The fix for cmake-extras allows the builds to complete, but it still doesn't work. The problem now is that gtest install a pile of stuff in the install directory and, when it comes to creating the packages, the debian installation fails because of the --fail-missing; there are loads of files in the install dir now that are not picked up by the .install files. Sigh...

Changed in cmake-extras (Ubuntu):
status:	Fix Released → In Progress

Revision history for this message

Michi Henning (michihenning) wrote on 2016-11-23:

If you figure out how to fix this for Mir, I'd like know what you did. The other avenue I tried was ExternalProject_Add, but I didn't get very far with that either because it seems that the gtest cmake files don't honour the INSTALL_DIR variable.

Daniel van Vugt (vanvugt) on 2016-11-24

Changed in mir:
importance:	Undecided → Critical
status:	New → Confirmed
milestone:	none → 0.26.0
Changed in cmake-extras (Ubuntu):
importance:	Undecided → Critical

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2016-11-24:

Also reported upstream:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=844843

Daniel van Vugt (vanvugt) on 2016-11-25

Changed in mir:
assignee:	nobody → Chris Halse Rogers (raof)
status:	Confirmed → In Progress

Revision history for this message

Mir CI Bot (mir-ci-bot) wrote on 2016-11-25:

#10

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.26.0

Changed in mir:
status:	In Progress → Fix Committed

Michi Henning (michihenning) on 2016-11-28

Changed in cmake-extras (Ubuntu):
status:	In Progress → Fix Released

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2016-11-29:

#12

Probably "Won't Fix" the googletest package itself, since this is its original form from Debian and we can work around it.

Changed in content-hub (Ubuntu):
assignee:	nobody → Ken VanDine (ken-vandine)
importance:	Undecided → Critical
status:	New → In Progress
Changed in googletest (Ubuntu):
status:	Confirmed → Won't Fix

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2016-11-29:

#13

Fix committed to lp:mir/0.25 at revision 3819, scheduled for release in Mir 0.25.1 (or 0.25.0 ... not sure which one yet).

Changed in mir (Ubuntu):
importance:	Undecided → Critical
status:	New → Triaged

Daniel van Vugt (vanvugt) on 2016-11-30

Changed in unity (Ubuntu):
assignee:	nobody → Marco Trevisan (Treviño) (3v1n0)
status:	New → In Progress

Marco Trevisan (Treviño) (3v1n0) on 2016-11-30

Changed in unity (Ubuntu):
importance:	Undecided → Critical

Revision history for this message

Launchpad Janitor (janitor) wrote on 2016-12-01:

#14

This bug was fixed in the package content-hub - 0.2+17.04.20161128-0ubuntu1

---------------
content-hub (0.2+17.04.20161128-0ubuntu1) zesty; urgency=medium

  * Fix build failure on zesty due to googletest 1.8. Also refactored
    tests/acceptance-tests/CMakeLists.txt to make adding tests less
    cumbersome. (LP: #1644062)

-- Ken VanDine <email address hidden> Mon, 28 Nov 2016 17:39:58 +0000

Changed in content-hub (Ubuntu):
status:	In Progress → Fix Released

Revision history for this message

Launchpad Janitor (janitor) wrote on 2016-12-01:

#15

This bug was fixed in the package unity - 7.5.0+17.04.20161130-0ubuntu1

---------------
unity (7.5.0+17.04.20161130-0ubuntu1) zesty; urgency=medium

  [ Kai-Heng Feng ]
  * UnitySettings: If scale-factor is not set, find and set right scale
    for HiDPI displays.

  [ Marco Trevisan (Treviño) ]
  * CMakeLists.txt: add support to compile with GTest 1.8 (LP: #1644062)
  * UnityScreen: toggle gestures recognition on lock (LP: #1645507)

-- Marco Trevisan (Treviño) <mail@3v1n0.net> Wed, 30 Nov 2016 11:06:58 +0000

Changed in unity (Ubuntu):
status:	In Progress → Fix Released

Daniel van Vugt (vanvugt) on 2016-12-02

Changed in mir (Ubuntu):
assignee:	nobody → Chris Halse Rogers (raof)
status:	Triaged → In Progress

Revision history for this message

Launchpad Janitor (janitor) wrote on 2016-12-15:

#16

Download full text (5.7 KiB)

This bug was fixed in the package mir - 0.25.0+17.04.20161203-0ubuntu1

---------------
mir (0.25.0+17.04.20161203-0ubuntu1) zesty; urgency=medium

This bug was fixed in the package mir - 0.25.0+17.04.20161203-0ubuntu1

---------------
mir (0.25.0+17.04.20161203-0ubuntu1) zesty; urgency=medium

* New upstream release 0.25.0 (https://launchpad.net/mir/+milestone/0.25.0)
    - ABI summary:
      . mirclient ABI unchanged at 9
      . mirserver ABI bumped to 42
      . mircommon ABI bumped to 7
      . mirplatform ABI bumped to 14
      . mirprotobuf ABI unchanged at 3
      . mirplatformgraphics ABI bumped to 11
      . mirclientplatform ABI unchanged at 5
      . mirinputplatform ABI bumped to 6
      . mircore ABI added, at version 1
    - Enhancements:
      . Added pointer confinement support
      . Identify Raspberry Pi output types correctly
      . Added dead key and compose key support
      . Added gamma support for KMS hardware
      . Added yakkety and zesty gcc-6 support
      . Added surface passthrough support for fullscreen clients of nested
        servers
      . Introduced a new library `libmircore'
      . Began migrating from Protobuf to Cap'n Proto starting with events
      . Began support for VirtualBox (servers now start instead of crashing
        but full support for GL clients is still missing)
      . Began support for high precision frame timing, implemented for the
        KMS, Android and X11 backends so far
      . Added --display-report support for the X11 backend
      . Improved reliability of `mirvanity' latency test tool
      . Moved to using the CSS cursor naming scheme internally, although
        the old symbolic indentifiers remain unchanged and still work
      . Added refresh rate to MirSurfaceOutputEvent
      . Many improvements to automated test quality and coverage
      . Smoother desktop zoom using mir_proving_server (Super + two fingers)
    - Bugs fixed:
      . FTBFS On Zesty: invalid use of
        'struct native_handle' (LP: #1638774)
      . libmirclient-debug-extension-dev install debug/surface.h
        twice (LP: #1639153)
      . Mir crashes on virtual box drmModeCrtcSetGamma
        Function not implemented (LP: #1638220)
      . Flickering in mir_demo_client_multistream (LP: #1635273)
      . Camera apps (camera & vanity) never exit (LP: #1635010)
      . Clients cannot connect when MIR_SOCKET="" (LP: #1634508)
      . mirtest-dev packaging fails to sepcify boost depends (LP: #1633537)
      . cursor.h is unclear about mir_diagonal_resize_* (LP: #1626924)
      . Inconsistent underscores in cursor names (LP: #1632617)
      . [regression] Accidental libmircommon.so.6 break (LP: #1617865)
      . [regression] mir demo server fails to start with mx4 (LP: #1615703)
      . [regression] Trust prompt now shown when starting camera (LP: #1612256)
      . [regression] make abi-check fails to build (LP: #1626866)
      . Nested servers prevent overlays or fullscreen bypass (LP: #1262116)
      . Failed to get PRIME fd from gbm bo (LP: #1607812)
      . Mir-on-X is difficult to use on 1366x768 laptop (LP: #1590959)
      . Remove useless message 'Surface 0 DPI' in demos (LP: #1559831)
      . Mir fails to cross-build with newer sbuild (LP: #1628507)
      . Infinite loop in AbstractShell::focus_next_session (LP: #1625401)
      . Destroying a presentation chain doesn't trigger ownership
        notification to client (LP: #1626503)
      . Keyboard layout not applied on the shell (LP: #1626435)
      . Warning, No syntax specified for the proto file (LP: #1624971)
      . display-report=log reports vsync on non-existent output number
        (LP: #1621352)
      . libmirserver-dev missing uuid-dev depends (LP: #1617435)
      . debian/control missing epoxy (LP: #1617256)
      . Downstreams need to disable clang diagnostic "-Wreturn-type-clinkage"
        to build against public headers (LP: #1615587)
      . mirtest-dev: mock_display_configuration.h uses mg namespace without
        using it (LP: #1614983)
      . FTBFS using clang (LP: #1609612)
      . mesa-kms doesn't fall back to using software cursor if hardware
        cursor is unavailable (LP: #1610054)
      . StubGraphicsPlatform::create_display() leaves a dubious state
        (LP: #1611337)
      . Mir build/tests fail with gcc-6 and LTO (LP: #1610215)
      . Cross compiling on xenial fails (LP: #1609329)
      . Building with -DMIR_PLATFORM=anroid fails (LP: #1609916)
      . unity-system-compositor crashes on start-up with "Mir fatal error:
        Failed to schedule page flip" (LP: #1584894)
      . mir_connection_create_spec_for_tooltip doesn't meet requirements
        (LP: #1603922)
      . Updating surface size/location needs to update the pointer confinement
        (LP: #1604673)
      . ServerConfigurationOption is not ptest safe (LP: #1607351)
      . HWC's vsync_signal_on is never called when using HWC 1.0 (LP: #1613373)
      . mir_connection_create_spec_for_tooltip does not set aux_rect
        (LP: #1632335)
      . VMware virtual connector recognized by Mir as "unknown" (LP: #1248072)
      . Fix code to match the documentation of CoordinateTranslator - vis "It is
        acceptable ...[to] throw a std::runtime_error" (LP: #1641166)
      . Test timeout MesaDisplayConfigurationTests.* (LP: #1613352)
      . Tests fail when built against lp:mir (LP: #1621917)
      . CI failure MultiThreadedCompositor (LP: #1595940)
      . CI failure in DisplayConfiguration (LP: #1563210)
      . CI failure  NestedServer.given_client_set_display_configuration*
        (LP: #1617036)
      . CI failure on krillin in NestedServer.* testes (LP: #1628828)
      . CI failure: PosixRWMutex hangs (LP: #1633920)
      . googletest 1.8.0-2 (on zesty) breaks existing builds [add_library
        cannot create target "gmock" ...] (LP: #1644062)

-- Brandon Schaefer <brandon.schaefer@canonical.com>  Sat, 03 Dec 2016 12:42:33 +0000

Changed in mir (Ubuntu):
status:	In Progress → Fix Released

Daniel van Vugt (vanvugt) on 2017-02-02

Changed in mir:
status:	Fix Committed → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

Duplicates of this bug

Bug #1644065

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

debbugs #844843
[done serious sid stretch] Edit

Bug watches keep track of this bug in other bug trackers.

Ubuntugoogletest package

googletest 1.8.0-2 (on zesty) breaks existing builds [add_library cannot create target "gmock" ...]

Bug Description

Related branches

Duplicates of this bug

Other bug subscribers

Remote bug watches

Ubuntu
googletest package