Ubuntu
gost-crypto package

gost-crypto-dkms FTBS with linux 6.2 in jammy

Bug #2023639 reported by Andrea Righi on 2023-06-13

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	gost-crypto (Ubuntu)	New	Undecided	Unassigned
	Jammy	Fix Released	Undecided	Unassigned

Bug Description

[Impact]

gost-crypto-dkms fails to build with the new linux 6.2 in jammy:

/var/lib/dkms/gost-crypto/0.3.3/build/magma_generic.c:25:40: error: implicit declaration of function ‘crypto_tfm_ctx’ [-Werror=implicit-function-declaration]
25 | struct crypto_magma_ctx *ctx = crypto_tfm_ctx(tfm);
| ^~~~~~~~~~~~~~

[Test case]

$ sudo apt install gost-crypto-dkms

With the fix applied:

- hwe kernel 6.2:

Building for 6.2.0-25-generic
Building initial module for 6.2.0-25-generic
EFI variables are not supported on this system
/sys/firmware/efi/efivars not found, aborting.
Done.

gost28147_generic.ko:
Running module version sanity check.
- Original module
- No original module exists within this kernel
- Installation
- Installing to /lib/modules/6.2.0-25-generic/updates/dkms/
...

- release kernel 5.15:

Building for 5.15.0-77-generic
Building initial module for 5.15.0-77-generic
EFI variables are not supported on this system
/sys/firmware/efi/efivars not found, aborting.
Done.

gost28147_generic.ko:
Running module version sanity check.
- Original module
- No original module exists within this kernel
- Installation
- Installing to /lib/modules/5.15.0-77-generic/updates/dkms/
...

[Fix]

Backport the patch(es) from Lunar to properly support the new Linux 6.2 kernel ABI.

[Regression potential]

We may experience kernel regressions in systems using this module with the new kernel 6.2.

ProblemType: Bug
DistroRelease: Ubuntu 22.04
Package: gost-crypto-dkms 0.3.3-1ubuntu1
ProcVersionSignature: User Name 6.2.0-23.23~22.04.1-generic 6.2.12
Uname: Linux 6.2.0-23-generic x86_64
ApportVersion: 2.20.11-0ubuntu82.5
Architecture: amd64
CasperMD5CheckResult: unknown
Date: Tue Jun 13 09:20:29 2023
PackageArchitecture: all
SourcePackage: gost-crypto
UpgradeStatus: No upgrade log present (probably fresh install)

See original description

Tags:

Revision history for this message

Andrea Righi (arighi) wrote on 2023-06-13:

Dependencies.txt Edit (5.1 KiB, text/plain; charset="utf-8")
ProcCpuinfoMinimal.txt Edit (1.3 KiB, text/plain; charset="utf-8")
ProcEnviron.txt Edit (306 bytes, text/plain; charset="utf-8")

Revision history for this message

Andrea Righi (arighi) wrote on 2023-06-13:

gost-crypto-dkms-support-linux-6.2-jammy.debdiff Edit (2.4 KiB, text/plain)

debdiff to support linux 6.2 in jammy.

Ubuntu Foundations Team Bug Bot (crichton) on 2023-06-13

tags:

added: patch

Revision history for this message

Steve Langasek (vorlon) wrote on 2023-06-17: Please test proposed package

Hello Andrea, or anyone else affected,

Accepted gost-crypto into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gost-crypto/0.3.3-1ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in gost-crypto (Ubuntu Jammy):
status:	New → Fix Committed
tags:	added: verification-needed verification-needed-jammy

Andrea Righi (arighi) on 2023-07-06

description:	updated
tags:	added: verification-done-jammy removed: verification-needed verification-needed-jammy

Revision history for this message

Łukasz Zemczak (sil2100) wrote on 2023-07-10:

Hey Andrea! Can you always include the version number of the package that you are testing as part of the verification? Thanks.

Revision history for this message

Launchpad Janitor (janitor) wrote on 2023-07-10:

This bug was fixed in the package gost-crypto - 0.3.3-1ubuntu2

---------------
gost-crypto (0.3.3-1ubuntu2) jammy; urgency=medium

* Support Linux 6.2 (LP: #2023639):
- debian/patches/0001-crypto-add-crypto-algapi.h-include-when-Linux-6.1.patch

-- Andrea Righi <email address hidden> Tue, 13 Jun 2023 09:19:12 +0000

Changed in gost-crypto (Ubuntu Jammy):
status:	Fix Committed → Fix Released

Revision history for this message

Łukasz Zemczak (sil2100) wrote on 2023-07-10: Update Released

The verification of the Stable Release Update for gost-crypto has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.