GPSD time will jump back 1024 weeks at after week=2180 (23-October-2021)

That bug is fixed upstream and also in Debian.

On Tue, Aug 03, 2021 at 03:12:11PM -0000, Bernd Zeimetz wrote:
> That bug is fixed upstream and also in Debian.

Woot, thanks Bernd :)

This affects gpsd >= 3.20 so focal, hirsute and impish. Debian fixed it in 3.22-4 which is now in impish so I've marked that as fixed released.

Upstream patch:

https://gitlab.com/gpsd/gpsd/-/commit/7f30d88d04dc62b8bd6265ad1d09d72d220f97f6

Debian patch:

https://salsa.debian.org/debian-gps-team/pkg-gpsd/-/commit/2df40c7640dcbc5cbc48969bec44932623ef243b
https://salsa.debian.org/debian-gps-team/pkg-gpsd/-/commit/c6af361ae1ba59dc8d3ac8783faabcd5a059c092

I have uploaded packages for focal and hirsute to the security team PPA here:

https://launchpad.net/~ubuntu-security-proposed/+archive/ubuntu/ppa/+packages

I'd appreciate it if someone could test them. Thanks!

Hi Marc,

what you can check:

- do the regression tests run trough (failures are ignored at build time, as its fails sometims on the more "special" architectures, forgot to enable tests again for bullseye....). You are looking for scons check and the following output.

- if they are not happy, check if the reason is a changed date from 1999 to 2021 or something like that, similar to whats in the diff. quilt doesn't patch binary files, so I've disabled thoses test in Debian, but some are left in the patch.

You could also take the upstream source, apply your patch, merge the current regression test folder and run scons check there, although that might show some other bugs that were fixed since 3.20.

But in general, if scons check is still happy, chances are good that things are not badly broken :)

Hi,

I ran the regressions tests (scons check) from the security ppa package on:

 - Focal on s390x
 - Focal on ppc64el
 - Hirsute on s390x
 - Focal on amd64

and always got $?=0 with:

  timespec_str test succeeded
  timespec subtract test succeeded
  ns subtract test succeeded
  test_gpsd_gpstime_resolv test succeeded
  timespec tests succeeded

I saw no warning or errors about date changes in the test console logs. Let me know if you'd like more tests on specific platforms.

Thanks for the hints bzed.
Thanks for the tests paride.

I am currently working on enabling the test suite during build on focal and re-enabling the binary tests on focal and hirsute. I'll have updated packages in the PPA soon.

I have uploaded new packages to the PPA that enables the test suite and adds updated binary tests.
Thanks!

This bug was fixed in the package gpsd - 3.22-2ubuntu1.2

---------------
gpsd (3.22-2ubuntu1.2) hirsute-security; urgency=medium

  * SECURITY UPDATE: incorrect time jump (LP: #1938730)
    - debian/patches/fix_wrong_gps_rollover.patch: don't compute wrong GPS
      rollover after 2020-10-23.
    - debian/source/include-binaries: include some updated binary tests.
    - No CVE number

 -- Marc Deslauriers <email address hidden> Wed, 04 Aug 2021 11:08:50 -0400

This bug was fixed in the package gpsd - 3.20-8ubuntu0.4

---------------
gpsd (3.20-8ubuntu0.4) focal-security; urgency=medium

  * SECURITY UPDATE: incorrect time jump (LP: #1938730)
    - debian/patches/fix_wrong_gps_rollover.patch: don't compute wrong GPS
      rollover after 2020-10-23.
    - debian/control*: add python3-matplotlib, python3-gps, python3-gi,
      python3-cairo, gir1.2-gtk-3.0, python3-serial, python3-gi-cairo to
      Build-Depends so tests run.
    - debian/source/include-binaries: include some updated binary tests.
    - No CVE number

 -- Marc Deslauriers <email address hidden> Wed, 04 Aug 2021 11:34:28 -0400