perl syntax highlighting doesn't work for "-s"

Bug #631856 reported by Saddy
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
GtkSourceView
Invalid
Low
gtksourceview3 (Ubuntu)
Triaged
Low
Unassigned

Bug Description

Binary package hint: gedit

Code:

while ( (not -e "$omg") or (-s "$omg" < 71) ) {
  getstore($img, $omg);
}

Everything after (-s "$omg" < 71) gets highlighted even though the code is correct.

ProblemType: Bug
DistroRelease: Ubuntu 10.04
Package: gedit 2.30.3-0ubuntu0.1
ProcVersionSignature: Ubuntu 2.6.32-24.41-generic 2.6.32.15+drm33.5
Uname: Linux 2.6.32-24-generic x86_64
NonfreeKernelModules: nvidia
Architecture: amd64
Date: Mon Sep 6 21:08:38 2010
ProcEnviron:
 LANG=de_DE.UTF-8
 SHELL=/bin/bash
SourcePackage: gedit

Revision history for this message
Saddy (sadmail) wrote :
Revision history for this message
Pedro Villavicencio (pedro) wrote :

thanks for the report, could you take an screenshot of what you're seeing there? i'm getting exactly the same behavior with vim, emacs and gedit.

Changed in gedit (Ubuntu):
importance: Undecided → Low
status: New → Incomplete
Revision history for this message
Saddy (sadmail) wrote : Re: [Bug 631856] Re: perl syntax highlighting doesn't work for "-s"

Am 08.09.2010 18:50, schrieb Pedro Villavicencio:
> thanks for the report, could you take an screenshot of what you're
> seeing there? i'm getting exactly the same behavior with vim, emacs and
> gedit.
>
> ** Changed in: gedit (Ubuntu)
> Importance: Undecided => Low
>
> ** Changed in: gedit (Ubuntu)
> Status: New => Incomplete
>
>
Yup. E.g. the 'foreach' should be marked in red after the '-s' position.

Revision history for this message
Pedro Villavicencio (pedro) wrote :

not confirming, could you attach that file or a piece of code showing the failure? thanks.

Revision history for this message
McFly81 (christian-lange-81) wrote :

Confirming this on gedit 2.30.3 (Ubuntu 10.04 LTS). I wrote a few lines (only as example) from Saddys screenshot into a pl-file and gedit highlights it wrong. I will attach the the sourcefile.

Revision history for this message
Andreas Moog (ampelbein) wrote :

This is fixed in the development release, see attached screen.

Changed in gedit (Ubuntu):
status: Incomplete → Fix Released
status: Fix Released → Confirmed
Revision history for this message
Andreas Moog (ampelbein) wrote :

meant to say "not fixed", sorry for the spam.

Changed in gedit:
importance: Unknown → Low
status: Unknown → New
Changed in gedit (Ubuntu):
status: Confirmed → Triaged
Revision history for this message
Mysha (mysha) wrote :

Usually, a few countermeasures can reduce this to end of the line only.
E.g., from one of my scripts:

$grutte= -s( "$bank.fb"); #; #

But indeed, it's irritating to have the text mishighlighting. I've been looking at where we can customize the language highlighting, but I can't find it. So, as I read whole file contents a lot, and therefor need to get the file size, this is to me an ever present annoyance.

Revision history for this message
nmz (s-namitha-s) wrote :

Attached a proposed patch

affects: gedit (Ubuntu) → gtksourceview3 (Ubuntu)
affects: gedit → gtksourceview
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "diff_perl.txt" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

tags: added: patch
Changed in gtksourceview:
status: New → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.