HUD: Small memory leak when switching windows

Bug #972354 reported by Hernando Torque
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Application Menu Indicator
Fix Released
Low
Allison Karlitskaya
indicator-appmenu (Ubuntu)
Fix Released
Low
Allison Karlitskaya

Bug Description

Valgrind reports this leak every time I switch between windows:

==1830== 12,808 (+6,592) bytes in 688 (+348) blocks are definitely lost in loss record 3,245 of 3,324
==1830== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==1830== by 0x5847A38: g_malloc (gmem.c:159)
==1830== by 0x585C2AD: g_strdup (gstrfuncs.c:356)
==1830== by 0x55E31EF: g_value_set_string (gvaluetypes.c:1040)
==1830== by 0x63812B9: demarshal_basic (dbus-gvalue.c:619)
==1830== by 0x6382AD4: _dbus_gvalue_demarshal (dbus-gvalue.c:1254)
==1830== by 0x637C37C: dbus_g_proxy_end_call_internal (dbus-gproxy.c:2453)
==1830== by 0x637F69A: dbus_g_proxy_call (dbus-gproxy.c:2762)
==1830== by 0x50521A5: bamf_view_get_icon (in /usr/lib/x86_64-linux-gnu/libbamf3.so.0.0.0)
==1830== by 0x406BB0: hud_window_source_active_window_changed (hudwindowsource.c:261)
==1830== by 0x55BAC81: g_closure_invoke (gclosure.c:777)
==1830== by 0x55CBD50: signal_emit_unlocked_R (gsignal.c:3547)
==1830== by 0x55D4078: g_signal_emit_valist (gsignal.c:3296)
==1830== by 0x55D4221: g_signal_emit (gsignal.c:3352)
==1830== by 0x637D0A6: marshal_dbus_message_to_g_marshaller (dbus-gproxy.c:1734)
==1830== by 0x55BAC81: g_closure_invoke (gclosure.c:777)
==1830== by 0x55CBD50: signal_emit_unlocked_R (gsignal.c:3547)
==1830== by 0x55D4078: g_signal_emit_valist (gsignal.c:3296)
==1830== by 0x55D4221: g_signal_emit (gsignal.c:3352)
==1830== by 0x637D6E5: dbus_g_proxy_manager_filter (dbus-gproxy.c:1787)
==1830== by 0x76489A5: dbus_connection_dispatch (dbus-connection.c:4603)
==1830== by 0x6376424: message_queue_dispatch (dbus-gmain.c:90)
==1830== by 0x5841C99: g_main_context_dispatch (gmain.c:2515)
==1830== by 0x584205F: g_main_context_iterate.isra.23 (gmain.c:3123)
==1830== by 0x5842459: g_main_loop_run (gmain.c:3317)
==1830== by 0x404EBB: main (hud-service.c:320)

hudwindowsource.c:261 points to

source->active_icon = bamf_view_get_icon (BAMF_VIEW (application));

Unfortunately I'm not able to provide a fix.

ProblemType: Bug
DistroRelease: Ubuntu 12.04
Package: indicator-appmenu 0.3.96-0ubuntu2 [modified: usr/lib/indicator-appmenu/hud-service]
ProcVersionSignature: Ubuntu 3.2.0-21.34-generic 3.2.13
Uname: Linux 3.2.0-21-generic x86_64
ApportVersion: 2.0-0ubuntu3
Architecture: amd64
Date: Tue Apr 3 13:51:59 2012
InstallationMedia: Ubuntu 11.04 "Natty Narwhal" - Alpha amd64 (20110112)
ProcEnviron:
 TERM=xterm
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: indicator-appmenu
UpgradeStatus: No upgrade log present (probably fresh install)

Related branches

Revision history for this message
Hernando Torque (htorque) wrote :
Changed in indicator-appmenu (Ubuntu):
assignee: nobody → Ryan Lortie (desrt)
importance: Undecided → Low
Revision history for this message
Charles Kerr (charlesk) wrote :

This is fixed in Ryan's HUD branch <https://code.launchpad.net/~desrt/indicator-appmenu/hud-performance> which will be in this week's release.

Changed in indicator-appmenu:
status: New → In Progress
assignee: nobody → Ryan Lortie (desrt)
importance: Undecided → Low
Changed in indicator-appmenu (Ubuntu):
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package indicator-appmenu - 0.3.96-0ubuntu3

---------------
indicator-appmenu (0.3.96-0ubuntu3) precise; urgency=low

  * Backport desrt's performance improvement work:
    - reduce hud cpu usage and DoS on long strings (lp: #938584, ##948820)
    - should stop stripping issues (lp: #937020)
    - fixes a small leak (lp: #972354)
 -- Sebastien Bacher <email address hidden> Tue, 03 Apr 2012 17:59:03 +0200

Changed in indicator-appmenu (Ubuntu):
status: Fix Committed → Fix Released
Changed in indicator-appmenu:
status: In Progress → Fix Released
Charles Kerr (charlesk)
Changed in indicator-appmenu:
milestone: none → 0.3.97
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.