Alarm sounds vs Calendar sounds
Bug #1410874 reported by
Charles Kerr
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Released
|
High
|
Unassigned | ||
indicator-datetime (Ubuntu) |
Fix Released
|
High
|
Charles Kerr | ||
indicator-datetime (Ubuntu RTM) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
As discussed with rsalveti and pmcgowan in #phablet on 14 Jan
There are two issues in the datetime notification code that need to be changed.
1. Right now we only set role=alarm if the sound is looping; ie if it's an alarm clock event rather than calendar event.
Set calendar event role to alert
2. Calendar events shouldn't play in silent mode. We can test for silent mode on the bus, http://
Related branches
lp://qastaging/~charlesk/indicator-datetime/lp-1410874-alarm-sounds-vs-calendar-sounds
- Antti Kaijanmäki (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 281 lines (+128/-14)6 files modifiedinclude/notifications/sound.h (+1/-1)
src/CMakeLists.txt (+3/-0)
src/com.ubuntu.touch.AccountsService.Sound.xml (+42/-0)
src/snap.cpp (+57/-6)
src/sound.cpp (+12/-7)
tests/manual (+13/-0)
lp://qastaging/~charlesk/indicator-datetime/rtm-14.09-lp-1410874-alarm-sounds-vs-calendar-sounds
- Antti Kaijanmäki (community): Approve
-
Diff: 281 lines (+128/-14)6 files modifiedinclude/notifications/sound.h (+1/-1)
src/CMakeLists.txt (+3/-0)
src/com.ubuntu.touch.AccountsService.Sound.xml (+42/-0)
src/snap.cpp (+57/-6)
src/sound.cpp (+12/-7)
tests/manual (+13/-0)
Changed in indicator-datetime (Ubuntu): | |
importance: | Undecided → High |
description: | updated |
Changed in indicator-datetime (Ubuntu): | |
status: | Triaged → In Progress |
Changed in canonical-devices-system-image: | |
status: | Confirmed → Fix Released |
To post a comment you must log in.
Queue this up as new sync improvements will make calendar use more widespread