Ubuntu
indicator-sound package

Hardcoded paths in desktop files need to be processed need $SNAP prefixing

Bug #1638708 reported by Charles Kerr
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
indicator-application (Ubuntu)
New
Undecided
Unassigned
indicator-bluetooth (Ubuntu)
New
Undecided
Unassigned
indicator-datetime (Ubuntu)
New
Undecided
Unassigned
indicator-location (Ubuntu)
New
Undecided
Unassigned
indicator-messages (Ubuntu)
New
Undecided
Unassigned
indicator-power (Ubuntu)
New
Undecided
Unassigned
indicator-session (Ubuntu)
New
Undecided
Unassigned
indicator-sound (Ubuntu)
Triaged
High
Unassigned
indicator-transfer (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Noticed and reported by mterry in several indicator patches, e.g. <https://code.launchpad.net/~mterry/indicator-sound/snap-root/+merge/308125>:

> There are also two hardcoded paths in the data/*.desktop.in files.
> But that's a static desktop file, so $SNAP isn't appropriate.
> I think it makes more sense to update the code that reads those
> files to do the prefixing.

There is also an umbrella ticket for hardcoded paths in the u8 snap: <https://pad.lv/1629009>

See original description
Tags: unity8-snap

Related branches

lp://qastaging/~dobey/indicator-transfer/fix-dm-desktop
Pete Woods (community): Approve
unity-api-1-bot: Approve (continuous-integration)
Diff: 148 lines (+23/-67)
1 file modified
src/dm-plugin/dm-source.cpp (+23/-67)
Charles Kerr (charlesk)
description: updated
summary: - Hardcoded paths in data/*.desktop.in need Snappy prefixing
+ Hardcoded paths in desktop files need to be processed need $SNAP
+ prefixing
Charles Kerr (charlesk)
description: updated
Revision history for this message
dobey (dobey) wrote :

I'm not sure how much of this is valid. Most of these are .desktop files that are installed in the XDG autostart directory, and thus only used in environments which use that, of which Unity8 is not one, especially so in its snap form.

I suppose this also begs the question of whether Unity 8 should implement the XDG autostart spec?

Revision history for this message
Michael Terry (mterry) wrote :

Let's not transform this bug into a feature request for u8. :)

(Though just converting autostart files to systemd user-units is probably a better use of our time?)

But your point about not worrying about converting .desktop files that are only used for xdg-autostarting makes sense.

Revision history for this message
dobey (dobey) wrote :

Yeah, the indicators all ship upstart jobs, systemd units, and autostart .desktop files.

There are some cases where indicators need fixed in other ways to deal with similarly related issues (parsing other .desktop files), but generally the data/*.desktop.in files aren't a problem here, from what I can see.

dobey (dobey)
no longer affects: indicator-printers (Ubuntu)
no longer affects: indicator-network (Ubuntu)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package indicator-transfer - 0.2+17.04.20161205-0ubuntu1

---------------
indicator-transfer (0.2+17.04.20161205-0ubuntu1) zesty; urgency=medium

  * Use cmake-extras EnableCoverageReport instead of custom code for
    coverage.
  * Load plug-ins from $SNAP path too.
  * Use UAL C++ API to get app info and launch apps. (LP: #1638708)

 -- Rodney Dawes <email address hidden> Mon, 05 Dec 2016 18:03:02 +0000

Changed in indicator-transfer (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.