Wrong application name appears in Sound Preferences when using pulseaudio
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
libsdl |
Fix Released
|
Critical
|
|||
libsdl1.2 (Ubuntu) |
Triaged
|
Low
|
Unassigned |
Bug Description
SDL based applications sometimes display the wrong application name in the Sound Preferences dialog when using pulseaudio.
I can see from the code that the SDL pulse module is initiating a new pulse audio context and passing an application name using the function get_progname().
The get_progname() function returns the name of the current process. However, the process name is often not a suitable name to use. For example, the OpenShot video editor is a python application, and so "python" is displayed in the Sound Preferences window (see Bug #596504), when it should be displaying "OpenShot".
PulseAudio allows applications to specify the application name, either at the time the context is created (as SDL does currently), or by special environment variables (see http://
If you specify the application name when initiating the pulseaudio context, then that will override any application name specified using an environment variable.
As libsdl is a library, I believe the solution is for libsdl to not specify any application name when initiating a pulseaudio context, which will enable applications to specify the application name using environment variables. In the case that the applications do not specify anything, pulseaudio will fall back to using the process name anyway.
The attached patch removes the get_progname() function and passes NULL as the application name when creating the pulseaudio context, which fixes the issue.
tags: | added: patch |
tags: | added: patch-forwarded-upstream |
Changed in libsdl1.2 (Ubuntu): | |
status: | New → Triaged |
importance: | Undecided → Low |
Changed in libsdl: | |
importance: | Unknown → Medium |
status: | Unknown → In Progress |
Changed in libsdl: | |
importance: | Medium → Critical |
Changed in libsdl: | |
status: | In Progress → Fix Released |
Created attachment 512
Patch to not specify an application name when creating a pulse audio context.
I created the following bug on launchpad and thought I should raise it upstream. https:/ /bugs.launchpad .net/ubuntu/ +source/ libsdl1. 2/+bug/ 597859
------- ------- ------- ------
SDL based applications sometimes display the wrong application name in the Sound Preferences dialog when using pulseaudio.
I can see from the code that the SDL pulse module is initiating a new pulse audio context and passing an application name using the function get_progname().
The get_progname() function returns the name of the current process. However, the process name is often not a suitable name to use. For example, the OpenShot video editor is a python application, and so "python" is displayed in the Sound Preferences window (see Bug #596504), when it should be displaying "OpenShot".
PulseAudio allows applications to specify the application name, either at the time the context is created (as SDL does currently), or by special environment variables (see http:// www.pulseaudio. org/wiki/ ApplicationProp erties). If no name is specified, then pulseaudio will determine the name based on the process.
If you specify the application name when initiating the pulseaudio context, then that will override any application name specified using an environment variable.
As libsdl is a library, I believe the solution is for libsdl to not specify any application name when initiating a pulseaudio context, which will enable applications to specify the application name using environment variables. In the case that the applications do not specify anything, pulseaudio will fall back to using the process name anyway.
The attached patch removes the get_progname() function and passes NULL as the application name when creating the pulseaudio context, which fixes the issue.