Use rate-limited prints for mlx-trio errors
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
linux-bluefield (Ubuntu) |
New
|
Undecided
|
Unassigned | ||
Focal |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
The mlx-trio module's IRQ handler prints errors and additional debug info in case of errors. However, these prints can be excessive in certain cases, thereby interfering with other functions. This patch limits the message amount.
SRU Justification:
[Impact]
In cases where the mlx-trio module continuously receives interrupts, it prints a lot of messages which can potentially affect the console output and clutter dmesg logs.
[Fix]
This commit calls dev_err_
[Test Case]
When TRIO receives a bunch of PIO completion errors or PCIe link disabled errors, a ton of error messages from the IRQ handler can be seen, which has been limited by this patch.
[Regression Potential]
Regression potential can be considered minimum since the patch does not change any functions of the driver, but merely makes the error log more readable.
Changed in linux-bluefield (Ubuntu Focal): | |
status: | New → Fix Committed |
tags: |
added: verification-done-focal removed: verification-needed-focal |
This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification- needed- focal' to 'verification- done-focal' . If the problem still exists, change the tag 'verification- needed- focal' to 'verification- failed- focal'.
If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.
See https:/ /wiki.ubuntu. com/Testing/ EnableProposed for documentation how to enable and use -proposed. Thank you!