Do offload refresh when requested
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
linux-bluefield (Ubuntu) |
Invalid
|
Undecided
|
Unassigned | ||
Focal |
Fix Released
|
Medium
|
Dan Jurgens |
Bug Description
SRU Justification:
It could be not all conntrack tuples are offloaded.
* Explain the bug(s)
Offload could fail for multiple reasons and a refresh bit is set to try to reoffload it in next sw packet.
But sometimes the refresh bit not set. It’s sparse in multiple locations.
* brief explanation of fixes
We can just avoid checking if the refresh bit is set on refresh call and try to offload again as we did get
a sw packet and there won’t be more than one work entry for the same entry. So if refresh already
queued the function will do nothing. But if failed and nothing is queued a refresh will queue again.
* How to test
High traffic ct offload with lots conns. Test 200000 conns. We see insertion rate drops at ~100000.
Eventually we stop offloading new entries but in tcpdump we see traffic.
* What it could break.
Ct offload.
Changed in linux-bluefield (Ubuntu Focal): | |
assignee: | nobody → Dan Jurgens (danielj-mellanox) |
importance: | Undecided → Medium |
status: | New → In Progress |
Changed in linux-bluefield (Ubuntu): | |
status: | New → Invalid |
Changed in linux-bluefield (Ubuntu Focal): | |
status: | In Progress → Fix Committed |
tags: |
added: verification-done-focal removed: verification-needed-focal |
This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification- needed- focal' to 'verification- done-focal' . If the problem still exists, change the tag 'verification- needed- focal' to 'verification- failed- focal'.
If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.
See https:/ /wiki.ubuntu. com/Testing/ EnableProposed for documentation how to enable and use -proposed. Thank you!