xfrm_policy.sh / pmtu.sh / udpgso_bench.sh from net in ubuntu_kernel_selftests will fail with timeout if running the whole suite
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-kernel-tests |
Fix Released
|
Undecided
|
Po-Hsu Lin | ||
linux (Ubuntu) |
Opinion
|
Undecided
|
Po-Hsu Lin | ||
Bionic |
Fix Released
|
Undecided
|
Po-Hsu Lin | ||
Focal |
Opinion
|
Undecided
|
Unassigned | ||
Groovy |
Opinion
|
Undecided
|
Unassigned | ||
Hirsute |
Opinion
|
Undecided
|
Unassigned | ||
Impish |
Opinion
|
Undecided
|
Po-Hsu Lin | ||
linux-oem-5.6 (Ubuntu) |
Invalid
|
Undecided
|
Unassigned | ||
Bionic |
Invalid
|
Undecided
|
Unassigned | ||
Focal |
Won't Fix
|
Undecided
|
Po-Hsu Lin | ||
Groovy |
Invalid
|
Undecided
|
Unassigned | ||
Hirsute |
Invalid
|
Undecided
|
Unassigned | ||
Impish |
Invalid
|
Undecided
|
Unassigned |
Bug Description
[Impact]
These 3 tests will fail with timeout error when running the whole
"net" test in ubuntu_
* not ok 12 selftests: net: xfrm_policy.sh # TIMEOUT
* not ok 16 selftests: net: pmtu.sh # TIMEOUT
* not ok 19 selftests: net: udpgso_bench.sh # TIMEOUT
They will pass if you run them manually. This is because of the
default 45 seconds timeout in kselftest framework.
A quick test shows these tests will take about:
xfrm_policy.sh - 2m19.690s
pmtu.sh - 3m6.832s
udpgso_bench.sh - 0m57.985s
[Fix]
* b881d089c7c9c7 ("selftests/net: bump timeout to 5 minutes")
We have commit 852c8cbf34d3b3 ("selftests/
second timeout per test") for default timeout added since Bionic.
However there is a SAUCE patch ("UBUNTU: SAUCE: selftests/net --
disable timeout") to disable timeout for the net test in newer
releases. I think we can leave it as-is for the moment unless some
test is hanging too long because of that.
Therefore Only Bionic needs this patch, the patch can be applied with
some context adjustment.
[Test]
With this patch applied, these tests should have a chance to finish.
[Where problems could occur]
The fix is just for testing tool, no actual impact to real kernel
functions. If this 5 minutes timeout is not enough, we might still
seeing this kind of failures in the test report.
[Original Bug Report]
These 3 tests will fail with timeout when running the whole "net" test in ubuntu_
* not ok 12 selftests: net: xfrm_policy.sh # TIMEOUT
* not ok 16 selftests: net: pmtu.sh # TIMEOUT
* not ok 19 selftests: net: udpgso_bench.sh # TIMEOUT
However they will pass if you run them manually.
So there must be some test in net that will cause this.
From the test result it looks like the test was executed in the following sequence:
ok 1 selftests: net: reuseport_bpf
ok 2 selftests: net: reuseport_bpf_cpu
ok 3 selftests: net: reuseport_bpf_numa
ok 4 selftests: net: reuseport_dualstack
# Successok 5 selftests: net: reuseaddr_conflict
ok 6 selftests: net: tls
ok 7 selftests: net: run_netsocktests
ok 8 selftests: net: run_afpackettests
ok 9 selftests: net: test_bpf.sh
ok 10 selftests: net: netdevice.sh
ok 11 selftests: net: rtnetlink.sh
not ok 12 selftests: net: xfrm_policy.sh # TIMEOUT
not ok 13 selftests: net: test_blackhole_
ok 14 selftests: net: fib_tests.sh
ok 15 selftests: net: fib-onlink-tests.sh
not ok 16 selftests: net: pmtu.sh # TIMEOUT
ok 17 selftests: net: udpgso.sh
not ok 18 selftests: net: ip_defrag.sh # exit=255
not ok 19 selftests: net: udpgso_bench.sh # TIMEOUT
ok 20 selftests: net: fib_rule_tests.sh
not ok 21 selftests: net: msg_zerocopy.sh # exit=1
ok 22 selftests: net: psock_snd.sh
ok 23 selftests: net: udpgro_bench.sh
ok 24 selftests: net: udpgro.sh
ok 25 selftests: net: test_vxlan_
ok 26 selftests: net: reuseport_
ok 27 selftests: net: test_vxlan_
ok 28 selftests: net: so_txtime.sh
ok 29 selftests: net: ipv6_flowlabel.sh
ok 30 selftests: net: tcp_fastopen_
ProblemType: Bug
DistroRelease: Ubuntu 19.10
Package: linux-image-
ProcVersionSign
Uname: Linux 5.3.0-1009-aws aarch64
ApportVersion: 2.20.11-0ubuntu8.3
Architecture: arm64
Date: Wed Dec 11 06:42:39 2019
Ec2AMI: ami-047cec24582
Ec2AMIManifest: (unknown)
Ec2Availability
Ec2InstanceType: a1.large
Ec2Kernel: unavailable
Ec2Ramdisk: unavailable
SourcePackage: linux-aws
UpgradeStatus: No upgrade log present (probably fresh install)
tags: | added: sru-20191202 |
tags: | added: 5.3 aws ubuntu-kernel-selftests |
tags: | added: sru-20200106 |
tags: | added: gke |
tags: | added: sru-20200629 |
tags: | added: focal |
tags: | added: sru-20200831 |
tags: | added: sru-20201109 |
Changed in linux (Ubuntu Bionic): | |
status: | New → In Progress |
assignee: | nobody → Po-Hsu Lin (cypressyew) |
description: | updated |
Changed in linux (Ubuntu Groovy): | |
status: | New → Invalid |
Changed in linux (Ubuntu Focal): | |
status: | New → Invalid |
Changed in linux (Ubuntu Hirsute): | |
status: | New → Invalid |
Changed in linux (Ubuntu Groovy): | |
status: | Invalid → Opinion |
Changed in linux (Ubuntu Focal): | |
status: | Invalid → Opinion |
Changed in linux (Ubuntu Hirsute): | |
status: | Invalid → Opinion |
Changed in linux (Ubuntu Impish): | |
status: | In Progress → Opinion |
description: | updated |
Changed in linux (Ubuntu Bionic): | |
status: | In Progress → Fix Committed |
tags: | added: oem oem-5.6 sru-20210412 |
Changed in linux-oem-5.6 (Ubuntu Focal): | |
status: | In Progress → Fix Committed |
summary: |
xfrm_policy.sh / pmtu.sh / udpgso_bench.sh from net in - ubuntu_kernel_selftests will fail if running the whole suite + ubuntu_kernel_selftests will fail with timeout if running the whole + suite |
Changed in linux-oem-5.6 (Ubuntu Focal): | |
status: | Fix Committed → Won't Fix |
Changed in ubuntu-kernel-tests: | |
status: | In Progress → Fix Released |
There was a backport for 5.3 of a timeout, I am in the process of finding out a good timeout value for the net testsuite before I can send it upstream. Let me send the value I found so far, which works for xfrm_policy.sh, which seems to be the one that takes most time. 150 would be fine here.