Preinstalled amd64 images cannot upgrade grub.cfg on boot partition + technical debt
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| cloud-initramfs-tools (Ubuntu) |
New
|
Undecided
|
Unassigned | ||
| Focal |
Fix Released
|
Undecided
|
Unassigned | ||
| livecd-rootfs (Ubuntu) |
New
|
Critical
|
Unassigned | ||
| Focal |
Fix Released
|
Critical
|
Unassigned | ||
Bug Description
[Impact]
This is a design flaw that needs to be fixed. Basically we inherited the design from old Ubuntu Core devices that the boot configuration is prepared in the gadget and - therefore - is quite static. Newer Core devices have mechanisms for updating boot assets, while classic images... well, we never actually thought about it.
Now that we have a valid use-case for preinstalled amd64 images, we actually need to make sure we can update at least the grub config somehow. To do this, we introduce the hook from preinstalled desktop images from groovy+ with an additional change to generate the grub.cfg by using `update-grub2`. We switch the design to now only shipping a blanket grub.cfg on the boot partition, pointing to the rootfs one - which can be freely updated via existing mechanisms.
While adding the hook, we also fix a few other technical dept - like adding a swap file and making the rootfs resizable. Everything that we already had for our Pi images in groovy+.
The growroot part might also require a quick workaround in cloud-initramfs
[Test Case]
* Base test case:
Build an image with -proposed enabled, make sure that it still boots as before on Intel IOT platforms. Try booting the image on an USB when there are other USB drives present on the device.
* Growroot:
Resize the image so that growroot finds space to expand the rootfs. Boot the image, make sure that the image boots fine on first boot (no initramfs prompt!). Log into the system and run `sudo udevadm info /dev/sda3` and check if there are "ID_*" properties present. Check if the root partition has expanded as expected.
* Grub updates:
On the booted image, run `sudo update-grub2`, make sure that there are no errors present. Reboot, check if the image still boots correctly.
To make sure the rootfs grub.cfg is used, modify /etc/default/grub and change GRUB_TIMEOUT to 10. Run `sudo update-grub2` again and reboot. Confirm that the grub menu appears with a 10 second timeout.
[Regression Potential]
This can basically only regress intel-iotg desktop images, which is what we want to fix right now. But it requires for the images to go through the whole testing cycle again, to make sure that everything still works - since we're basically switching to a completely new grub.cfg. The test case should be sufficient to make sure there are no regressions.
The cloud-initramfs
Related branches
- cloud-initramfs-tools: Pending requested
-
Diff: 21 lines (+4/-4)1 file modifiedgrowroot/scripts/local-bottom/growroot (+4/-4)
- Brian Murray: Approve
-
Diff: 139 lines (+125/-0)2 files modifieddebian/changelog (+10/-0)
live-build/ubuntu/hooks/099-ubuntu-image-customization.chroot (+115/-0)
| description: | updated |
| Changed in livecd-rootfs (Ubuntu Focal): | |
| importance: | Undecided → Critical |
| status: | New → In Progress |
| summary: |
- Preinstalled amd64 images cannot upgrade grub.cfg on boot partition + Preinstalled amd64 images cannot upgrade grub.cfg on boot partition + + technical dept |
| Brian Murray (brian-murray) wrote Please test proposed package | #1 |
| Changed in livecd-rootfs (Ubuntu Focal): | |
| status: | In Progress → Fix Committed |
| tags: | added: verification-needed verification-needed-focal |
| Brian Murray (brian-murray) wrote | #2 |
| summary: |
Preinstalled amd64 images cannot upgrade grub.cfg on boot partition + - technical dept + technical debt |
| Ubuntu SRU Bot (ubuntu-sru-bot) wrote Autopkgtest regression report (livecd-rootfs/2.664.32) | #3 |
| description: | updated |
| description: | updated |
| Brian Murray (brian-murray) wrote Please test proposed package | #4 |
| Changed in cloud-initramfs-tools (Ubuntu Focal): | |
| status: | New → Fix Committed |
| Brian Murray (brian-murray) wrote | #5 |
| Ubuntu SRU Bot (ubuntu-sru-bot) wrote Autopkgtest regression report (livecd-rootfs/2.664.33) | #6 |
| Łukasz Zemczak (sil2100) wrote | #7 |
| tags: |
added: verification-done verification-done-focal removed: verification-needed verification-needed-focal |
| Launchpad Janitor (janitor) wrote | #8 |
| Changed in cloud-initramfs-tools (Ubuntu Focal): | |
| status: | Fix Committed → Fix Released |
| Brian Murray (brian-murray) wrote Update Released | #9 |
| Launchpad Janitor (janitor) wrote | #10 |
| Changed in livecd-rootfs (Ubuntu Focal): | |
| status: | Fix Committed → Fix Released |
Hello Łukasz, or anyone else affected,
Accepted livecd-rootfs into focal-proposed. The package will build now and be available at https:/
Please help us by testing this new package. See https:/
If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-
Further information regarding the verification process can be found at https:/
N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.