[enhancement] Allow a Mir nested server to have a transparent background
Bug #1256702 reported by
Michael Terry
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
Medium
|
Andreas Pokorny | ||
mir (Ubuntu) |
Fix Released
|
High
|
Unassigned |
Bug Description
Currently nested servers use an opaque background. Which makes having a greeter that shows the user session behind it difficult.
It would make life a lot easier for the greeter if it could specify that the background should be transparent. Either this is something we could opt-into or make it the default if that wouldn't hurt performance.
Related branches
lp://qastaging/~robertcarr/mir/alpha-for-nested-servers
Rejected
for merging
into
lp://qastaging/mir
- Alan Griffiths: Needs Fixing
- Daniel van Vugt: Needs Fixing
- Alexandros Frantzis (community): Needs Information
- PS Jenkins bot (community): Approve (continuous-integration)
- Kevin DuBois (community): Needs Fixing
- Michael Terry (community): Approve
-
Diff: 41 lines (+5/-5)1 file modifiedsrc/server/graphics/nested/nested_display.cpp (+5/-5)
lp://qastaging/~andreas-pokorny/mir/allow-transparent-server-buffers
Superseded
for merging
into
lp://qastaging/mir
- Alan Griffiths: Needs Fixing
- Daniel van Vugt: Pending requested
- Alexandros Frantzis: Pending requested
-
Diff: 1416 lines (+517/-152)41 files modifiedexamples/CMakeLists.txt (+1/-1)
examples/basic_server.cpp (+0/-2)
examples/demo-shell/window_manager.cpp (+1/-0)
examples/render_surfaces.cpp (+22/-2)
examples/select_pixel_format.cpp (+69/-0)
examples/select_pixel_format.h (+52/-0)
examples/server_configuration.cpp (+8/-4)
include/platform/mir/graphics/display_configuration.h (+2/-2)
include/platform/mir/graphics/platform.h (+1/-1)
include/server/mir/graphics/pixel_format_utils.h (+46/-0)
include/test/mir_test_doubles/null_display_configuration.h (+1/-1)
include/test/mir_test_doubles/stub_display_configuration.h (+1/-1)
src/platform/graphics/android/android_display_configuration.cpp (+1/-1)
src/platform/graphics/android/android_display_configuration.h (+1/-1)
src/platform/graphics/mesa/real_kms_display_configuration.cpp (+5/-1)
src/platform/graphics/mesa/real_kms_display_configuration.h (+2/-2)
src/server/frontend/session_mediator.cpp (+2/-1)
src/server/graphics/CMakeLists.txt (+1/-0)
src/server/graphics/default_display_configuration_policy.cpp (+4/-3)
src/server/graphics/nested/nested_display.cpp (+40/-57)
src/server/graphics/nested/nested_display.h (+6/-5)
src/server/graphics/nested/nested_display_configuration.cpp (+5/-1)
src/server/graphics/nested/nested_display_configuration.h (+1/-1)
src/server/graphics/nested/nested_output.cpp (+3/-2)
src/server/graphics/nested/nested_output.h (+2/-1)
src/server/graphics/nested/nested_platform.cpp (+2/-2)
src/server/graphics/nested/nested_platform.h (+5/-5)
src/server/graphics/offscreen/display_configuration.cpp (+1/-1)
src/server/graphics/offscreen/display_configuration.h (+4/-4)
src/server/graphics/pixel_format_utils.cpp (+65/-0)
src/server/scene/mediating_display_changer.cpp (+1/-0)
tests/mir_test/display_config_matchers.cpp (+1/-1)
tests/unit-tests/frontend/test_session_mediator.cpp (+6/-3)
tests/unit-tests/graphics/CMakeLists.txt (+1/-0)
tests/unit-tests/graphics/android/test_android_fb.cpp (+22/-22)
tests/unit-tests/graphics/mesa/test_cursor.cpp (+1/-1)
tests/unit-tests/graphics/mesa/test_display_multi_monitor.cpp (+16/-6)
tests/unit-tests/graphics/mesa/test_overlapping_output_grouping.cpp (+1/-1)
tests/unit-tests/graphics/nested/test_nested_display_configuration.cpp (+26/-9)
tests/unit-tests/graphics/test_default_display_configuration_policy.cpp (+9/-7)
tests/unit-tests/graphics/test_pixel_format_utils.cpp (+79/-0)
lp://qastaging/~andreas-pokorny/mir/pixel-format-utils
- PS Jenkins bot (community): Approve (continuous-integration)
- Alexandros Frantzis (community): Approve
- Daniel van Vugt: Approve
- Kevin DuBois (community): Approve
- Alan Griffiths: Approve
- Robert Carr (community): Approve
- Andreas Pokorny (community): Approve
-
Diff: 238 lines (+202/-0)5 files modifiedinclude/platform/mir/graphics/pixel_format_utils.h (+50/-0)
src/platform/graphics/CMakeLists.txt (+1/-0)
src/platform/graphics/pixel_format_utils.cpp (+54/-0)
tests/unit-tests/graphics/CMakeLists.txt (+1/-0)
tests/unit-tests/graphics/test_pixel_format_utils.cpp (+96/-0)
Superseded
for merging
into
lp://qastaging/mir/0.1
- Mir development team: Pending requested
-
Diff: 886 lines (+444/-102)22 files modifiedbenchmarks/CMakeLists.txt (+3/-1)
doc/building_source_for_android.md (+21/-32)
include/platform/mir/graphics/pixel_format_utils.h (+45/-0)
include/shared/mir/logging/input_timestamp.h (+35/-0)
include/test/mir_test_doubles/mock_surface_renderer.h (+2/-1)
src/client/logging/input_receiver_report.cpp (+3/-2)
src/platform/graphics/CMakeLists.txt (+1/-0)
src/platform/graphics/pixel_format_utils.cpp (+71/-0)
src/server/compositor/default_display_buffer_compositor.cpp (+2/-1)
src/server/compositor/gl_renderer.cpp (+28/-33)
src/server/compositor/gl_renderer.h (+12/-22)
src/server/compositor/renderer.h (+2/-1)
src/server/logging/input_report.cpp (+4/-3)
src/shared/logging/CMakeLists.txt (+1/-0)
src/shared/logging/input_timestamp.cpp (+41/-0)
tests/acceptance-tests/test_server_shutdown.cpp (+5/-1)
tests/integration-tests/test_session.cpp (+4/-1)
tests/integration-tests/test_surface_first_frame_sync.cpp (+5/-1)
tests/mir_test_framework/stubbed_server_configuration.cpp (+5/-1)
tests/unit-tests/compositor/test_default_display_buffer_compositor.cpp (+63/-2)
tests/unit-tests/graphics/CMakeLists.txt (+1/-0)
tests/unit-tests/graphics/test_pixel_format_utils.cpp (+90/-0)
lp://qastaging/~andreas-pokorny/mir/add-pixel-format-to-display-configuration
- PS Jenkins bot (community): Approve (continuous-integration)
- Daniel van Vugt: Approve
- Alan Griffiths: Abstain
- Robert Carr (community): Approve
-
Diff: 1838 lines (+481/-326)40 files modifieddebian/control (+2/-2)
debian/libmirclient5.install (+1/-1)
examples/demo-shell/window_manager.cpp (+2/-1)
examples/server_configuration.cpp (+8/-4)
include/platform/mir/graphics/display_configuration.h (+5/-4)
include/shared/mir_toolkit/client_types.h (+1/-1)
include/test/mir_test_doubles/null_display_configuration.h (+7/-7)
include/test/mir_test_doubles/stub_display_configuration.h (+6/-5)
src/client/CMakeLists.txt (+1/-1)
src/client/display_configuration.cpp (+1/-1)
src/platform/graphics/android/android_display_configuration.cpp (+9/-3)
src/platform/graphics/android/android_display_configuration.h (+4/-3)
src/platform/graphics/mesa/real_kms_display_configuration.cpp (+21/-5)
src/platform/graphics/mesa/real_kms_display_configuration.h (+4/-4)
src/server/frontend/protobuf_buffer_packer.cpp (+1/-1)
src/server/frontend/session_mediator.cpp (+4/-1)
src/server/graphics/default_display_configuration_policy.cpp (+53/-14)
src/server/graphics/nested/nested_display.cpp (+42/-57)
src/server/graphics/nested/nested_display.h (+6/-5)
src/server/graphics/nested/nested_display_configuration.cpp (+24/-5)
src/server/graphics/nested/nested_display_configuration.h (+3/-3)
src/server/graphics/nested/nested_output.cpp (+3/-2)
src/server/graphics/nested/nested_output.h (+2/-1)
src/server/graphics/nested/nested_platform.cpp (+2/-2)
src/server/graphics/nested/nested_platform.h (+5/-5)
src/server/graphics/offscreen/display_configuration.cpp (+4/-2)
src/server/graphics/offscreen/display_configuration.h (+4/-4)
src/server/scene/mediating_display_changer.cpp (+1/-0)
tests/acceptance-tests/test_client_library.cpp (+1/-1)
tests/mir_test/display_config_matchers.cpp (+5/-5)
tests/mir_test_framework/stubbed_server_configuration.cpp (+1/-1)
tests/unit-tests/frontend/test_session_mediator.cpp (+7/-3)
tests/unit-tests/graphics/android/test_android_fb.cpp (+22/-22)
tests/unit-tests/graphics/mesa/test_cursor.cpp (+7/-7)
tests/unit-tests/graphics/mesa/test_display_configuration.cpp (+7/-7)
tests/unit-tests/graphics/mesa/test_display_multi_monitor.cpp (+16/-6)
tests/unit-tests/graphics/mesa/test_overlapping_output_grouping.cpp (+2/-2)
tests/unit-tests/graphics/nested/test_nested_display_configuration.cpp (+27/-11)
tests/unit-tests/graphics/test_default_display_configuration_policy.cpp (+159/-116)
tests/unit-tests/graphics/test_display_configuration.cpp (+1/-1)
Superseded
for merging
into
lp://qastaging/mir/0.1
- Mir development team: Pending requested
-
Diff: 2751 lines (+957/-452)58 files modifiedbenchmarks/CMakeLists.txt (+3/-1)
doc/building_source_for_android.md (+21/-32)
examples/demo-shell/window_manager.cpp (+2/-1)
examples/server_configuration.cpp (+8/-4)
include/platform/mir/graphics/display_configuration.h (+3/-3)
include/platform/mir/graphics/pixel_format_utils.h (+50/-0)
include/platform/mir/graphics/platform.h (+1/-1)
include/shared/mir/logging/input_timestamp.h (+35/-0)
include/shared/mir_toolkit/client_types.h (+1/-1)
include/test/mir_test_doubles/mock_surface_renderer.h (+2/-1)
include/test/mir_test_doubles/null_display_configuration.h (+1/-1)
include/test/mir_test_doubles/stub_display_configuration.h (+6/-5)
src/client/display_configuration.cpp (+1/-1)
src/client/logging/input_receiver_report.cpp (+3/-2)
src/platform/graphics/CMakeLists.txt (+1/-0)
src/platform/graphics/android/android_display_configuration.cpp (+4/-2)
src/platform/graphics/android/android_display_configuration.h (+1/-1)
src/platform/graphics/mesa/real_kms_display_configuration.cpp (+64/-40)
src/platform/graphics/mesa/real_kms_display_configuration.h (+2/-2)
src/platform/graphics/pixel_format_utils.cpp (+71/-0)
src/server/compositor/default_display_buffer_compositor.cpp (+2/-1)
src/server/compositor/gl_renderer.cpp (+28/-33)
src/server/compositor/gl_renderer.h (+12/-22)
src/server/compositor/renderer.h (+2/-1)
src/server/frontend/protobuf_buffer_packer.cpp (+1/-1)
src/server/frontend/session_mediator.cpp (+3/-1)
src/server/graphics/default_display_configuration_policy.cpp (+54/-19)
src/server/graphics/nested/nested_display.cpp (+42/-57)
src/server/graphics/nested/nested_display.h (+6/-5)
src/server/graphics/nested/nested_display_configuration.cpp (+35/-10)
src/server/graphics/nested/nested_display_configuration.h (+1/-1)
src/server/graphics/nested/nested_output.cpp (+3/-2)
src/server/graphics/nested/nested_output.h (+2/-1)
src/server/graphics/nested/nested_platform.cpp (+2/-2)
src/server/graphics/nested/nested_platform.h (+5/-5)
src/server/graphics/offscreen/display_configuration.cpp (+4/-2)
src/server/graphics/offscreen/display_configuration.h (+4/-4)
src/server/logging/input_report.cpp (+4/-3)
src/server/scene/mediating_display_changer.cpp (+1/-0)
src/shared/logging/CMakeLists.txt (+1/-0)
src/shared/logging/input_timestamp.cpp (+41/-0)
tests/acceptance-tests/test_server_shutdown.cpp (+5/-1)
tests/integration-tests/test_session.cpp (+4/-1)
tests/integration-tests/test_surface_first_frame_sync.cpp (+5/-1)
tests/mir_test/display_config_matchers.cpp (+2/-2)
tests/mir_test_framework/stubbed_server_configuration.cpp (+6/-2)
tests/unit-tests/compositor/test_default_display_buffer_compositor.cpp (+63/-2)
tests/unit-tests/frontend/test_session_mediator.cpp (+7/-3)
tests/unit-tests/graphics/CMakeLists.txt (+1/-0)
tests/unit-tests/graphics/android/test_android_fb.cpp (+22/-22)
tests/unit-tests/graphics/mesa/test_cursor.cpp (+7/-7)
tests/unit-tests/graphics/mesa/test_display_configuration.cpp (+7/-7)
tests/unit-tests/graphics/mesa/test_display_multi_monitor.cpp (+16/-6)
tests/unit-tests/graphics/mesa/test_overlapping_output_grouping.cpp (+2/-2)
tests/unit-tests/graphics/nested/test_nested_display_configuration.cpp (+27/-11)
tests/unit-tests/graphics/test_default_display_configuration_policy.cpp (+159/-116)
tests/unit-tests/graphics/test_display_configuration.cpp (+1/-1)
tests/unit-tests/graphics/test_pixel_format_utils.cpp (+90/-0)
Changed in mir (Ubuntu): | |
assignee: | Robert Carr (robertcarr) → Andreas Pokorny (andreas-pokorny) |
status: | Confirmed → In Progress |
Changed in mir: | |
assignee: | nobody → Andreas Pokorny (andreas-pokorny) |
milestone: | none → 0.1.3 |
status: | New → In Progress |
importance: | Undecided → Medium |
summary: |
- Allow a Mir nested server to have a transparent background + [enhancement] Allow a Mir nested server to have a transparent background |
Changed in mir (Ubuntu): | |
status: | In Progress → Triaged |
assignee: | Andreas Pokorny (andreas-pokorny) → nobody |
tags: | added: enhancement |
tags: | added: nested |
Changed in mir: | |
milestone: | 0.1.3 → 0.1.4 |
Changed in mir: | |
status: | Fix Committed → In Progress |
Changed in mir: | |
status: | In Progress → Fix Committed |
Changed in mir: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
racarr, not sure you're the right person....might determine if anpok should take