disable-disconnect-notification option ignored

yes, this is a bug and should be relatively easy to fix. unfortuantely all those patches are not yet upstream so it would again be only ubuntu work.... willl think about it.

If you decide to wait for upstream to fix, at least reconsider to
enable connected notifications

enabling/disabling notifications in gconf by default is a different bug.

the other bug is bug 444561

On Thu, Oct 08, 2009 at 07:13:11AM -0000, Nicolò Chieffo wrote:
> If you decide to wait for upstream to fix, at least reconsider to
> enable connected notifications

yes, thats involved in bug 444561 ... which is about that regression.

 - Alexander

Unlike the OP I'm still also getting notifications when connected despite setting the option, but the notifications are incorrect: they tell me I'm disconnected when really I'm connected.

Using network-manager-gnome 0.8~a~git.20091014t134532.4033e62-0ubuntu1 on Karmic UNR.

Surely you need to debug the patches before they'll be accepted upstream, not wait until they accept broken patches and then fix them.

+1 to fixing this rather than try and push a broken patch upstream. The OSS projects I'm involved in would veto a patch with known failings and say "fix it first"

Can someone explain why this patch:

lp341684_device_sensitive_disconnect_notify.patch

does not use the function applet_do_notify_with_pref () to display disconnected notifications? You can see where it was removed by the patch:

- applet_do_notify_with_pref (applet, _("Disconnected"),
- _("The network connection has been disconnected."),
- "nm-no-connection",
- PREF_DISABLE_DISCONNECTED_NOTIFICATIONS);

The above function checks the value of /apps/nm-applet/disable-disconnected-notifications before displaying the notification.
The code from the patch does not:

...
info->text = _("Disconnected - you are now offline");
...

Is this bug related to https://bugs.launchpad.net/ubuntu/+source/network-manager-applet/+bug/835972 ?

@Kevin: I'm not sure. Issue 835972 is about the dialog coming up on suspend/resume and not going away automatically.

This one is about the dialog appearing in the first place -even when you've told it not to appear.

Proposed fix in lp:~matvey-marinin/network-manager-applet/lp445872, can anyone review?

This bug was fixed in the package network-manager-applet - 0.9.6.0~git201207161252.13c6db8-0ubuntu2

---------------
network-manager-applet (0.9.6.0~git201207161252.13c6db8-0ubuntu2) quantal; urgency=low

  * debian/patches/lp341684_device_sensitive_disconnect_notify.patch: updated
    to respect the "disable-disconnected-notifications" settings. (LP: #445872)
 -- Matvey Marinin <email address hidden> Thu, 02 Aug 2012 16:21:04 -0400

Can we please see about getting this into an SRU for precise as well? Thanks.

Hi Kent,

I've uploaded a test package at https://launchpad.net/~jm-leddy/+archive/enable-disable-disconnect-notification-2 . The other archive didn't work due to a binary difference between 12.04 and 12.10. Please let me know if this version works, and I'll ask for a merge request.

Hi James,

I seem to be locked out of that archive. Trying to access it gives me a "Not allowed here" page.

This hasn't been promoted to proposed because we're waiting on another SRU.

Right, then I'm removing the sponsors team so that people don't keep looking at this bug. Please readd it when you're ready for the package to be sponsored.

@James: What is the other SRU that we're waiting on? Can you provide a link to the bug(s) for the other SRU?

Hi Steve,

This is blocked by bug 780602. Since that bug is verification-failed, we have to pull the nm-applet package from precise before we fix this bug in precise.

@James: Who is responsible for pulling the nm-applet package from precise and when will that happen?

We have decided to upload the new package after all. I'm working with ~ubuntu-sru to get this into the updates archives.

Hello Nicolò, or anyone else affected,

Accepted network-manager-applet into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/network-manager-applet/0.9.4.1-0ubuntu2.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

oops...didn't see this go out for precise. I'll test it and provide feedback.

Proposed packages appear to finally fix this. I can tell gconftool to suppress the OSD messages for disconnect and they are now obeyed. Thanks for your work!

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

This bug was fixed in the package network-manager-applet - 0.9.4.1-0ubuntu2.3

---------------
network-manager-applet (0.9.4.1-0ubuntu2.3) precise-proposed; urgency=low

  [ Matvey Marinin ]
  * debian/patches/lp341684_device_sensitive_disconnect_notify.patch: updated
    to respect the "disable-disconnected-notifications" settings. (LP: #445872)
 -- James M Leddy <email address hidden> Mon, 15 Apr 2013 16:15:22 -0400