noteedit: merge new debian version

Bug #5577 reported by Seth Kinast
4
Affects Status Importance Assigned to Milestone
noteedit (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

MoM: http://people.ubuntu.com/~scott/ongoing-merge/noteedit/
MOTU: Seth Kinast <<email address hidden>
Status: MERGED

Debdiff attached.

Revision history for this message
Seth Kinast (seth) wrote : debdiff from 2.7.1-2ubuntu1 to 2.8.0-1ubuntu1

Verified to build on i386.
Verified to install on i386.
Functionality tested and program is working as expected.

Changed in noteedit:
assignee: nobody → motureviewers
status: New → PendingUpload
Revision history for this message
Reinhard Tartler (siretart) wrote :

this debdiff is 6MB large! boy, we cannot review such large debdiffs. Please try to generate a smaller one

Changed in noteedit:
assignee: motureviewers → motumergers
status: PendingUpload → Accepted
Revision history for this message
Seth Kinast (seth) wrote :

Hi siretart,

Most of it is just because this is such a large upstream version bump. Would it be better for me to put it on REVU as orig.tar.gz and diff.gz?

Revision history for this message
Andrew Mitchell (ajmitch) wrote :

I'd make a debdiff against the current debian source, to show only the ubuntu changes that need made. Mark the debdiff as such & we could review it then

Revision history for this message
Seth Kinast (seth) wrote : debdiff from 2.8.0-1 to 2.8.0-1ubuntu1

Right, that makes much more sense. Only 170K now :) Sorry for the trouble!

Revision history for this message
Seth Kinast (seth) wrote :

Actually, that didn't debdiff cleanly. I'll need a fresh source tree first, wait a minute.

Revision history for this message
Seth Kinast (seth) wrote : real debdiff from 2.8.0-1 to 2.8.0-1ubuntu1

Note to self, no more patching at 4am. Can you say 6K?

Changed in noteedit:
status: Accepted → PendingUpload
Revision history for this message
Reinhard Tartler (siretart) wrote :

much better!

is this Patch to Makefile.am really necessary? it looks pretty useles. If so, we can drop the addition to dpatch completly!

Revision history for this message
Seth Kinast (seth) wrote : removed patch

I talked to Riddell:

[12:47] <Riddell> seth_k: possibly KDE doesn't like naming Makefile.am variables "data"

But I tried building without it and it did fine. From the changelog entry, it was to fix a FTBFS and if it builds without it, I'm all for removing it :)

Debdiff updated accordingly.

Seth Kinast (seth)
Changed in noteedit:
status: PendingUpload → Fixed
Curtis Hovey (sinzui)
Changed in noteedit (Ubuntu):
assignee: Registry Administrators (registry) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.