Test suite integration with system package manager is broken
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
phoronix-test-suite (Ubuntu) |
New
|
Undecided
|
Unassigned |
Bug Description
Automatic installation of system dependancies doesn't work. I'm prompted for a password and the installation silently fails. As seen here:
aidan@ubibox ~ $ phoronix-test-suite benchmark pts/dbench
The following dependencies are needed and will be installed:
- autoconf
- libpopt-dev
This process may take several minutes.
[sudo] password for aidan:
sudo: aptitude -y install autoconf libpopt-dev: command not found
There are dependencies still missing from the system:
- Autoconf
- Popt
1: Ignore missing dependencies and proceed with installation.
2: Skip installing the tests with missing dependencies.
3: Re-attempt to install the missing dependencies.
4: Quit the current Phoronix Test Suite process.
Missing dependencies action: 4
-------------
The problem is in /usr/share/
--- install-
+++ install-
@@ -1,4 +1,5 @@
#!/bin/sh
+
if [ `whoami` != "root" ]; then
if [ -x /usr/bin/gksudo ] && [ ! -z "$DISPLAY" ]; then
@@ -7,15 +8,13 @@
elif [ -x /usr/bin/sudo ]; then
fi
-else
- su -c "apt-get -y install $*"
- exit
fi
if [ -x /usr/bin/aptitude ]; then
# aptitude is nice since it doesn't fail if a non-existant package is hit
# See: http://
- $ROOT -- "aptitude -y install $*"
+ $ROOT aptitude -y install $*
else
- $ROOT -- "apt-get -y --ignore-missing install $*"
+ $ROOT apt-get -y --ignore-missing install $*
fi
+
---------
Tested, works fine.
ProblemType: Bug
DistroRelease: Ubuntu 12.04
Package: phoronix-test-suite 3.6.1-1
ProcVersionSign
Uname: Linux 3.2.0-20-generic x86_64
ApportVersion: 1.95-0ubuntu1
Architecture: amd64
Date: Sat Mar 31 08:03:25 2012
InstallationMedia: Ubuntu-Server 12.04 LTS "Precise Pangolin" - Beta amd64 (20120327)
PackageArchitec
ProcEnviron:
TERM=xterm
SHELL=/bin/bash
LANG=en_IE.UTF-8
LANGUAGE=en_IE:en
SourcePackage: phoronix-test-suite
UpgradeStatus: No upgrade log present (probably fresh install)
aidanjt: Running without any X Server I imagine? There was a known bug with it due to gksudo vs. sudo differences. IIRC, your patch now allows the installer to work when not using X, but then if gksudo is used it will break. It was being pesky, I think I changed it around in the released Phoronix Test Suite 3.8 from March.