USC-gtk3 doesn't allow for tabbing between the stars in the rating window

Bug #855696 reported by Dave Morley
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
software-center (Ubuntu)
Confirmed
Medium
Matthew McGowan

Bug Description

software-center 4.1.23.3, Ubuntu 11.10

In the older gtk2 version you could tab to the stars in the rating window and then hit space to select or tab to move on, this functionality is missing in the newer gtk3 version.

Design guidance from mpt: That sounds like a job for arrow keys. Analogous to a slider.

Revision history for this message
Dave Morley (davmor2) wrote :
description: updated
description: updated
Changed in software-center (Ubuntu):
assignee: nobody → Matthew McGowan (mmcg069)
Revision history for this message
Matthew McGowan (mmcg069) wrote :

hi mpt. did some work on this (see linked branch). the keynav interactions will need some testing. i know the star visually is prob not quite what you are after but i think it will do for now.

Changed in software-center (Ubuntu):
status: New → In Progress
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Matthew, that's a big improvement, and probably landable by itself. Thank you.

The next step would be a focus ring around the whole stars widget, so you can tell that it's focused even before any stars are filled.

In <https://wiki.ubuntu.com/SoftwareCenter/RatingsAndReviews#reviews-reviewing> I also suggested hooking up the 1, 2, 3, 4, and 5 keys.

Changed in software-center (Ubuntu):
importance: Undecided → Medium
tags: added: a11y
Revision history for this message
Matthew McGowan (mmcg069) wrote :

1,2,3,4,5 keys are now hooked up. as for focus i have made the stars border go orange when focus. or would you still prefer a focus ring around the whole idget.

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Good work on the number keys. As for the arrow keys, I think it makes more sense for the star widget to behave like a slider than a menu. So rather than the stars being items that you highlight and then activate with Space/Enter, they should be values that you change immediately with Left and Right. Does that seem reasonable?

If so, effectively it is the whole widget being focused, not individual stars, so the focus ring should be around the whole set of stars, like it is around a GTK slider.

Revision history for this message
dino99 (9d9) wrote :

That version is no more maintained

Changed in software-center (Ubuntu):
status: In Progress → Invalid
Changed in software-center (Ubuntu):
status: Invalid → Confirmed
description: updated
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.