Incorrect use of context managers causes FTBFS on buildds
Bug #1256947 reported by
Barry Warsaw
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu system image |
Fix Released
|
Critical
|
Barry Warsaw | ||
| system-image (Ubuntu) |
Fix Released
|
Critical
|
Barry Warsaw | ||
Bug Description
2.0 is FTBFS on trusty-proposed due to test suite failures that are unreproducible in local sbuilds. The test failure occurs both on the main buildd and in ppas:
https:/
Currently working on some PPA builds with quilt patches to help debug the problem. Due to PPA turnaround time, this will be slow going.
Revision history for this message
| Barry Warsaw (barry) wrote | #1 |
| summary: |
- FTBFS on buildds + Incorrect use of context managers causes FTBFS on buildds |
| Changed in ubuntu-system-image: | |
| status: | New → In Progress |
| importance: | Undecided → Critical |
| assignee: | nobody → Barry Warsaw (barry) |
| tags: | added: client |
| Changed in ubuntu-system-image: | |
| milestone: | none → 2.0.2 |
| Changed in ubuntu-system-image: | |
| status: | In Progress → Fix Committed |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #2 |
| Changed in system-image (Ubuntu): | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
Michael Foord identified the problem. I am incorrectly interleaving unittest.mock.patch calls which get unwound in the wrong order. On local builds, the tests are run in an order which does not trigger this problem, but I guess fortunately, the buildds run the tests in a different order and the problem becomes evident. Fortunately, it's an easy fix - don't interleave the patch calls.