VirtualBox references are outdated

Bug #1170503 reported by Jackson Doak
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
testdrive (Ubuntu)
Fix Released
Low
Jackson Doak

Bug Description

the virtualbox version checking code in testdrive is outdated.
it should reference versions up to 4.2, but only goes to 4.1, 4.0 or 3.1, depending on the part of the code

currently it is:
# Code to validate if virtualization is installed/supported
    def validate_virt(self):
        # Determine which version of VirtualBox we have installed. What is returned is
        # typically a string such as '3.1.0r55467', lets assume that the command line
        # is consistent within 3.1.x, 3.2.x and 4.0.x versions extract this part of the
        # version string for comparison later
        self.vboxversion = commands.getoutput("VBoxManage --version")
        self.vboxversion = ( int(self.vboxversion.split(".")[0]), int(self.vboxversion.split(".")[1]) )
        if self.vboxversion == (3,1) or self.vboxversion == (3,2) or self.vboxversion == (4,0) or self.vboxversion == (4,1) or self.vboxversion == (4,2):
            #info("VirtualBox %s detected." % self.vboxversion)
            print "INFO: VirtualBox %s.%s detected." % self.vboxversion
        else:
            #error("Unsupported version (%s) of VirtualBox; please install v3.0 or v3.1." % self.vboxversion)
            print "ERROR: Unsupported version (%s.%s) of VirtualBox; please install v3.1, v3.2, v4.0 or v4.1." % self.vboxversion
            exit(0)

ProblemType: Bug
DistroRelease: Ubuntu 12.10
Package: testdrive 3.16-0ubuntu1
ProcVersionSignature: Ubuntu 3.5.0-27.46-generic 3.5.7.7
Uname: Linux 3.5.0-27-generic x86_64
NonfreeKernelModules: nvidia
ApportVersion: 2.6.1-0ubuntu10
Architecture: amd64
Date: Fri Apr 19 07:23:46 2013
InstallationDate: Installed on 2013-01-07 (101 days ago)
InstallationMedia: Xubuntu 12.10 "Quantal Quetzal" - Release amd64 (20121017.1)
MarkForUpload: True
PackageArchitecture: all
SourcePackage: testdrive
UpgradeStatus: No upgrade log present (probably fresh install)

Revision history for this message
Jackson Doak (noskcaj) wrote :
Jackson Doak (noskcaj)
Changed in testdrive (Ubuntu):
assignee: nobody → Jackson Doak (doak-jackson)
summary: - virtualbox launching code is outdated
+ VirtualBox references are outdated
Changed in testdrive (Ubuntu):
status: New → Triaged
importance: Undecided → Low
Revision history for this message
Andres Rodriguez (andreserl) wrote :

You need to rebase your branch:

bzr merge lp:testdrive on top of your branch should do it I think.

Revision history for this message
Jackson Doak (noskcaj) wrote : Re: [Bug 1170503] Re: VirtualBox references are outdated

it says "nothing to do"

On Fri, Apr 26, 2013 at 3:44 AM, Andres Rodriguez
<email address hidden>wrote:

> You need to rebase your branch:
>
> bzr merge lp:testdrive on top of your branch should do it I think.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1170503
>
> Title:
> VirtualBox references are outdated
>
> Status in “testdrive” package in Ubuntu:
> Triaged
>
> Bug description:
> the virtualbox version checking code in testdrive is outdated.
> it should reference versions up to 4.2, but only goes to 4.1, 4.0 or
> 3.1, depending on the part of the code
>
> currently it is:
> # Code to validate if virtualization is installed/supported
> def validate_virt(self):
> # Determine which version of VirtualBox we have installed. What
> is returned is
> # typically a string such as '3.1.0r55467', lets assume that the
> command line
> # is consistent within 3.1.x, 3.2.x and 4.0.x versions extract
> this part of the
> # version string for comparison later
> self.vboxversion = commands.getoutput("VBoxManage --version")
> self.vboxversion = ( int(self.vboxversion.split(".")[0]),
> int(self.vboxversion.split(".")[1]) )
> if self.vboxversion == (3,1) or self.vboxversion == (3,2) or
> self.vboxversion == (4,0) or self.vboxversion == (4,1) or self.vboxversion
> == (4,2):
> #info("VirtualBox %s detected." % self.vboxversion)
> print "INFO: VirtualBox %s.%s detected." % self.vboxversion
> else:
> #error("Unsupported version (%s) of VirtualBox; please
> install v3.0 or v3.1." % self.vboxversion)
> print "ERROR: Unsupported version (%s.%s) of VirtualBox;
> please install v3.1, v3.2, v4.0 or v4.1." % self.vboxversion
> exit(0)
>
> ProblemType: Bug
> DistroRelease: Ubuntu 12.10
> Package: testdrive 3.16-0ubuntu1
> ProcVersionSignature: Ubuntu 3.5.0-27.46-generic 3.5.7.7
> Uname: Linux 3.5.0-27-generic x86_64
> NonfreeKernelModules: nvidia
> ApportVersion: 2.6.1-0ubuntu10
> Architecture: amd64
> Date: Fri Apr 19 07:23:46 2013
> InstallationDate: Installed on 2013-01-07 (101 days ago)
> InstallationMedia: Xubuntu 12.10 "Quantal Quetzal" - Release amd64
> (20121017.1)
> MarkForUpload: True
> PackageArchitecture: all
> SourcePackage: testdrive
> UpgradeStatus: No upgrade log present (probably fresh install)
>
> To manage notifications about this bug go to:
>
> https://bugs.launchpad.net/ubuntu/+source/testdrive/+bug/1170503/+subscriptions
>

Jackson Doak (noskcaj)
Changed in testdrive (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.