Ubuntu
ubiquity package

Use persistent device name for vdevs

Bug #1880869 reported by Jean-Baptiste Lallement
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
ubiquity
Unknown
Unknown
ubiquity (Ubuntu)
Fix Released
High
Jean-Baptiste Lallement
Focal
Fix Released
High
Unassigned

Bug Description

[Impact]

 * ZFS pools were created with device names such as /dev/sdX, /dev/vdX,... However, these names are not stable and may change on each reboot, leading to an unbootable system.

 * "zpool create" now uses persistent device names with PARTUUID instead.

[Test Case]

 * After a fresh installation run the following command:
$ zpool status -P
Verify that the device is something like /dev/disk/by-partuuid/<some id>

$ zpool status -PL
Verify that the device is something like /dev/[s,v,h]dX and corresponds to the device selected during installation.

[Regression Potential]

 * Likely low risk of regression. Worst case system doesn't boot after a fresh installation which is better than today because the system may boot but subsequent boots may not.

[Other Info]

 * Already shipped in Groovy

[Original Bug report]

ZFS pools are currently created with device names such as /dev/sdX, /dev/vdX,... However, this name is not stable and may change on each reboot.
"zpool create" must use persistent device names like UUID or PARTUUID instead.

ProblemType: Bug
DistroRelease: Ubuntu 20.10
Package: ubiquity (not installed)
ProcVersionSignature: Ubuntu 5.4.0-18.22-generic 5.4.24
Uname: Linux 5.4.0-18-generic x86_64
NonfreeKernelModules: zfs zunicode zavl icp zcommon znvpair
ApportVersion: 2.20.11-0ubuntu36
Architecture: amd64
CasperMD5CheckResult: skip
CurrentDesktop: ubuntu:GNOME
Date: Wed May 27 13:52:13 2020
InstallCmdLine: file=/cdrom/preseed/ubuntu.seed boot=casper initrd=/casper/initrd.lz quiet splash -- keyboard-configuration/layoutcode=fr keyboard-configuration/variantcode=oss
InstallationDate: Installed on 2014-07-15 (2143 days ago)
InstallationMedia: Ubuntu 14.10 "Utopic Unicorn" - Alpha amd64 (20140520)
SourcePackage: ubiquity
UpgradeStatus: Upgraded to groovy on 2018-03-24 (794 days ago)

See original description

Related branches

~xnox/ubiquity:focal
Ubuntu Stable Release Updates Team: Pending requested
Ubuntu Installer Team: Pending requested
Diff: 28265 lines (+6214/-5241)
140 files modified
bin/ubiquity (+6/-4)
bin/ubiquity-dm (+1/-0)
debian/changelog (+20/-0)
debian/real-po/aa.po (+24/-23)
debian/real-po/ace.po (+20/-20)
debian/real-po/af.po (+53/-34)
debian/real-po/am.po (+20/-20)
debian/real-po/an.po (+19/-17)
debian/real-po/ar.po (+39/-35)
debian/real-po/as.po (+20/-20)
debian/real-po/ast.po (+51/-34)
debian/real-po/az.po (+20/-20)
debian/real-po/be.po (+41/-32)
debian/real-po/bem.po (+20/-20)
debian/real-po/bg.po (+23/-23)
debian/real-po/bn.po (+160/-135)
debian/real-po/bo.po (+180/-126)
debian/real-po/br.po (+26/-25)
debian/real-po/bs.po (+36/-26)
debian/real-po/ca.po (+36/-27)
debian/real-po/ca@valencia.po (+27/-25)
debian/real-po/ce.po (+19/-17)
debian/real-po/ckb.po (+54/-40)
debian/real-po/cs.po (+48/-33)
debian/real-po/csb.po (+26/-24)
debian/real-po/cv.po (+19/-17)
debian/real-po/cy.po (+38/-29)
debian/real-po/da.po (+46/-30)
debian/real-po/de.po (+45/-28)
debian/real-po/dv.po (+19/-17)
debian/real-po/dz.po (+19/-17)
debian/real-po/el.po (+52/-34)
debian/real-po/en_AU.po (+44/-33)
debian/real-po/en_CA.po (+44/-33)
debian/real-po/en_GB.po (+54/-35)
debian/real-po/eo.po (+36/-33)
debian/real-po/es.po (+53/-34)
debian/real-po/et.po (+42/-33)
debian/real-po/eu.po (+55/-39)
debian/real-po/fa.po (+92/-81)
debian/real-po/fi.po (+43/-26)
debian/real-po/fil.po (+28/-26)
debian/real-po/fo.po (+20/-20)
debian/real-po/fr.po (+48/-32)
debian/real-po/fr_CA.po (+40/-32)
debian/real-po/frp.po (+22/-21)
debian/real-po/fy.po (+28/-28)
debian/real-po/ga.po (+20/-20)
debian/real-po/gd.po (+40/-34)
debian/real-po/gl.po (+43/-28)
debian/real-po/gu.po (+30/-26)
debian/real-po/gv.po (+19/-17)
debian/real-po/he.po (+44/-29)
debian/real-po/hi.po (+157/-130)
debian/real-po/hr.po (+58/-42)
debian/real-po/hu.po (+49/-32)
debian/real-po/hy.po (+22/-22)
debian/real-po/ia.po (+40/-31)
debian/real-po/id.po (+57/-39)
debian/real-po/is.po (+32/-30)
debian/real-po/it.po (+52/-35)
debian/real-po/ja.po (+122/-200)
debian/real-po/ka.po (+20/-20)
debian/real-po/kab.po (+20/-20)
debian/real-po/kk.po (+36/-31)
debian/real-po/kl.po (+19/-17)
debian/real-po/km.po (+206/-130)
debian/real-po/kn.po (+35/-32)
debian/real-po/ko.po (+111/-175)
debian/real-po/ku.po (+44/-35)
debian/real-po/kw.po (+26/-25)
debian/real-po/ky.po (+20/-20)
debian/real-po/lb.po (+20/-20)
debian/real-po/lo.po (+19/-17)
debian/real-po/lt.po (+28/-21)
debian/real-po/lv.po (+43/-32)
debian/real-po/mg.po (+20/-20)
debian/real-po/mhr.po (+20/-20)
debian/real-po/mjw.po (+22/-22)
debian/real-po/mk.po (+21/-18)
debian/real-po/ml.po (+58/-45)
debian/real-po/mnw.po (+51/-37)
debian/real-po/mr.po (+142/-123)
debian/real-po/ms.po (+35/-27)
debian/real-po/my.po (+167/-112)
debian/real-po/nb.po (+43/-33)
debian/real-po/nds.po (+19/-17)
debian/real-po/ne.po (+157/-131)
debian/real-po/nl.po (+53/-35)
debian/real-po/nl_NL.po (+19/-18)
debian/real-po/nn.po (+39/-28)
debian/real-po/ny.po (+22/-21)
debian/real-po/oc.po (+59/-38)
debian/real-po/oj.po (+19/-17)
debian/real-po/om.po (+19/-17)
debian/real-po/or.po (+19/-17)
debian/real-po/os.po (+24/-22)
debian/real-po/pa.po (+41/-34)
debian/real-po/pl.po (+48/-36)
debian/real-po/pt.po (+37/-28)
debian/real-po/pt_BR.po (+26/-24)
debian/real-po/ro.po (+27/-24)
debian/real-po/ru.po (+30/-23)
debian/real-po/sa.po (+32/-27)
debian/real-po/sco.po (+20/-20)
debian/real-po/sd.po (+22/-22)
debian/real-po/se.po (+20/-20)
debian/real-po/shn.po (+19/-17)
debian/real-po/si.po (+123/-103)
debian/real-po/sk.po (+26/-25)
debian/real-po/sl.po (+55/-33)
debian/real-po/sn.po (+24/-23)
debian/real-po/sq.po (+36/-29)
debian/real-po/sr.po (+79/-49)
debian/real-po/sv.po (+33/-26)
debian/real-po/sw.po (+19/-17)
debian/real-po/szl.po (+39/-31)
debian/real-po/ta.po (+169/-140)
debian/real-po/ta_LK.po (+23/-23)
debian/real-po/te.po (+156/-114)
debian/real-po/tet.po (+19/-17)
debian/real-po/tg.po (+38/-29)
debian/real-po/th.po (+128/-80)
debian/real-po/tl.po (+21/-18)
debian/real-po/tr.po (+47/-37)
debian/real-po/tt.po (+19/-17)
debian/real-po/ug.po (+37/-36)
debian/real-po/uk.po (+49/-32)
debian/real-po/ur.po (+20/-20)
debian/real-po/uz.po (+38/-35)
debian/real-po/vec.po (+31/-31)
debian/real-po/vi.po (+29/-28)
debian/real-po/wae.po (+19/-17)
debian/real-po/wo.po (+19/-17)
debian/real-po/xh.po (+19/-17)
debian/real-po/zh_CN.po (+66/-101)
debian/real-po/zh_HK.po (+70/-109)
debian/real-po/zh_TW.po (+82/-125)
scripts/zsys-setup (+10/-0)
ubiquity/misc.py (+13/-1)
~jibel/ubiquity:zpool_use_persistent_path
Didier Roche-Tolomelli (community): Approve
Diff: 33 lines (+14/-0)
2 files modified
debian/changelog (+6/-0)
scripts/zsys-setup (+8/-0)
Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :
Changed in ubiquity (Ubuntu):
assignee: nobody → Jean-Baptiste Lallement (jibel)
importance: Undecided → High
status: New → In Progress
Jean-Baptiste Lallement (jibel)
description: updated
Revision history for this message
Brian Murray (brian-murray) wrote :

Would this be worth SRU'ing into 20.04?

Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

Yes this is the plan together with several fixes and enhancements of zsys. The SRU work is in progress.

Revision history for this message
Nicolay Doytchev (lightrush) wrote :

Re: SRUing

I just got hit by this. I'm using a laptop that I added a second disk to. That changed the root disk from /dev/sda to /dev/sdb. The rpool got imported fine so boot succeeded. However silently bpool did not get imported. A couple of kernel updates were done over /boot inside rpool and were not reflected in grub. Effectively kernel became frozen at the time when bpool failed to import. I dug through the zsys-setup file and figured I'd add a couple of lines to convert partrpool and partbpool from /dev/sdx to /dev/disk/by-partuuid. After I did that, I opportunistically decided to check how the current source looks like and I saw almost identical lines were added in https://git.launchpad.net/ubiquity/commit/?id=36ea45160d00c9fd940b6d1b760e7a7b9b652625 by @jibel. :D

So yeah, even though this is an EXPERIMENTAL feature, it would be really nice to avoid this gotcha.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubiquity - 20.10.2

---------------
ubiquity (20.10.2) groovy; urgency=medium

  [ Jean-Baptiste Lallement ]
  * zsys-setup: Use persistent device name for vdevs (LP: #1880869)
  * Only export pools created during installation and containing dataset
    mounted under /target (LP: #1875045)

  [ Dimitri John Ledkov ]
  * Automatic update of included source packages: partman-partitioning
    120ubuntu3. LP: #1796260

 -- Dimitri John Ledkov <email address hidden> Thu, 28 May 2020 22:41:16 +0100

Changed in ubiquity (Ubuntu):
status: In Progress → Fix Released
Dimitri John Ledkov (xnox)
description: updated
Jean-Baptiste Lallement (jibel)
Changed in ubiquity (Ubuntu Focal):
status: New → Triaged
importance: Undecided → High
Jean-Baptiste Lallement (jibel)
description: updated
Jean-Baptiste Lallement (jibel)
description: updated
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Jean-Baptiste, or anyone else affected,

Accepted ubiquity into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ubiquity/20.04.15.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in ubiquity (Ubuntu Focal):
status: Triaged → Fix Committed
tags: added: verification-needed verification-needed-focal
Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

SRU verification for Focal:
I have reproduced the problem with ubiquity 20.04.15 in focal and have verified that the version of ubiquity 20.04.15.1 in -proposed fixes the issue.

Marking as verification-done

Jean-Baptiste Lallement (jibel)
tags: added: verification-done verification-done-focal
removed: verification-needed verification-needed-focal
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubiquity - 20.04.15.1

---------------
ubiquity (20.04.15.1) focal; urgency=medium

  [ Sebastien Bacher ]
  * debian/real-po: updated translations from launchpad, including strings
    from the new subpage for RST (LP: #1874103)

  [ Michael Hudson-Doyle ]
  * make grub_default consider the boot argument in the non-removable case
    (LP: #1847898)

  [ Jean-Baptiste Lallement ]
  * Enable ZFS autotrim (LP: #1883686)
  * Use persistent path for pool's vdevs (LP: #1880869)
  * Do not export all pools (LP: #1875045)

  [ Dimitri John Ledkov ]
  * ubiquity-dm: start gsd-keyboard for keyboard indicator (LP: #1847307)

 -- Dimitri John Ledkov <email address hidden> Tue, 16 Jun 2020 11:17:42 +0100

Changed in ubiquity (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for ubiquity has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.