Icons with full paths don't work
Bug #1623636 reported by
Ted Gould
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| ubuntu-app-launch (Ubuntu) |
Fix Released
|
High
|
Ted Gould | ||
Bug Description
If the icon entry is a full path name, like:
Icon=/usr/
And the app is installed in a Libertine container or UAL is in a Snap we don't add the relative paths needed for those containers. It is always resolved to the root of the host. We need a way to add the container path to those icon paths.
Related branches
lp://qastaging/~ted/ubuntu-app-launch/icon-basepath
- unity-api-1-bot: Approve (continuous-integration)
- Larry Price: Approve
- Unity API Team: Pending requested
-
Diff: 445 lines (+106/-51)8 files modifiedlibubuntu-app-launch/application-impl-click.cpp (+2/-1)
libubuntu-app-launch/application-impl-legacy.cpp (+10/-2)
libubuntu-app-launch/application-impl-libertine.cpp (+16/-8)
libubuntu-app-launch/application-impl-libertine.h (+4/-1)
libubuntu-app-launch/application-impl-snap.cpp (+1/-0)
libubuntu-app-launch/application-info-desktop.cpp (+24/-7)
libubuntu-app-launch/application-info-desktop.h (+2/-0)
tests/application-info-desktop.cpp (+47/-32)
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in ubuntu-app-launch (Ubuntu): | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
This bug was fixed in the package ubuntu-app-launch - 0.9+16.
---------------
ubuntu-app-launch (0.9+16.
* Set a base directory for icons that have a full path specified in
their desktop file (LP: #1623636)
* Don't throw an exception when a Desktop file fails to include an
Icon key (LP: #1617348)
* Switch from g_atexit to std::atexit to avoid deprecation warnings
* Use the --id field for launching with libertine-launch and use it
for setting up other X11 environments
* Ensure we don't check the length of a nullptr array
* Make sure we don't check snapd if we know it won't return useful
results
* Make use of the instance parameter consistent through all the
backends (LP: #1626028)
-- Ted Gould <email address hidden> Mon, 03 Oct 2016 23:55:25 +0000