Ubuntu
ubuntu-settings-components package

Stop build-depending on private Qt headers

Bug #1427991 reported by Timo Jyrinki
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-keyboard (Ubuntu)
New
Undecided
Unassigned
ubuntu-push-qml (Ubuntu)
Fix Released
Undecided
Unassigned
ubuntu-settings-components (Ubuntu)
New
Undecided
Unassigned
ubuntu-system-settings (Ubuntu)
Fix Released
Low
Timo Jyrinki

Bug Description

Your package is build-depending on either qtbase5-private-dev or qtdeclarative5-private-dev, but it does not seem to use any symbols marked as private. Even if it would use private headers, please consider stopping using those since there may be incompatible changes in future Qt versions.

Depend only on the qtbase5-dev and/or qtdeclarative5-dev.

The reason for this bug is to both limit private headers usage and to keep better track of the users.

Related branches

lp://qastaging/~timo-jyrinki/ubuntu-push-qml/drop_private_header_bd
Albert Astals Cid (community): Approve
PS Jenkins bot: Approve (continuous-integration)
Ubuntu Push Hackers: Pending requested
Diff: 14 lines (+0/-2)
1 file modified
debian/control (+0/-2)
lp://qastaging/~timo-jyrinki/ubuntu-system-settings/drop_private_header_bd
Sebastien Bacher (community): Approve
PS Jenkins bot: Approve (continuous-integration)
Diff: 11 lines (+0/-1)
1 file modified
debian/control (+0/-1)
lp://qastaging/ubuntu/vivid-proposed/ubuntu-push-qml
lp://qastaging/ubuntu/vivid-proposed/ubuntu-system-settings
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

I've pushed branches for those that compile just fine without the private headers.

For ubuntu-settings-components and ubuntu-keyboard, is it correct that you're only using the private headers for tests and not anything that gets installed into packages?

That would explain why they are not picking up the flag of using private symbols. You can mark this Won't Fix if you can't get around using the private stuff in tests. And thank you for not using them in the main software!

But if you can find anything in eg. Qt 5.4 to get around your QWindowSystemInterface::registerTouchDevice usage, that would be nice. Or, convincing upstream to make it public. I also found https://bugreports.qt.io/browse/QTBUG-26647 at least.

Sebastien Bacher (seb128)
Changed in ubuntu-system-settings (Ubuntu):
status: New → In Progress
importance: Undecided → Low
assignee: nobody → Timo Jyrinki (timo-jyrinki)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-push-qml - 0.1+15.04.20150312-0ubuntu1

---------------
ubuntu-push-qml (0.1+15.04.20150312-0ubuntu1) vivid; urgency=medium

  [ Roberto Alsina ]
  * Don't leak watchers. (LP: #1425132)

  [ Timo Jyrinki ]
  * Don't build-depend on Qt private header packages. (LP: #1427991)
    (LP: #1427991)
 -- CI Train Bot <email address hidden> Thu, 12 Mar 2015 12:42:28 +0000

Changed in ubuntu-push-qml (Ubuntu):
status: New → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-system-settings - 0.3+15.04.20150317-0ubuntu1

---------------
ubuntu-system-settings (0.3+15.04.20150317-0ubuntu1) vivid; urgency=medium

  [ CI Train Bot ]
  * Resync trunk.

  [ Ken VanDine ]
  * reorder includes to be alphabetical and removed a blank line

  [ Timo Jyrinki ]
  * Don't build-depend on Qt private header packages. (LP: #1427991)
    (LP: #1427991)

  [ jonas-drange ]
  * [sound] show other vibrate setting
 -- CI Train Bot <email address hidden> Tue, 17 Mar 2015 18:02:08 +0000

Changed in ubuntu-system-settings (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.