ActionBar overflow issues with Qt 5.6
Bug #1616858 reported by
Cris Dywan
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
Critical
|
Tim Peeters |
Bug Description
With Qt 5.6 I'm seeing problems with the ActionBar.
1. tst_actionbar.
QWARN : components:
The unit test should be failing. And obviously there's a bug here.
2. Running tst_actionbar.
More information about Qt 5.6 at https:/
Related branches
lp://qastaging/~tpeeters/ubuntu-ui-toolkit/qt56fixes1
- ubuntu-sdk-build-bot: Approve (continuous-integration)
- Cris Dywan: Approve
-
Diff: 77 lines (+34/-2)4 files modifiedsrc/Ubuntu/Components/Themes/Ambiance/1.3/OverflowPanel.qml (+0/-1)
src/Ubuntu/UbuntuToolkit/ucaction.cpp (+8/-0)
tests/unit/components/tst_action.qml (+26/-0)
tests/unit/visual/tst_actionbar.13.qml (+0/-1)
Changed in ubuntu-ui-toolkit (Ubuntu): | |
importance: | Undecided → High |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | New → In Progress |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | In Progress → Fix Committed |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
importance: | High → Critical |
To post a comment you must log in.
This bug was fixed in the package ubuntu-ui-toolkit - 1.3.2104+ 16.10.20160919. 3
--------------- 16.10.20160919. 3) yakkety; urgency=medium
ubuntu-ui-toolkit (1.3.2104+
[ Andrea Bernabei ]
* Scrollbar: more hover related bugfixes and unit tests.
Fixes: LP: #1616868, LP: #1616926
[ Christian Dywan ] rootObject( ) needs to handle QQuickWindow. Fixes: LP: #1617745
* QuickUtils.
* Correctly test and fix trigger override of ComboButton. Fixes: LP: #1614045
[ Zoltan Balogh ]
Increase the top marging when scrolling upwards. Fixes LP: 1618581
[ Timo Jyrinki ]
* Temporarily skip unit tests on xenial while not all MPs to fix Qt 5.6 issues
have landed yet.
[ Michael Terry ]
* Make ActivityIndicator spinner blue instead of orange. Fixes: LP: #1577828.
[ Loïc Molinari ] foo_p.h" or better ), now all the private headers of the UITK can qt_module. prf and the libs using it. build_config) " lines from
alphabetically. QSTRINGBUILDER" line from
UbuntuToolkit. pro since it's done for us by qt_module.prf. deprecated- declarations" WARNINGS" lines from UbuntuToolkit.pro qt_module. prf.
* Changed src/ directory layout. Made the source directory layout consistent
with Qt libs. The C++ libraries have been moved to src/ and the QML modules
to src/imports/. That also makes it easier to differentiate between modules
and libraries since we have a bunch of them now.
* Moved internal tools meant to generate code for the toolkit lib from the QML
module directory to the lib directory where it makes more sense.
* Fixed the build as a Qt submodule.
* Fixed, cleaned up and standardised header inclusions. Apart from the clean
up and the readability improvements, this fixes a bunch of broken private
header inclusions (#include "foo_p.h" in private headers instead of
"private/
be included by the users withour compilation issues. It also removes a bunch
of direct includes from sources and a few INCLUDEPATHs hacks.See the CODING
file for more details.
* Cleaned up ubuntu_
1/ Moved the common config options from the pro files to the prf file to
avoid duplications and simplify the files.
2/ Removed the useless "TEMPLATE=lib" and "load(qt_
the pro files since it's done for us by qt_module.prf.
3/ Use QT= instead of QT*= since it's well defined that by default its
content is "core gui".
4/ Prefixed headers and sources by $$PWD/ and sorted the lines
5/ Merged the SOURCES declarations in UbuntuToolkit.pro.
6/ Removed the useless "DEFINES += QT_USE_
7/ Removed the useless "QMAKE_CXXFLAGS -= -Werror=
and "DEFINES -= QT_DEPRECATED_
since it's already done in ubuntu_
8/ Added a few comments.
* Made use of Qt builtin to check GCC version.
[ Tim Peeters ] Popover after everything is
* Improve the initialization of Action when it gets both iconName and
iconSource from an external component when iconSource is undefined. This
fixes the some times missing overflow button in the ActionBar with Qt 5.6.
I also removed action: modelData from the OverflowPanel because this is
already set automatically in ActionSelection
initia...