popupUtils.open() won't work inside Window with "null" caller
Bug #1617745 reported by
Alberto Mardegan
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Committed
|
High
|
Unassigned | ||
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
High
|
Cris Dywan |
Bug Description
I think I found a regression with popupUtils.open() in rc-proposed (r512 on mako):
I have some code which is invoking a dialog in this way:
PopupUtils.
This now doesn't work, but it works on OTA-12.
This can cause serious regression in third party applications, if dialogs stop appearing.
Furthermore, if I replace "null" with a valid item, things work again but I get a warning on the console:
qml: 'caller' is DEPRECATED. It has no effect.
Which seems wrong, given that in the current stable documentation there is absolutely no mention of the caller property being deprecated.
Related branches
lp://qastaging/~ubuntu-sdk-team/ubuntu-ui-toolkit/quickWindowRootItem
- ubuntu-sdk-build-bot: Approve (continuous-integration)
- Zsombor Egri: Approve
-
Diff: 172 lines (+101/-2)6 files modifiedsrc/Ubuntu/Components/Popups/1.3/popupUtils.js (+5/-0)
src/Ubuntu/UbuntuToolkit/quickutils.cpp (+4/-2)
src/Ubuntu/UbuntuToolkit/quickutils_p.h (+1/-0)
tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/MyDialog.qml (+36/-0)
tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/test_popups.WindowTestCase.qml (+36/-0)
tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/test_popups.py (+19/-0)
Changed in ubuntu-ui-toolkit (Ubuntu): | |
assignee: | nobody → Christian Dywan (kalikiana) |
summary: |
- Regression: popupUtils.open() won't work with "null" caller + popupUtils.open() won't work inside Window with "null" caller |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | Confirmed → In Progress |
importance: | Undecided → High |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | In Progress → Fix Committed |
Changed in canonical-devices-system-image: | |
status: | New → Fix Committed |
importance: | Undecided → High |
milestone: | none → backlog |
To post a comment you must log in.
Dialog.caller is deprecated - if you use PopupUtils.open with a Dialog you will see that warning, as documented in the docs for the Dialog component, and it won't do anything. The same isn't true for Popover.
A test case to demonstrate what "doesn't work" would be needed, it's not obvious from the description.