Ubuntu
ubuntu-ui-toolkit package

Qt5.6: UbuntuListView unit test fails with TypeError

Bug #1624343 reported by Tim Peeters
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-ui-toolkit (Ubuntu)
Fix Committed
Critical
Andrea Bernabei

Bug Description

Failing unit tests with Qt 5.6:

********* Start testing of components *********
Config: Using QtTest library 5.6.1, Qt 5.6.1 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 5.4.0 20160609)
PASS : components::UbuntuListView::initTestCase()
PASS : components::UbuntuListView::test_collapseByClickingOutside()
PASS : components::UbuntuListView::test_collapseOnClick()
PASS : components::UbuntuListView::test_destroyAndRecreateExpanded()
PASS : components::UbuntuListView::test_dimOthers()
PASS : components::UbuntuListView::test_expandedItem()
FAIL! : components::UbuntuListView::test_noScrollingNeeded() Uncaught exception: Type error
   Loc: [/tmp/buildd/ubuntu-ui-toolkit-1.3.2085+16.10.20160831.4/tests/unit/visual/tst_ubuntulistview.10.qml(116)]
FAIL! : components::UbuntuListView::test_scrollIntoView() Uncaught exception: Type error
   Loc: [/tmp/buildd/ubuntu-ui-toolkit-1.3.2085+16.10.20160831.4/tests/unit/visual/tst_ubuntulistview.10.qml(142)]
FAIL! : components::UbuntuListView::test_scrollToTop() Uncaught exception: Type error
   Loc: [/tmp/buildd/ubuntu-ui-toolkit-1.3.2085+16.10.20160831.4/tests/unit/visual/tst_ubuntulistview.10.qml(129)]
PASS : components::UbuntuListView::cleanupTestCase()
Totals: 7 passed, 3 failed, 0 skipped, 0 blacklisted
********* Finished testing of components *********

See https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/1201/consoleFull

Tags: qt5.6

Related branches

lp://qastaging/~faenil/ubuntu-ui-toolkit/fix_ubuntulistview_units_test_qt56
ubuntu-sdk-build-bot: Approve (continuous-integration)
Zsombor Egri: Approve
Cris Dywan: Pending requested
Diff: 41 lines (+5/-5)
1 file modified
tests/unit/visual/tst_ubuntulistview.10.qml (+5/-5)
Tim Peeters (tpeeters)
tags: added: qt5.6
Revision history for this message
Andrea Bernabei (faenil) wrote :

We were previously misusing mapToItem by not passing x/y parameters
and relying on JS to initialize them to 0.

Qt5.6 fixes QTBUG-41686 and requires x/y to be explicitly passed.

Changed in ubuntu-ui-toolkit (Ubuntu):
importance: Undecided → Critical
status: New → In Progress
assignee: nobody → Andrea Bernabei (faenil)
Andrea Bernabei (faenil)
summary: - UbuntuListView TypeErrors
+ Qt5.6: UbuntuListView unit test fails with TypeError
Zsombor Egri (zsombi)
Changed in ubuntu-ui-toolkit (Ubuntu):
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.