Build fails on QT_ASCII_CAST_WARN in QString.replace
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
Critical
|
Cris Dywan |
Bug Description
Something changed, I don't know if it's in UITK, gcc or Qt, but I can no longer build UITK without running into this warning:
./src/UbuntuToo
./src/UbuntuToo
displayTex
In file included from /usr/include/
/usr/include/
inline QT_ASCII_CAST_WARN QString(const char *ch)
./src/UbuntuToo
displayTex
In file included from /usr/include/
/usr/include/
inline QT_ASCII_CAST_WARN QString(const char *ch)
cc1plus: all warnings being treated as errors
Related branches
- ubuntu-sdk-build-bot: Approve (continuous-integration)
- Zsombor Egri: Approve
-
Diff: 12 lines (+1/-1)1 file modifiedsrc/UbuntuToolkit/ucaction.cpp (+1/-1)
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | New → In Progress |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | In Progress → Fix Committed |
This bug was fixed in the package ubuntu-ui-toolkit - 1.3.2135+ 16.10.20161003. 1
--------------- 16.10.20161003. 1) yakkety; urgency=medium
ubuntu-ui-toolkit (1.3.2135+
[ Christian Dywan ] rootItem. Fixes LP: #1586013
* Fix warning about using implicit char* to QString conversion.
* __styleInstance may be null, when doesn't handle that. Fixes LP: #1586013
* Focus ring, arrow keys and space to expand OptionSelector.
Fixes LP: #1514860
* Use QStringLiteral with QString.replace. Fixes LP: #1625507
* Use displayText to determine if the clear button should show.
Fixes LP: #1461571
* && escapes an ampersand used in a mnemonic label. Fixes LP: #1587580
* Try harder to pass an item to QuickUtils.
[ Timo Jyrinki ]
* Enable arm64 unit tests on xenial and newer. Fixes LP: #1580172.
* Add initial snapcraft.yaml
[ Marco Trevisan ]
* UCSlotsLayout: update the size of the element when top/bottom paddings change.
Fixes LP: #1628161
[ Tim Peeters ]
* Ensure that the model in TabBarStyle is a list and not null.
Fixes LP: #1622577.
* Initialize the 'window' context property with null and add MainView 1.3 unit
tests. Fixes LP: #1610231, LP: #1621509, LP: #1625993.
* Fix libpng sRGB profile warnings on Yakkety. Fixes LP: #1625137.
* Disable layouts unit test to work around bug 1625137 on Yakkety.
[ Zsombor Egri ]
* Fix AdaptivePageLayout behavior on Qt5.6. Fixes LP: #1585996.
* Fix property binding restore on theme palette values. Fixes LP: #1570478.
* Move activeFocusOnTab from style into components. Fixes LP: #1590005.
[ Loïc Molinari ] are_errors variable so that it is correctly handled by different deprecated- declarations flag since warnings_are_errors defines it QSTRINGBUILDER lines since it's CXXFLAGS_ WARN_ON instead of QMAKE_CXXFLAGS directly.
* Added public headers extra robustness checks. Made use of the qmake
headersclean feature to check the robustness of our public headers.
* Excluded LTTng features from non-Linux builds.
* Moved common C++ configs to ubuntu_common.prf. The common config file
doesn't add -Werror directly to QMAKE_CXXFLAGS anymore, it sets the
warnings_
compilers (not just GCC). That allows to remove the
-Werror=
for us. Removed the DEFINES += QT_USE_
already handled by qt_module.prf. Set the -Wsuggest-override warning to
QMAKE_
* Cleaned up qmake Ubuntu packaging variables. The qtbase packaging for Ubuntu
exports the CFLAGS, CXXFLAGS and LFLAGS variables in the environment before
running configure so that the qtbase shared libraries can be compiled with
the required distribution defined compiler flags. That is fine (though I
guess that could be handled better at the qtbase packaging level with maybe
a dedicated prf) but it results in qt_build_config.prf defining the
QMAKE_CFLAGS, QMAKE_CXXFLAGS and QMAKE_LFLAGS variables with these
distribution specific flags. Since we load this prf, these variables end up
being defined when building the toolkit for development purpose. This is
problematic because -O2 and -g are always defined (whatever the debug or
release config chosen by the developer), al...