SlotsLayout height is not dynamically updated when main paddings change
Bug #1628161 reported by
Marco Trevisan (Treviño)
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Committed
|
Undecided
|
Unassigned | ||
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
High
|
Marco Trevisan (Treviño) | ||
ubuntu-ui-toolkit (Ubuntu RTM) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
You can see this in the attached testcase.
When paddings are changed, the SlotsLayout height is not updated dynamically.
Related branches
lp://qastaging/~3v1n0/ubuntu-ui-toolkit/slotslayout-paddings-changes-updates-size
- ubuntu-sdk-build-bot: Approve (continuous-integration)
- Andrea Bernabei (community): Approve
-
Diff: 84 lines (+55/-2)2 files modifiedsrc/UbuntuToolkit/ucslotslayout.cpp (+4/-2)
tests/unit/visual/tst_slotslayout.13.qml (+51/-0)
Superseded
for merging
into
lp://qastaging/ubuntu-ui-toolkit
- Ubuntu SDK team: Pending requested
-
Diff: 13938 lines (+3766/-2584)405 files modified.qmake.conf (+12/-12)
CODING (+63/-0)
debian/control (+2/-2)
debian/copyright (+5/-4)
debian/rules (+2/-2)
documentation/docs.sh (+9/-1)
documentation/documentation.pro (+1/-1)
documentation/statesaving.qdoc (+1/-1)
documentation/ubuntu-theming.qdoc (+1/-1)
documentation/ubuntu-ui-toolkit-common.qdocconf (+23/-23)
examples/ubuntu-ui-toolkit-gallery/ProgressBars.qml (+13/-4)
features/ubuntu_common.prf (+53/-0)
features/ubuntu_enable_testing.prf (+1/-1)
features/ubuntu_qml_plugin.prf (+6/-16)
features/ubuntu_qt_module.prf (+18/-18)
snapcraft.yaml (+42/-0)
src/UbuntuGestures/UbuntuGestures.pro (+30/-39)
src/UbuntuGestures/candidateinactivitytimer.cpp (+1/-1)
src/UbuntuGestures/candidateinactivitytimer_p.h (+7/-7)
src/UbuntuGestures/damper.cpp (+2/-1)
src/UbuntuGestures/damper_p.h (+3/-3)
src/UbuntuGestures/debughelpers.cpp (+4/-3)
src/UbuntuGestures/debughelpers_p.h (+5/-7)
src/UbuntuGestures/pool_p.h (+7/-7)
src/UbuntuGestures/timer.cpp (+1/-1)
src/UbuntuGestures/timer_p.h (+9/-9)
src/UbuntuGestures/timesource.cpp (+2/-2)
src/UbuntuGestures/timesource_p.h (+7/-6)
src/UbuntuGestures/touchownershipevent.cpp (+1/-1)
src/UbuntuGestures/touchownershipevent_p.h (+7/-6)
src/UbuntuGestures/touchregistry.cpp (+11/-12)
src/UbuntuGestures/touchregistry_p.h (+9/-11)
src/UbuntuGestures/ubuntugesturesglobal.h (+6/-1)
src/UbuntuGestures/ubuntugesturesmodule.cpp (+3/-2)
src/UbuntuGestures/ubuntugesturesmodule.h (+1/-1)
src/UbuntuGestures/ucswipearea.cpp (+9/-12)
src/UbuntuGestures/ucswipearea_p.h (+5/-9)
src/UbuntuGestures/ucswipearea_p_p.h (+7/-7)
src/UbuntuGestures/unownedtouchevent.cpp (+1/-1)
src/UbuntuGestures/unownedtouchevent_p.h (+8/-7)
src/UbuntuMetrics/UbuntuMetrics.pro (+21/-23)
src/UbuntuMetrics/applicationmonitor.cpp (+3/-2)
src/UbuntuMetrics/applicationmonitor.h (+5/-4)
src/UbuntuMetrics/applicationmonitor_p.h (+6/-4)
src/UbuntuMetrics/bitmaptext.cpp (+5/-3)
src/UbuntuMetrics/bitmaptext_p.h (+2/-1)
src/UbuntuMetrics/events.cpp (+9/-6)
src/UbuntuMetrics/events.h (+1/-1)
src/UbuntuMetrics/events_p.h (+6/-3)
src/UbuntuMetrics/gputimer.cpp (+3/-1)
src/UbuntuMetrics/gputimer_p.h (+3/-1)
src/UbuntuMetrics/logger.cpp (+13/-6)
src/UbuntuMetrics/logger.h (+9/-4)
src/UbuntuMetrics/logger_p.h (+5/-3)
src/UbuntuMetrics/overlay.cpp (+7/-4)
src/UbuntuMetrics/overlay_p.h (+4/-3)
src/UbuntuMetrics/ubuntumetricsglobal.cpp (+34/-0)
src/UbuntuMetrics/ubuntumetricsglobal.h (+1/-1)
src/UbuntuMetrics/ubuntumetricsglobal_p.h (+5/-1)
src/UbuntuToolkit/UbuntuToolkit.pro (+214/-238)
src/UbuntuToolkit/actionlist.cpp (+1/-0)
src/UbuntuToolkit/actionlist_p.h (+6/-5)
src/UbuntuToolkit/adapters/actionsproxy_p.cpp (+5/-4)
src/UbuntuToolkit/adapters/actionsproxy_p.h (+2/-1)
src/UbuntuToolkit/adapters/alarmsadapter_organizer.cpp (+48/-44)
src/UbuntuToolkit/adapters/alarmsadapter_p.h (+7/-6)
src/UbuntuToolkit/adapters/dbuspropertywatcher_p.cpp (+22/-16)
src/UbuntuToolkit/adapters/dbuspropertywatcher_p.h (+1/-1)
src/UbuntuToolkit/alarmmanager_p.cpp (+1/-0)
src/UbuntuToolkit/alarmmanager_p.h (+5/-5)
src/UbuntuToolkit/alarmmanager_p_p.h (+8/-6)
src/UbuntuToolkit/asyncloader_p.h (+5/-4)
src/UbuntuToolkit/asyncloader_p_p.h (+7/-6)
src/UbuntuToolkit/colorutils.cpp (+2/-1)
src/UbuntuToolkit/colorutils_p.h (+8/-6)
src/UbuntuToolkit/exclusivegroup.cpp (+3/-3)
src/UbuntuToolkit/exclusivegroup_p.h (+9/-10)
src/UbuntuToolkit/filterbehavior_p.h (+7/-6)
src/UbuntuToolkit/i18n.cpp (+60/-40)
src/UbuntuToolkit/i18n_p.h (+5/-4)
src/UbuntuToolkit/inversemouseareatype.cpp (+2/-0)
src/UbuntuToolkit/inversemouseareatype_p.h (+8/-6)
src/UbuntuToolkit/label_p.h (+3/-3)
src/UbuntuToolkit/listener.cpp (+1/-1)
src/UbuntuToolkit/listener_p.h (+5/-4)
src/UbuntuToolkit/livetimer_p.cpp (+10/-9)
src/UbuntuToolkit/livetimer_p.h (+8/-7)
src/UbuntuToolkit/livetimer_p_p.h (+7/-7)
src/UbuntuToolkit/menu.cpp (+11/-14)
src/UbuntuToolkit/menu_p.h (+5/-6)
src/UbuntuToolkit/menu_p_p.h (+3/-3)
src/UbuntuToolkit/menubar.cpp (+4/-7)
src/UbuntuToolkit/menubar_p.h (+3/-4)
src/UbuntuToolkit/menubar_p_p.h (+3/-3)
src/UbuntuToolkit/menugroup.cpp (+1/-0)
src/UbuntuToolkit/menugroup_p.h (+4/-4)
src/UbuntuToolkit/mousetouchadaptor.cpp (+5/-6)
src/UbuntuToolkit/mousetouchadaptor_p.h (+5/-5)
src/UbuntuToolkit/mousetouchadaptor_p_p.h (+9/-8)
src/UbuntuToolkit/mousetouchadaptor_x11.cpp (+4/-5)
src/UbuntuToolkit/privates/appheaderbase.cpp (+2/-1)
src/UbuntuToolkit/privates/appheaderbase_p.h (+4/-4)
src/UbuntuToolkit/privates/frame.cpp (+4/-2)
src/UbuntuToolkit/privates/frame_p.h (+5/-4)
src/UbuntuToolkit/privates/listitemdragarea.cpp (+7/-5)
src/UbuntuToolkit/privates/listitemdragarea_p.h (+6/-5)
src/UbuntuToolkit/privates/listitemdraghandler.cpp (+6/-5)
src/UbuntuToolkit/privates/listitemdraghandler_p.h (+5/-4)
src/UbuntuToolkit/privates/listitemselection.cpp (+2/-1)
src/UbuntuToolkit/privates/listitemselection_p.h (+5/-4)
src/UbuntuToolkit/privates/listviewextensions.cpp (+27/-26)
src/UbuntuToolkit/privates/listviewextensions_p.h (+9/-4)
src/UbuntuToolkit/privates/splitviewhandler.cpp (+8/-6)
src/UbuntuToolkit/privates/splitviewhandler_p.h (+6/-5)
src/UbuntuToolkit/privates/threelabelsslot_p.cpp (+2/-1)
src/UbuntuToolkit/privates/threelabelsslot_p.h (+7/-7)
src/UbuntuToolkit/privates/ucpagewrapper.cpp (+6/-5)
src/UbuntuToolkit/privates/ucpagewrapper_p.h (+4/-4)
src/UbuntuToolkit/privates/ucpagewrapper_p_p.h (+8/-7)
src/UbuntuToolkit/privates/ucpagewrapperincubator.cpp (+4/-3)
src/UbuntuToolkit/privates/ucpagewrapperincubator_p.h (+10/-9)
src/UbuntuToolkit/privates/ucscrollbarutils.cpp (+2/-1)
src/UbuntuToolkit/privates/ucscrollbarutils_p.h (+7/-6)
src/UbuntuToolkit/propertychange_p.h (+5/-5)
src/UbuntuToolkit/qquickclipboard.cpp (+2/-1)
src/UbuntuToolkit/qquickclipboard_p.h (+5/-4)
src/UbuntuToolkit/qquickclipboard_p_p.h (+7/-6)
src/UbuntuToolkit/qquickmimedata.cpp (+10/-7)
src/UbuntuToolkit/qquickmimedata_p.h (+6/-5)
src/UbuntuToolkit/quickutils.cpp (+17/-17)
src/UbuntuToolkit/quickutils_p.h (+3/-2)
src/UbuntuToolkit/sortbehavior_p.h (+7/-6)
src/UbuntuToolkit/sortfiltermodel.cpp (+3/-2)
src/UbuntuToolkit/sortfiltermodel_p.h (+8/-7)
src/UbuntuToolkit/splitview.cpp (+5/-6)
src/UbuntuToolkit/splitview_p.h (+1/-1)
src/UbuntuToolkit/splitview_p_p.h (+2/-1)
src/UbuntuToolkit/splitviewlayout.cpp (+3/-3)
src/UbuntuToolkit/statesaverbackend_p.cpp (+17/-14)
src/UbuntuToolkit/statesaverbackend_p.h (+4/-3)
src/UbuntuToolkit/timeutils_p.h (+7/-7)
src/UbuntuToolkit/tree.cpp (+2/-2)
src/UbuntuToolkit/tree_p.h (+8/-7)
src/UbuntuToolkit/ubuntutoolkitglobal.h (+2/-2)
src/UbuntuToolkit/ubuntutoolkitmodule.cpp (+124/-114)
src/UbuntuToolkit/ubuntutoolkitmodule.h (+4/-3)
src/UbuntuToolkit/ucabstractbutton.cpp (+6/-4)
src/UbuntuToolkit/ucabstractbutton_p.h (+6/-5)
src/UbuntuToolkit/ucabstractbutton_p_p.h (+7/-6)
src/UbuntuToolkit/ucaction.cpp (+24/-13)
src/UbuntuToolkit/ucaction_p.h (+7/-6)
src/UbuntuToolkit/ucactioncontext.cpp (+4/-2)
src/UbuntuToolkit/ucactioncontext_p.h (+7/-6)
src/UbuntuToolkit/ucactionitem.cpp (+6/-3)
src/UbuntuToolkit/ucactionitem_p.h (+6/-5)
src/UbuntuToolkit/ucactionitem_p_p.h (+7/-6)
src/UbuntuToolkit/ucactionmanager.cpp (+2/-1)
src/UbuntuToolkit/ucactionmanager_p.h (+5/-4)
src/UbuntuToolkit/ucalarm.cpp (+3/-1)
src/UbuntuToolkit/ucalarm_p.h (+6/-5)
src/UbuntuToolkit/ucalarm_p_p.h (+7/-5)
src/UbuntuToolkit/ucalarmmodel.cpp (+6/-4)
src/UbuntuToolkit/ucalarmmodel_p.h (+5/-4)
src/UbuntuToolkit/ucapplication.cpp (+3/-3)
src/UbuntuToolkit/ucapplication_p.h (+5/-4)
src/UbuntuToolkit/ucargument.cpp (+1/-1)
src/UbuntuToolkit/ucargument_p.h (+5/-4)
src/UbuntuToolkit/ucarguments.cpp (+15/-12)
src/UbuntuToolkit/ucarguments_p.h (+7/-6)
src/UbuntuToolkit/ucbottomedge.cpp (+16/-15)
src/UbuntuToolkit/ucbottomedge_p.h (+6/-5)
src/UbuntuToolkit/ucbottomedge_p_p.h (+8/-7)
src/UbuntuToolkit/ucbottomedgehint.cpp (+15/-10)
src/UbuntuToolkit/ucbottomedgehint_p.h (+7/-6)
src/UbuntuToolkit/ucbottomedgehint_p_p.h (+7/-7)
src/UbuntuToolkit/ucbottomedgeregion.cpp (+4/-3)
src/UbuntuToolkit/ucbottomedgeregion_p.h (+7/-6)
src/UbuntuToolkit/ucbottomedgeregion_p_p.h (+8/-6)
src/UbuntuToolkit/ucbottomedgestyle.cpp (+1/-0)
src/UbuntuToolkit/ucbottomedgestyle_p.h (+5/-4)
src/UbuntuToolkit/ucdefaulttheme.cpp (+16/-16)
src/UbuntuToolkit/ucdefaulttheme_p.h (+6/-5)
src/UbuntuToolkit/ucdeprecatedtheme.cpp (+11/-8)
src/UbuntuToolkit/ucdeprecatedtheme_p.h (+6/-5)
src/UbuntuToolkit/ucfontutils.cpp (+1/-1)
src/UbuntuToolkit/ucfontutils_p.h (+5/-5)
src/UbuntuToolkit/uchaptics.cpp (+6/-3)
src/UbuntuToolkit/uchaptics_p.h (+4/-3)
src/UbuntuToolkit/ucheader.cpp (+5/-3)
src/UbuntuToolkit/ucheader_p.h (+5/-4)
src/UbuntuToolkit/ucimportversionchecker_p.cpp (+3/-3)
src/UbuntuToolkit/ucimportversionchecker_p.h (+3/-2)
src/UbuntuToolkit/ucinversemouse_p.h (+8/-8)
src/UbuntuToolkit/uclabel.cpp (+10/-7)
src/UbuntuToolkit/uclabel_p.h (+8/-7)
src/UbuntuToolkit/uclistitem.cpp (+25/-23)
src/UbuntuToolkit/uclistitem_p.h (+6/-4)
src/UbuntuToolkit/uclistitem_p_p.h (+9/-7)
src/UbuntuToolkit/uclistitemactions.cpp (+6/-4)
src/UbuntuToolkit/uclistitemactions_p.h (+5/-4)
src/UbuntuToolkit/uclistitemactions_p_p.h (+7/-6)
src/UbuntuToolkit/uclistitemlayout.cpp (+3/-2)
src/UbuntuToolkit/uclistitemlayout_p.h (+5/-5)
src/UbuntuToolkit/uclistitemstyle.cpp (+9/-6)
src/UbuntuToolkit/uclistitemstyle_p.h (+6/-4)
src/UbuntuToolkit/ucmainviewbase.cpp (+15/-15)
src/UbuntuToolkit/ucmainviewbase_p.h (+4/-4)
src/UbuntuToolkit/ucmainviewbase_p_p.h (+9/-7)
src/UbuntuToolkit/ucmargins_p.h (+5/-4)
src/UbuntuToolkit/ucmathutils.cpp (+2/-2)
src/UbuntuToolkit/ucmathutils_p.h (+7/-7)
src/UbuntuToolkit/ucmouse_p.h (+8/-8)
src/UbuntuToolkit/ucmousefilters.cpp (+8/-8)
src/UbuntuToolkit/ucpagetreenode.cpp (+13/-13)
src/UbuntuToolkit/ucpagetreenode_p.h (+6/-5)
src/UbuntuToolkit/ucpagetreenode_p_p.h (+8/-6)
src/UbuntuToolkit/ucperformancemonitor.cpp (+1/-0)
src/UbuntuToolkit/ucperformancemonitor_p.h (+7/-6)
src/UbuntuToolkit/ucproportionalshape_p.h (+4/-4)
src/UbuntuToolkit/ucqquickimageextension.cpp (+15/-13)
src/UbuntuToolkit/ucqquickimageextension_p.h (+9/-8)
src/UbuntuToolkit/ucscalingimageprovider.cpp (+2/-2)
src/UbuntuToolkit/ucscalingimageprovider_p.h (+6/-5)
src/UbuntuToolkit/ucserviceproperties.cpp (+8/-6)
src/UbuntuToolkit/ucserviceproperties_p.h (+5/-4)
src/UbuntuToolkit/ucserviceproperties_p_p.h (+6/-5)
src/UbuntuToolkit/ucslotslayout.cpp (+4/-3)
src/UbuntuToolkit/ucslotslayout_p.h (+5/-4)
src/UbuntuToolkit/ucslotslayout_p_p.h (+7/-7)
src/UbuntuToolkit/ucstatesaver.cpp (+13/-10)
src/UbuntuToolkit/ucstatesaver_p.h (+6/-5)
src/UbuntuToolkit/ucstatesaver_p_p.h (+7/-7)
src/UbuntuToolkit/ucstyleditembase.cpp (+8/-6)
src/UbuntuToolkit/ucstyleditembase_p.h (+6/-5)
src/UbuntuToolkit/ucstyleditembase_p_p.h (+8/-6)
src/UbuntuToolkit/ucstylehints.cpp (+9/-6)
src/UbuntuToolkit/ucstylehints_p.h (+7/-6)
src/UbuntuToolkit/uctheme.cpp (+65/-43)
src/UbuntuToolkit/uctheme_p.h (+16/-7)
src/UbuntuToolkit/ucthemingextension.cpp (+8/-5)
src/UbuntuToolkit/ucthemingextension_p.h (+7/-7)
src/UbuntuToolkit/ucubuntuanimation.cpp (+1/-1)
src/UbuntuToolkit/ucubuntuanimation_p.h (+6/-6)
src/UbuntuToolkit/ucubuntushape.cpp (+11/-7)
src/UbuntuToolkit/ucubuntushape_p.h (+13/-10)
src/UbuntuToolkit/ucubuntushapeoverlay_p.h (+3/-3)
src/UbuntuToolkit/ucunits.cpp (+7/-8)
src/UbuntuToolkit/ucunits_p.h (+6/-5)
src/UbuntuToolkit/ucurihandler.cpp (+5/-2)
src/UbuntuToolkit/ucurihandler_p.h (+6/-4)
src/UbuntuToolkit/ucviewitemsattached.cpp (+13/-12)
src/UbuntuToolkit/unitythemeiconprovider.cpp (+17/-13)
src/UbuntuToolkit/unitythemeiconprovider_p.h (+7/-6)
src/UbuntuToolkit/unixsignalhandler_p.cpp (+3/-2)
src/UbuntuToolkit/unixsignalhandler_p.h (+6/-4)
src/imports/Components/1.3/AdaptivePageLayout.qml (+39/-35)
src/imports/Components/1.3/Button.qml (+1/-0)
src/imports/Components/1.3/CheckBox.qml (+1/-0)
src/imports/Components/1.3/ComboButton.qml (+2/-5)
src/imports/Components/1.3/OptionSelector.qml (+60/-1)
src/imports/Components/1.3/OptionSelectorDelegate.qml (+3/-5)
src/imports/Components/1.3/ProgressBar.qml (+4/-2)
src/imports/Components/1.3/Slider.qml (+1/-0)
src/imports/Components/1.3/TextArea.qml (+1/-0)
src/imports/Components/1.3/TextField.qml (+2/-1)
src/imports/Components/1.3/UbuntuListView.qml (+5/-1)
src/imports/Components/Labs/plugin/plugin.pri (+0/-2)
src/imports/Components/ListItems/1.2/ExpandablesColumn.qml (+3/-3)
src/imports/Components/ListItems/1.3/Base.qml (+0/-4)
src/imports/Components/Pickers/1.3/Picker.qml (+1/-1)
src/imports/Components/Pickers/1.3/PickerPanel.qml (+4/-2)
src/imports/Components/Popups/1.3/popupUtils.js (+6/-1)
src/imports/Components/Styles/plugin/plugin.pri (+0/-2)
src/imports/Components/Themes/Ambiance/1.3/ActionBarStyle.qml (+1/-0)
src/imports/Components/Themes/Ambiance/1.3/FocusShape.qml (+0/-7)
src/imports/Components/Themes/Ambiance/1.3/OptionSelectorStyle.qml (+3/-0)
src/imports/Components/Themes/Ambiance/1.3/OverflowPanel.qml (+0/-1)
src/imports/Components/Themes/Ambiance/1.3/PageHeadStyle.qml (+1/-0)
src/imports/Components/Themes/Ambiance/1.3/PageHeaderStyle.qml (+1/-0)
src/imports/Components/Themes/Ambiance/1.3/ProgressBarStyle.qml (+78/-58)
src/imports/Components/Themes/Ambiance/1.3/ScrollbarStyle.qml (+49/-28)
src/imports/Components/Themes/Ambiance/1.3/ScrollingActionBarStyle.qml (+1/-7)
src/imports/Components/Themes/Ambiance/1.3/ToolbarStyle.qml (+1/-0)
src/imports/Components/plugin/plugin.cpp (+5/-4)
src/imports/Components/plugin/plugin.h (+4/-4)
src/imports/Components/plugin/plugin.pri (+3/-8)
src/imports/Components/plugin/ucnamespace.h (+1/-2)
src/imports/Layouts/plugin/plugin.pri (+2/-11)
src/imports/Layouts/plugin/propertychanges.cpp (+5/-4)
src/imports/Layouts/plugin/propertychanges_p.h (+3/-4)
src/imports/Layouts/plugin/ulconditionallayout.cpp (+3/-4)
src/imports/Layouts/plugin/ulconditionallayout.h (+1/-1)
src/imports/Layouts/plugin/ullayouts.cpp (+4/-3)
src/imports/Layouts/plugin/ullayouts.h (+1/-0)
src/imports/Layouts/plugin/ullayouts_p.h (+2/-0)
src/imports/Layouts/plugin/ullayoutsattached.cpp (+2/-2)
src/imports/Layouts/plugin/ulplugin.cpp (+3/-2)
src/imports/Layouts/plugin/ulplugin.h (+4/-5)
src/imports/PerformanceMetrics/plugin/plugin.pri (+0/-3)
src/imports/PerformanceMetrics/plugin/rendertimer.cpp (+2/-1)
src/imports/PerformanceMetrics/plugin/upmcpuusage.cpp (+1/-0)
src/imports/PerformanceMetrics/plugin/upmcpuusage.h (+4/-2)
src/imports/PerformanceMetrics/plugin/upmgraphmodel.cpp (+2/-1)
src/imports/PerformanceMetrics/plugin/upmplugin.cpp (+5/-4)
src/imports/PerformanceMetrics/plugin/upmplugin.h (+4/-5)
src/imports/PerformanceMetrics/plugin/upmrenderingtimes.cpp (+2/-1)
src/imports/PerformanceMetrics/plugin/upmrenderingtimes.h (+5/-4)
src/imports/PerformanceMetrics/plugin/upmtexturefromimage.cpp (+2/-1)
src/imports/Test/Test.pro (+1/-0)
src/imports/Test/plugin/plugin.pri (+2/-5)
src/imports/Test/plugin/testplugin.cpp (+4/-2)
src/imports/Test/plugin/testplugin.h (+1/-1)
src/imports/Test/plugin/uctestcase.cpp (+2/-2)
src/imports/Test/plugin/uctestcase.h (+4/-4)
src/imports/Test/plugin/uctestextras.cpp (+7/-8)
src/imports/Test/plugin/uctestextras.h (+3/-3)
src/src.pro (+21/-21)
sync.profile (+3/-3)
tests/api/Extinct/Animals/plugin/pangaea.h (+3/-3)
tests/api/Extinct/Animals/plugin/plugin.cpp (+6/-5)
tests/api/Extinct/Animals/plugin/plugin.h (+3/-3)
tests/api/Extinct/Animals/plugin/plugin.pri (+1/-4)
tests/api/Extinct/Animals/plugin/rune.cpp (+2/-3)
tests/api/Extinct/Animals/plugin/rune.h (+5/-5)
tests/api/Extinct/Animals/plugin/smilodon.h (+3/-3)
tests/api/Extinct/Animals/plugin/tarpan.h (+3/-3)
tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_flickable.py (+1/-1)
tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/MyDialog.qml (+36/-0)
tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/test_popups.WindowTestCase.qml (+36/-0)
tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/test_popups.py (+19/-0)
tests/unit/alarms/tst_alarms.cpp (+10/-11)
tests/unit/animator/tst_animator.cpp (+7/-8)
tests/unit/animator/tst_animator.qml (+1/-1)
tests/unit/argument/tst_argument.cpp (+2/-3)
tests/unit/arguments/tst_arguments.cpp (+7/-8)
tests/unit/asyncloader/tst_asyncloader.cpp (+5/-4)
tests/unit/bottomedge/tst_bottomedge.cpp (+10/-10)
tests/unit/components/FIXME-QT56_pagestack_deprecated_toolbar.qml (+2/-0)
tests/unit/components/tst_action.qml (+26/-0)
tests/unit/components/tst_components.cpp (+3/-2)
tests/unit/components_benchmark/tst_components_benchmark.cpp (+5/-5)
tests/unit/custom_qpa/main.cpp (+1/-1)
tests/unit/custom_qpa/qcustombackingstore.cpp (+5/-5)
tests/unit/custom_qpa/qcustombackingstore.h (+2/-2)
tests/unit/custom_qpa/qcustomintegration.cpp (+6/-6)
tests/unit/custom_qpa/qcustomintegration.h (+2/-2)
tests/unit/deprecated_theme_engine/tst_deprecated_theme_engine.cpp (+4/-4)
tests/unit/i18n/LocalizedApp/src/tst_i18n_LocalizedApp.cpp (+15/-17)
tests/unit/i18n/RelativeTime/src/tst_i18n_RelativeTime.cpp (+15/-18)
tests/unit/iconprovider/tst_iconprovider.cpp (+0/-1)
tests/unit/inversemousearea/tst_inversemouseareatest.cpp (+7/-8)
tests/unit/layout_dependency.pri (+1/-1)
tests/unit/layouts/tst_layouts.cpp (+10/-13)
tests/unit/mainview/tst_mainview.cpp (+14/-14)
tests/unit/mousefilters/tst_mousefilterstest.cpp (+9/-11)
tests/unit/orientation/tst_orientation.cpp (+8/-9)
tests/unit/page/tst_page.cpp (+4/-4)
tests/unit/performance/tst_performance.cpp (+3/-4)
tests/unit/plugin_dependency.pri (+2/-1)
tests/unit/qmltemplate/tst_qmltemplate.cpp (+3/-2)
tests/unit/qquick_image_extension/tst_qquick_image_extension.cpp (+3/-5)
tests/unit/quickutils/tst_quickutils.cpp (+3/-3)
tests/unit/recreateview/tst_recreateview.cpp (+2/-3)
tests/unit/serviceproperties/tst_serviceproperties.cpp (+5/-5)
tests/unit/statesaver/tst_statesaver.cpp (+16/-16)
tests/unit/subtheming/tst_subtheming.cpp (+9/-9)
tests/unit/swipearea/GestureTest.cpp (+8/-9)
tests/unit/swipearea/GestureTest.h (+7/-9)
tests/unit/swipearea/tst_swipearea.cpp (+7/-9)
tests/unit/test-include.pri (+1/-3)
tests/unit/test/tst_test.cpp (+3/-2)
tests/unit/testparser/main.cpp (+7/-8)
tests/unit/theme/tst_theme.cpp (+3/-2)
tests/unit/touchregistry/touchregistry.pro (+1/-1)
tests/unit/touchregistry/tst_TouchRegistry.cpp (+4/-4)
tests/unit/tree/tst_tree.cpp (+2/-3)
tests/unit/ubuntu_shape/tst_ubuntu_shape.cpp (+2/-2)
tests/unit/units/scale/tst_units_scale.cpp (+1/-2)
tests/unit/units/units.pro (+2/-2)
tests/unit/visual/FIXME-QT56_listitem.12.qml (+1/-0)
tests/unit/visual/FIXME-QT56_listitem.13.qml (+1/-0)
tests/unit/visual/FIXME-QT56_listitem_focus.13.qml (+1/-0)
tests/unit/visual/FIXME-QT56_pagehead_sections_bug1511839.13.qml (+2/-0)
tests/unit/visual/FIXME-QT56_sections.13.qml (+1/-0)
tests/unit/visual/FIXME-QT56_textarea.11.qml (+1/-0)
tests/unit/visual/FIXME-QT56_textfield.11.qml (+1/-0)
tests/unit/visual/ScrollbarTestCase13.qml (+3/-0)
tests/unit/visual/tabsmodel.cpp (+0/-1)
tests/unit/visual/tabsmodel.h (+2/-3)
tests/unit/visual/tst_actionbar.13.qml (+1/-1)
tests/unit/visual/tst_adaptivepagelayout_configuration.13.qml (+4/-4)
tests/unit/visual/tst_expandables.11.qml (+2/-0)
tests/unit/visual/tst_expandablescolumn.11.qml (+5/-5)
tests/unit/visual/tst_focus.13.qml (+33/-3)
tests/unit/visual/tst_listitem_focus_bug.13.qml (+81/-0)
tests/unit/visual/tst_listitem_horizontal_navigation.13.qml (+66/-0)
tests/unit/visual/tst_optionselector.13.qml (+190/-0)
tests/unit/visual/tst_scrollbar.13.qml (+242/-129)
tests/unit/visual/tst_scrollbar_header.13.qml (+2/-1)
tests/unit/visual/tst_shortcuts.13.qml (+3/-3)
tests/unit/visual/tst_slotslayout.13.qml (+26/-0)
tests/unit/visual/tst_ubuntulistview.10.qml (+6/-5)
tests/unit/visual/tst_visual.cpp (+3/-3)
ubuntu-sdk.pro (+1/-0)
ubuntu-ui-toolkit-launcher/launcher.cpp (+4/-2)
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | In Progress → Fix Committed |
Changed in canonical-devices-system-image: | |
status: | New → Fix Committed |
To post a comment you must log in.
Here is a report of my investigation and my chat with Marco this afternoon:
The problem is topChanged and bottomChanged are connected to _q_relayout().
The relayout function does the relayout of the element, it doesn't update the height of the layout.
They should instead trigger _q_updateSize(), that will call _q_relayout() after updating the size.
There were already functionality and unit tests in place that ensure that the height is updated whenever the slot-specific paddings change.
There was a test checking that having the "global" top/bottom padding *initialized* to a *custom* value would produce a layout with the correct height, but there was no test checking that *changing
* the global padding *after* initialization would update the layout height.
Well spotted, and sorry for the inconvenience, Marco!
Thanks a ton for the fix and the unit test! :)