Ubuntu
unity-scopes-api package

JSON format for Variant encoding uses system locale for doubles

Bug #1360247 reported by Pete Woods
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
unity-scopes-api (Ubuntu)
Fix Released
Low
Michi Henning

Bug Description

e.g. Variant(1.23).serialize_json() is going to give you different results depending on your system locale setting.

This seems highly risky to use in any situation where the result could either be saved to disk (and then the system locale is changed) or if two different machines with different locales were communicating.

Related branches

lp://qastaging/~michihenning/unity-scopes-api/ditch-jsoncpp
Marcus Tomlinson (community): Approve
PS Jenkins bot (community): Approve (continuous-integration)
Diff: 2049 lines (+1126/-423)
18 files modified
CMakeLists.txt (+3/-3)
debian/control.in (+1/-1)
include/unity/scopes/internal/JsonCppNode.h (+17/-10)
include/unity/scopes/internal/JsonNodeInterface.h (+2/-3)
include/unity/scopes/internal/JsonSettingsSchema.h (+1/-1)
include/unity/scopes/internal/gobj_memory.h (+212/-0)
src/scopes/internal/JsonCppNode.cpp (+279/-200)
src/scopes/internal/JsonSettingsSchema.cpp (+149/-162)
src/scopes/internal/Logger.cpp (+2/-2)
src/scopes/internal/zmq_middleware/StopPublisher.cpp (+1/-1)
src/scopes/testing/ScopeMetadataBuilder.cpp (+1/-3)
test/gtest/scopes/internal/CMakeLists.txt (+1/-0)
test/gtest/scopes/internal/JsonNode/JsonNode_test.cpp (+146/-17)
test/gtest/scopes/internal/JsonSettingsSchema/JsonSettingsSchema_test.cpp (+37/-5)
test/gtest/scopes/internal/SettingsDB/SettingsDB_test.cpp (+4/-4)
test/gtest/scopes/internal/gobj_ptr/CMakeLists.txt (+3/-0)
test/gtest/scopes/internal/gobj_ptr/gobj_ptr_test.cpp (+208/-0)
test/gtest/scopes/internal/smartscopes/SmartScopesClient/SmartScopesClient_test.cpp (+59/-11)
Revision history for this message
Paweł Stołowski (stolowski) wrote :

This is an issue of the underlying jsoncpp - see http://sourceforge.net/p/jsoncpp/bugs/43/

Changed in unity-scopes-api:
status: New → Confirmed
Michi Henning (michihenning)
affects: unity-scopes-api → unity-scopes-api (Ubuntu)
Revision history for this message
Michi Henning (michihenning) wrote :

Setting this to low priority because we are defenseless against this bug.

Changed in unity-scopes-api (Ubuntu):
importance: Undecided → Low
Revision history for this message
Michi Henning (michihenning) wrote :

Apparently, this is fixed in version 0.8.* and 1.4.*. (Currently, the archives provide 0.6.0.

https://github.com/open-source-parsers/jsoncpp/commit/496c6555239e90f995bbb09ad48e17afa8058719

Michi Henning (michihenning)
Changed in unity-scopes-api (Ubuntu):
assignee: nobody → Michi Henning (michihenning)
status: Confirmed → In Progress
Revision history for this message
Michi Henning (michihenning) wrote :

I just tried with version 1.6.5-4. Unfortunately, it's still broken. When the locale is set to de_DE.utf8, it serializes correctly now, but it no longer parses "10.5" and, instead, comes back with '10.5' is not a number.' :-(

I've opened a bug here:

https://github.com/open-source-parsers/jsoncpp/issues/439

Changed in unity-scopes-api (Ubuntu):
assignee: Michi Henning (michihenning) → nobody
status: In Progress → Confirmed
Michi Henning (michihenning)
Changed in unity-scopes-api (Ubuntu):
assignee: nobody → Michi Henning (michihenning)
status: Confirmed → In Progress
Michi Henning (michihenning)
Changed in unity-scopes-api (Ubuntu):
status: In Progress → Fix Committed
Michi Henning (michihenning)
Changed in unity-scopes-api (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.