Ubuntu
unity package

Calling EndSessionDialog.Open(Restart) opens the dialog with a focused 'Shutdown' button

Bug #1250262 reported by Sam Walters
194
This bug affects 59 people
Affects Status Importance Assigned to Milestone
Session Menu
Invalid
Undecided
Unassigned
Unity
Triaged
Medium
Unassigned
Unity 7.4.0
7.2
Triaged
Medium
Unassigned
Unity 7.2.6
unity (Ubuntu)
Triaged
Medium
Unassigned
Nominated for Xenial by Marco Trevisan (Treviño)

Bug Description

Ubuntu 13.10.

Selecting the power-cog > restart should result in the popup highlighting/pre-selecting Restart so users only have to hit Enter.

Presently users who select "Restart" from the power-cog menu have to then use the cursor keys to actually select "Restart" else a shutdown will occur.

It makes no sense to put "Restart" in the power-cog menu only to have the popup that appears highlight "Shutdown"

Revision history for this message
Arthur Tan (artgtan) wrote :

I've proposed something similar here:

https://bugs.launchpad.net/bugs/1169763

Andrea Azzarone (azzar1)
Changed in unity:
status: New → Triaged
Changed in unity (Ubuntu):
status: New → Confirmed
Changed in unity:
importance: Undecided → Medium
milestone: none → 7.2.0
Andrea Azzarone (azzar1)
Changed in unity:
assignee: nobody → Andrea Azzarone (andyrock)
Changed in unity (Ubuntu):
assignee: nobody → Andrea Azzarone (andyrock)
Changed in unity:
status: Triaged → In Progress
status: In Progress → Won't Fix
Changed in unity (Ubuntu):
status: Confirmed → In Progress
Changed in unity:
status: Won't Fix → In Progress
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

No restart menu item should ever shown in the power indicator menu. So, unity is not wrong here.

Andrea Azzarone (azzar1)
Changed in unity:
status: In Progress → Triaged
Changed in unity (Ubuntu):
status: In Progress → Confirmed
Changed in unity:
assignee: Andrea Azzarone (andyrock) → nobody
Changed in unity (Ubuntu):
assignee: Andrea Azzarone (andyrock) → nobody
Revision history for this message
Graeme Hewson (ghewson) wrote :

Also affects Trusty 14.04, which will be LTS.

tags: added: trusty
Alberto Salvia Novella (es20490446e)
Changed in unity (Ubuntu):
status: Confirmed → Triaged
importance: Undecided → Medium
Changed in indicator-session:
status: New → Confirmed
Revision history for this message
Charles Kerr (charlesk) wrote :

> No restart menu item should ever shown in the power indicator menu. So, unity is not wrong here.

I believe Sam is referring to indicator-session, which uses the system-devices-panel.svg icon that looks like a cog.

Revision history for this message
Charles Kerr (charlesk) wrote :

This isn't an indicator-session bug. Unity's popup gives focus to the Shutdown button even when the client specifies Reboot.

From UnityCore/GnomeSessionManagerImpl.h:

> enum class Action : unsigned {
> LOGOUT = 0,
> SHUTDOWN,
> REBOOT,
> NONE
> };

So calling org.gnome.SessionManager.EndSessionDialog.Open with an action type of '2' to correspond with the REBOOT enum should give focus to the dialog's Restart button, but doesn't. Repeatable by invoking from outside indicator-session w/dbus-send:

> dbus-send --print-reply --dest="org.gnome.Shell" /org/gnome/SessionManager/EndSessionDialog org.gnome.SessionManager.EndSessionDialog.Open uint32:2 uint32:0 uint32:60 array:objpath:

Changed in indicator-session:
status: Confirmed → Invalid
summary: - Selecting power-cog > restart lands highlight on "shutdown"
+ Calling org.gnome.SessionManager.EndSessionDialog.Open() with an action
+ of 'Restart' opens the dialog with focus incorrectly on the 'Shutdown'
+ button
summary: - Calling org.gnome.SessionManager.EndSessionDialog.Open() with an action
- of 'Restart' opens the dialog with focus incorrectly on the 'Shutdown'
- button
+ Calling EndSessionDialog.Open(Restart) opens the dialog with a focused
+ 'Shutdown' button
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

The problem here is that we need to fix gnome-session before...

See https://bugs.launchpad.net/indicator-session/+bug/1156566/comments/8

Changed in unity:
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
Revision history for this message
Kevin (wittyman37) wrote :

Trusty 14.04 is set to release April 26th and this is still an issue. Perhaps the easiest solution would be to remove the restart option from that menu and rename "Shutdown..." to "Restart/Shutdown..." or "Power Off...". While this is not a security issue or performance drain, it is something every user will notice right away. I feel that an LTS release should have these sorts of things very polished and clear.

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

As I explained in bug 1156566, the session menu is not the only place that offers restart: Software Updater and Software & Updates settings do as well, and maybe other places I don't know about. So just removing the menu item wouldn't solve the problem. The problem is in Unity.

Stephen M. Webb (bregma)
Changed in unity:
milestone: 7.2.0 → 7.2.1
Revision history for this message
Marcos Alano (mhalano) wrote :

Ubuntu 14.04 fresh install don't show Restart option, but after some package installations (sorry I can't map this) the "Restart button re-appears.

Stephen M. Webb (bregma)
Changed in unity:
milestone: 7.2.1 → 7.2.2
Marco Trevisan (Treviño) (3v1n0)
Changed in unity:
milestone: 7.2.2 → 7.2.3
Marco Trevisan (Treviño) (3v1n0)
Changed in unity:
milestone: 7.2.3 → 7.3.1
Stephen M. Webb (bregma)
Changed in unity:
milestone: 7.3.1 → 7.3.2
Stephen M. Webb (bregma)
Changed in unity:
milestone: 7.3.2 → 7.3.3
Marco Trevisan (Treviño) (3v1n0)
tags: added: rls-w-incoming
Marco Trevisan (Treviño) (3v1n0)
Changed in unity:
milestone: 7.3.3 → 7.4.0
Marco Trevisan (Treviño) (3v1n0)
tags: added: rls-x-incoming
removed: rls-w-incoming
Marco Trevisan (Treviño) (3v1n0)
tags: added: shutdown-dialgue
Changed in unity:
assignee: Marco Trevisan (Treviño) (3v1n0) → Andrea Azzarone (azzar1)
Revision history for this message
Colin Law (colin-law) wrote :

@Marco, did you mean to mis-spell dialogue in the tag you just added? If it is of no consequence then sorry for the noise.

Marco Trevisan (Treviño) (3v1n0)
Changed in unity (Ubuntu):
assignee: nobody → Andrea Azzarone (azzar1)
Marco Trevisan (Treviño) (3v1n0)
tags: added: unity-backlog
Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

This bug hits Wily and Xenial.

(The restart option was disabled in Precise and Trusty, but it's available now in Wily and Xenial)

Revision history for this message
Marcos Alano (mhalano) wrote :

This problem still occurs on Zesty.

Andrea Azzarone (azzar1)
Changed in unity:
assignee: Andrea Azzarone (azzar1) → nobody
Changed in unity (Ubuntu):
assignee: Andrea Azzarone (azzar1) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.