Applications using client-side decorations are not resizable in Unity
Bug #1276177 reported by
Lars Karlitski
This bug affects 8 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu theme |
In Progress
|
Medium
|
Leo Iannacone | ||
Unity |
Fix Released
|
Medium
|
Marco Trevisan (Treviño) | ||
7.2 |
Fix Released
|
Medium
|
Unassigned | ||
unity (Ubuntu) |
Fix Released
|
Medium
|
Marco Trevisan (Treviño) | ||
Trusty |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[ Impact ]
GNOME applications that use client-side decorations can't be resized on Unity. I think it's because the frame extents hint is not supported.
gnome-clocks and gnome-tweak-tool are two apps in the archive that have this problem.
[ Test Case ]
Run one of the abovementioned applications. Their windows should be resizable.
[ Regression Potential ]
Any modifications to the Unity desktop shell could potentially introduce new crashes or lockups.
[ Other Info ]
The Unity SRU fix for Ubuntu 14.04 LTS was cherry-picked from upstream Unity, where it has been in production use in Ubuntu "Vivid Vervet" dev release for some time without apparent regression.
Related branches
lp://qastaging/~3v1n0/unity/decoration-edges-improvements
- PS Jenkins bot (community): Approve (continuous-integration)
- Brandon Schaefer (community): Approve
-
Diff: 1018 lines (+333/-177)13 files modifiedUnityCore/DesktopUtilities.cpp (+0/-2)
decorations/DecoratedWindow.cpp (+139/-64)
decorations/DecorationsEdgeBorders.cpp (+32/-19)
decorations/DecorationsForceQuitDialog.cpp (+17/-3)
decorations/DecorationsManager.cpp (+16/-25)
decorations/DecorationsPriv.h (+11/-3)
decorations/DecorationsTitle.cpp (+1/-0)
decorations/DecorationsWidgets.cpp (+13/-1)
decorations/DecorationsWidgets.h (+5/-0)
plugins/unityshell/src/unityshell.cpp (+1/-0)
unity-shared/CompizUtils.cpp (+73/-54)
unity-shared/CompizUtils.h (+24/-5)
unity-shared/XWindowManager.cpp (+1/-1)
lp://qastaging/~unity-team/unity/7.2.4
- Marco Trevisan (Treviño): Approve
-
Diff: 6023 lines (+2168/-709)105 files modifiedCMakeLists.txt (+1/-0)
UnityCore/DBusIndicators.cpp (+11/-0)
UnityCore/DBusIndicators.h (+1/-0)
UnityCore/DesktopUtilities.cpp (+12/-0)
UnityCore/DesktopUtilities.h (+1/-0)
UnityCore/GLibDBusProxy.cpp (+100/-3)
UnityCore/GLibDBusProxy.h (+6/-0)
UnityCore/GLibWrapper-inl.h (+12/-0)
UnityCore/GLibWrapper.h (+1/-0)
UnityCore/GnomeSessionManager.cpp (+0/-1)
UnityCore/Indicators.h (+1/-0)
dash/FilterBasicButton.cpp (+6/-3)
dash/previews/ActionButton.cpp (+5/-2)
dash/previews/ErrorPreview.cpp (+1/-0)
dash/previews/PaymentPreview.cpp (+3/-1)
data/CMakeLists.txt (+1/-0)
data/pam/CMakeLists.txt (+1/-0)
data/pam/unity (+2/-0)
debian/changelog (+59/-0)
debian/rules (+1/-1)
debian/unity.install (+1/-0)
debian/unity.migrations (+1/-0)
decorations/DecoratedWindow.cpp (+155/-64)
decorations/DecorationsEdgeBorders.cpp (+32/-19)
decorations/DecorationsForceQuitDialog.cpp (+17/-3)
decorations/DecorationsManager.cpp (+17/-26)
decorations/DecorationsPriv.h (+12/-3)
decorations/DecorationsTitle.cpp (+1/-0)
decorations/DecorationsWidgets.cpp (+13/-1)
decorations/DecorationsWidgets.h (+5/-0)
doc/unity.1 (+35/-10)
hud/HudIconTextureSource.cpp (+0/-5)
hud/HudIconTextureSource.h (+0/-1)
launcher/ApplicationLauncherIcon.cpp (+2/-0)
launcher/DesktopLauncherIcon.cpp (+13/-1)
launcher/DesktopLauncherIcon.h (+2/-0)
launcher/Launcher.cpp (+1/-3)
launcher/LauncherIcon.cpp (+117/-104)
launcher/LauncherIcon.h (+12/-8)
launcher/MockLauncherIcon.h (+0/-5)
launcher/SwitcherView.cpp (+9/-1)
launcher/Tooltip.cpp (+5/-4)
lockscreen/BackgroundSettings.cpp (+13/-11)
lockscreen/BackgroundSettings.h (+0/-1)
lockscreen/CMakeLists.txt (+2/-0)
lockscreen/CofView.cpp (+15/-2)
lockscreen/CofView.h (+3/-1)
lockscreen/LockScreenAbstractShield.h (+14/-1)
lockscreen/LockScreenController.cpp (+54/-14)
lockscreen/LockScreenController.h (+12/-3)
lockscreen/LockScreenPanel.cpp (+31/-2)
lockscreen/LockScreenSettings.cpp (+2/-0)
lockscreen/LockScreenSettings.h (+2/-1)
lockscreen/LockScreenShield.cpp (+60/-29)
lockscreen/LockScreenShield.h (+10/-3)
lockscreen/LockScreenShieldFactory.cpp (+7/-2)
lockscreen/LockScreenShieldFactory.h (+12/-2)
lockscreen/ShutdownNotifier.cpp (+152/-0)
lockscreen/ShutdownNotifier.h (+51/-0)
lockscreen/SuspendNotifier.cpp (+153/-0)
lockscreen/SuspendNotifier.h (+51/-0)
lockscreen/UserAuthenticatorPam.cpp (+1/-2)
lockscreen/UserPromptView.cpp (+96/-17)
lockscreen/UserPromptView.h (+5/-4)
panel/PanelIndicatorEntryView.cpp (+1/-1)
panel/PanelMenuView.cpp (+83/-38)
panel/PanelMenuView.h (+1/-1)
plugins/unityshell/src/unityshell.cpp (+29/-35)
plugins/unityshell/src/unityshell.h (+2/-2)
services/panel-main.c (+8/-0)
services/panel-service.c (+15/-0)
services/panel-service.h (+2/-0)
tests/CMakeLists.txt (+1/-1)
tests/mock_indicators.h (+1/-0)
tests/test_lockscreen_controller.cpp (+10/-2)
tests/test_main_xless.cpp (+4/-5)
tests/test_previews_music_payment.cpp (+1/-0)
tests/test_text_input.cpp (+1/-0)
tools/migration-scripts/03_unity_first_run_stamp_move (+35/-0)
unity-shared/CompizUtils.cpp (+77/-58)
unity-shared/CompizUtils.h (+36/-5)
unity-shared/DashStyle.cpp (+8/-11)
unity-shared/DecorationStyle.cpp (+2/-2)
unity-shared/GnomeKeyGrabber.cpp (+9/-0)
unity-shared/IconRenderer.cpp (+73/-43)
unity-shared/IconRenderer.h (+0/-2)
unity-shared/IconTexture.cpp (+1/-1)
unity-shared/IconTextureSource.cpp (+37/-1)
unity-shared/IconTextureSource.h (+10/-4)
unity-shared/LayoutSystem.cpp (+28/-4)
unity-shared/LayoutSystem.h (+2/-1)
unity-shared/PluginAdapter.cpp (+39/-2)
unity-shared/PluginAdapter.h (+3/-0)
unity-shared/SearchBar.cpp (+18/-12)
unity-shared/SearchBar.h (+9/-9)
unity-shared/SearchBarSpinner.h (+0/-2)
unity-shared/SpreadFilter.cpp (+3/-1)
unity-shared/StandaloneWindowManager.h (+2/-0)
unity-shared/TextInput.cpp (+138/-76)
unity-shared/TextInput.h (+17/-19)
unity-shared/UScreen.cpp (+26/-4)
unity-shared/UScreen.h (+0/-1)
unity-shared/UnitySettings.cpp (+9/-1)
unity-shared/WindowManager.h (+5/-0)
unity-shared/XWindowManager.cpp (+1/-1)
lp://qastaging/~l3on/ubuntu-themes/csd-fix-resize-and-shadow
Ready for review
for merging
into
lp://qastaging/ubuntu-themes
- Ubuntu Artwork Packagers: Pending requested
-
Diff: 118 lines (+50/-4)6 files modifiedAmbiance/gtk-3.0/apps/unity.css (+2/-2)
Ambiance/gtk-3.0/csd.css (+18/-0)
Ambiance/gtk-3.0/gtk-main.css (+5/-0)
Radiance/gtk-3.0/apps/unity.css (+2/-2)
Radiance/gtk-3.0/csd.css (+18/-0)
Radiance/gtk-3.0/gtk-main.css (+5/-0)
Changed in unity (Ubuntu): | |
assignee: | nobody → Marco Trevisan (Treviño) (3v1n0) |
tags: | added: new-decorations |
tags: | added: ubuntugnome-blocker |
Changed in unity: | |
milestone: | none → 7.3.1 |
Changed in unity (Ubuntu): | |
status: | Confirmed → Triaged |
importance: | Undecided → Medium |
Changed in ubuntu-themes: | |
assignee: | nobody → Leo Iannacone (l3on) |
status: | New → In Progress |
importance: | Undecided → High |
importance: | High → Medium |
Changed in unity: | |
importance: | Undecided → Medium |
assignee: | nobody → Marco Trevisan (Treviño) (3v1n0) |
status: | New → In Progress |
Changed in gtk+3.0 (Debian): | |
status: | Unknown → Confirmed |
Changed in unity: | |
status: | In Progress → Fix Committed |
Changed in unity (Ubuntu): | |
status: | Triaged → Fix Released |
Changed in unity (Ubuntu): | |
status: | Fix Released → Invalid |
status: | Invalid → Fix Released |
tags: |
added: verification-done removed: verification-needed |
Changed in unity: | |
status: | Fix Committed → Fix Released |
no longer affects: | gtk+3.0 (Debian) |
To post a comment you must log in.
Status changed to 'Confirmed' because the bug affects multiple users.