Clipboard contents are accessible within lockscreen
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Unity |
Fix Released
|
High
|
Andrea Azzarone | ||
7.2 |
Fix Released
|
High
|
Andrea Azzarone | ||
unity (Ubuntu) |
Fix Released
|
High
|
Andrea Azzarone | ||
Trusty |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[Impact]
It's possible to paste clipboard content into the lockscreen text fields
[Testcase]
1. Copy some text
2. Lock the screen (Super+L or Ctrl+Alt+L)
3. Try to paste the contents of your clipboard using Ctrl+V into the lockscreen input(s)
field.
4. Nothing should be pasted there
[Regression Potential]
Anything known
-------
- Copy e.g. my password to the clipboard (highlight and/or Ctrl+C)
- Lock the screen (Ctrl+Alt+L)
- Paste content from clipboard using middle mouse button or Ctrl+V into input field
- Login possible (if copied text was the password)
Expected behaviour:
No content from clipboard available at all in lockscreen
lsb_release -rd:
Description: Ubuntu 14.04 LTS
Release: 14.04
Related branches
- Marco Trevisan (Treviño): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
- Brandon Schaefer (community): Approve
-
Diff: 53 lines (+10/-0)3 files modifiedlockscreen/UserPromptView.cpp (+1/-0)
unity-shared/IMTextEntry.cpp (+7/-0)
unity-shared/IMTextEntry.h (+2/-0)
- Marco Trevisan (Treviño): Approve
-
Diff: 3472 lines (+1152/-478)54 files modifiedUnityCore/GnomeSessionManager.cpp (+32/-0)
UnityCore/GnomeSessionManagerImpl.h (+4/-0)
UnityCore/SessionManager.h (+4/-0)
dash/DashController.cpp (+3/-1)
debian/changelog (+59/-0)
hud/HudController.cpp (+1/-0)
launcher/AbstractLauncherIcon.h (+3/-2)
launcher/ApplicationLauncherIcon.cpp (+20/-19)
launcher/ApplicationLauncherIcon.h (+0/-1)
launcher/Launcher.cpp (+26/-10)
launcher/LauncherIcon.cpp (+7/-3)
launcher/LauncherIcon.h (+2/-1)
launcher/SwitcherView.cpp (+54/-31)
launcher/SwitcherView.h (+3/-4)
launcher/TrashLauncherIcon.cpp (+1/-0)
launcher/VolumeLauncherIcon.cpp (+1/-0)
lockscreen/LockScreenAbstractShield.h (+0/-1)
lockscreen/LockScreenController.cpp (+2/-3)
lockscreen/LockScreenShield.cpp (+0/-6)
lockscreen/LockScreenShield.h (+0/-1)
lockscreen/UserPromptView.cpp (+8/-99)
lockscreen/UserPromptView.h (+1/-13)
panel/PanelIndicatorEntryView.cpp (+7/-0)
plugins/unityshell/src/GesturalWindowSwitcher.cpp (+3/-0)
plugins/unityshell/src/GesturalWindowSwitcher.h (+1/-0)
plugins/unityshell/src/unityshell.cpp (+57/-50)
plugins/unityshell/src/unityshell.h (+2/-0)
po/POTFILES.in (+1/-0)
po/unity.pot (+70/-3)
shortcuts/ShortcutController.cpp (+4/-6)
shortcuts/ShortcutView.cpp (+113/-48)
shortcuts/ShortcutView.h (+9/-3)
shutdown/SessionButton.cpp (+30/-5)
shutdown/SessionButton.h (+5/-0)
shutdown/SessionController.cpp (+2/-0)
shutdown/SessionView.cpp (+68/-27)
shutdown/SessionView.h (+5/-0)
tests/test-gestures/LockScreenControllerMock.h (+43/-0)
tests/test-gestures/sed_script_switcher (+2/-0)
tests/test-gestures/unityshell_mock.h (+8/-1)
tests/test_lockscreen_controller.cpp (+0/-1)
tests/test_switcher_view.cpp (+1/-2)
tests/test_unity_window_view.cpp (+9/-9)
unity-shared/EMConverter.cpp (+2/-2)
unity-shared/IMTextEntry.cpp (+7/-0)
unity-shared/IMTextEntry.h (+2/-0)
unity-shared/PluginAdapter.cpp (+43/-10)
unity-shared/RawPixel.cpp (+1/-1)
unity-shared/TextInput.cpp (+178/-4)
unity-shared/TextInput.h (+19/-4)
unity-shared/UnityWindowStyle.cpp (+135/-62)
unity-shared/UnityWindowStyle.h (+35/-20)
unity-shared/UnityWindowView.cpp (+53/-25)
unity-shared/UnityWindowView.h (+6/-0)
- Unity Team: Pending requested
-
Diff: 1674 lines (+1380/-30) (has conflicts)7 files modifiedCMakeLists.txt (+5/-0)
ChangeLog (+1162/-0)
debian/changelog (+77/-26)
debian/control (+1/-1)
po/unity.pot (+70/-3)
shutdown/SessionView.cpp (+55/-0)
shutdown/SessionView.h (+10/-0)
Changed in unity: | |
status: | New → Triaged |
Changed in unity (Ubuntu): | |
status: | New → Confirmed |
Changed in unity: | |
importance: | Undecided → Medium |
Changed in unity: | |
milestone: | none → 7.2.1 |
importance: | Medium → High |
Changed in unity (Ubuntu): | |
importance: | Undecided → High |
status: | Confirmed → Triaged |
Changed in unity: | |
assignee: | nobody → Andrea Azzarone (andyrock) |
Changed in unity (Ubuntu): | |
assignee: | nobody → Andrea Azzarone (andyrock) |
Changed in unity: | |
status: | Triaged → In Progress |
Changed in unity (Ubuntu): | |
status: | Triaged → In Progress |
tags: | removed: clipboard unity-greeter |
Changed in unity: | |
milestone: | 7.2.1 → 7.3.0 |
Changed in unity: | |
status: | In Progress → Fix Committed |
Changed in unity: | |
status: | Fix Committed → Fix Released |
description: | updated |
tags: |
added: verification-done removed: verification-needed |
This bug was fixed in the package unity - 7.2.0+14. 10.20140607- 0ubuntu1
--------------- 14.10.20140607- 0ubuntu1) utopic; urgency=low
unity (7.2.0+
[ Chris Townsend ]
* Fix issue where the number of Launcher icon pips are not always
properly updated when a new window of an already running application
is opened. (LP: #1283775)
* Fix issue where the Panel shadow would get drawn over drop down
windows in full screen windows. (LP: #1316005)
[ Andrea Azzarone ] Terminate in ::OnLockScreen (LP: #1320438)
* Clear the clipboard when locking the screen. (LP: #1308911)
* Disable switcher gestures if screen is locked. Fixed a regression.
(LP: #1321043)
* Pass the correct options to showLauncherKey
UnityScreen
* Fix skype indicator blinking. (LP: #1310200)
[ Marco Trevisan (Treviño) ]
* PluginAdapter: try to grab the screen to make sure that the screen
is not grabbed FocusIn event with NotifyGrab mode is not always
triggered by X when a window takes the grab, then we need to ensure
that there's no grab by trying to get one. We only care about
keyboard here, since pointer grabs don't affect us in general. (LP:
#741869)
* ShortcutView: use RawPixel's for the size values and convert them to
match current scaling Plus dinamically allocate horizontal space,
not to cut the text. (LP: #924840)
-- Ubuntu daily release <email address hidden> Sat, 07 Jun 2014 16:27:46 +0000