Ubuntu
unity package

With 2 monitors, after suspending, it is possible to skip the password

Bug #1368427 reported by Gabriel Salles Rousseau Guedes on 2014-09-11

258

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Unity	Fix Released	Critical	Marco Trevisan (Treviño)	Unity 7.3.1
	7.2	Fix Released	Critical	Marco Trevisan (Treviño)	Unity 7.2.4 "14.04 SRU 4"
	unity (Ubuntu)	Fix Released	Critical	Marco Trevisan (Treviño)
Nominated for Trusty by Marco Trevisan (Treviño)

Bug Description

Having a notebook with an extra monitor, after suspending the session, it is possible to skip the password.
My external monitor is connected through VGA, and I am able to reproduce this bug around 70-80% of the time (I don't know if it happens with an HDMI cable).
If I try to reproduce and the bug does not happen, I need to reboot the notebook so it can happen again.
I tried with different resolutions and "rotations" for the monitor and the bug still happens.
The external monitor needs to be configured to be on the left of the notebook, or the bug will not happen.

It is so many steps to make it happen, that I made a short video explaining.

https://www.youtube.com/watch?v=FYzz32K6q10

ps.; The video is "unlisted", so only with the link is accessible.

Description: Ubuntu 14.04.1 LTS
Release: 14.04

ProblemType: Bug
DistroRelease: Ubuntu 14.04
Package: gnome-screensaver 3.6.1-0ubuntu13
ProcVersionSignature: Ubuntu 3.13.0-36.63-generic 3.13.11.6
Uname: Linux 3.13.0-36-generic x86_64
ApportVersion: 2.14.1-0ubuntu3.4
Architecture: amd64
CurrentDesktop: Unity
Date: Thu Sep 11 17:49:57 2014
GnomeSessionIdleInhibited: No
GnomeSessionInhibitors: None
GsettingsGnomeSession:
org.gnome.desktop.session session-name 'ubuntu'
org.gnome.desktop.session idle-delay uint32 1800
InstallationDate: Installed on 2014-04-12 (152 days ago)
InstallationMedia: Ubuntu 14.04 LTS "Trusty Tahr" - Daily amd64 (20140411)
SourcePackage: gnome-screensaver
Symptom: security
Title: Screen locking issue
UpgradeStatus: No upgrade log present (probably fresh install)

Tags:

Related branches

lp://qastaging/~3v1n0/unity/shield-notify-grabs

Merged into lp://qastaging/unity at revision 3878

Andrea Azzarone (community): Approve on 2014-09-22

PS Jenkins bot (community): Approve (continuous-integration) on 2014-09-20

lp://qastaging/~unity-team/unity/7.2.4

Merged into lp://qastaging/unity/7.2 at revision 3806

Marco Trevisan (Treviño): Approve on 2014-12-17

Diff: 6023 lines (+2168/-709)

105 files modified

CMakeLists.txt (+1/-0)
UnityCore/DBusIndicators.cpp (+11/-0)
UnityCore/DBusIndicators.h (+1/-0)
UnityCore/DesktopUtilities.cpp (+12/-0)
UnityCore/DesktopUtilities.h (+1/-0)
UnityCore/GLibDBusProxy.cpp (+100/-3)
UnityCore/GLibDBusProxy.h (+6/-0)
UnityCore/GLibWrapper-inl.h (+12/-0)
UnityCore/GLibWrapper.h (+1/-0)
UnityCore/GnomeSessionManager.cpp (+0/-1)
UnityCore/Indicators.h (+1/-0)
dash/FilterBasicButton.cpp (+6/-3)
dash/previews/ActionButton.cpp (+5/-2)
dash/previews/ErrorPreview.cpp (+1/-0)
dash/previews/PaymentPreview.cpp (+3/-1)
data/CMakeLists.txt (+1/-0)
data/pam/CMakeLists.txt (+1/-0)
data/pam/unity (+2/-0)
debian/changelog (+59/-0)
debian/rules (+1/-1)
debian/unity.install (+1/-0)
debian/unity.migrations (+1/-0)
decorations/DecoratedWindow.cpp (+155/-64)
decorations/DecorationsEdgeBorders.cpp (+32/-19)
decorations/DecorationsForceQuitDialog.cpp (+17/-3)
decorations/DecorationsManager.cpp (+17/-26)
decorations/DecorationsPriv.h (+12/-3)
decorations/DecorationsTitle.cpp (+1/-0)
decorations/DecorationsWidgets.cpp (+13/-1)
decorations/DecorationsWidgets.h (+5/-0)
doc/unity.1 (+35/-10)
hud/HudIconTextureSource.cpp (+0/-5)
hud/HudIconTextureSource.h (+0/-1)
launcher/ApplicationLauncherIcon.cpp (+2/-0)
launcher/DesktopLauncherIcon.cpp (+13/-1)
launcher/DesktopLauncherIcon.h (+2/-0)
launcher/Launcher.cpp (+1/-3)
launcher/LauncherIcon.cpp (+117/-104)
launcher/LauncherIcon.h (+12/-8)
launcher/MockLauncherIcon.h (+0/-5)
launcher/SwitcherView.cpp (+9/-1)
launcher/Tooltip.cpp (+5/-4)
lockscreen/BackgroundSettings.cpp (+13/-11)
lockscreen/BackgroundSettings.h (+0/-1)
lockscreen/CMakeLists.txt (+2/-0)
lockscreen/CofView.cpp (+15/-2)
lockscreen/CofView.h (+3/-1)
lockscreen/LockScreenAbstractShield.h (+14/-1)
lockscreen/LockScreenController.cpp (+54/-14)
lockscreen/LockScreenController.h (+12/-3)
lockscreen/LockScreenPanel.cpp (+31/-2)
lockscreen/LockScreenSettings.cpp (+2/-0)
lockscreen/LockScreenSettings.h (+2/-1)
lockscreen/LockScreenShield.cpp (+60/-29)
lockscreen/LockScreenShield.h (+10/-3)
lockscreen/LockScreenShieldFactory.cpp (+7/-2)
lockscreen/LockScreenShieldFactory.h (+12/-2)
lockscreen/ShutdownNotifier.cpp (+152/-0)
lockscreen/ShutdownNotifier.h (+51/-0)
lockscreen/SuspendNotifier.cpp (+153/-0)
lockscreen/SuspendNotifier.h (+51/-0)
lockscreen/UserAuthenticatorPam.cpp (+1/-2)
lockscreen/UserPromptView.cpp (+96/-17)
lockscreen/UserPromptView.h (+5/-4)
panel/PanelIndicatorEntryView.cpp (+1/-1)
panel/PanelMenuView.cpp (+83/-38)
panel/PanelMenuView.h (+1/-1)
plugins/unityshell/src/unityshell.cpp (+29/-35)
plugins/unityshell/src/unityshell.h (+2/-2)
services/panel-main.c (+8/-0)
services/panel-service.c (+15/-0)
services/panel-service.h (+2/-0)
tests/CMakeLists.txt (+1/-1)
tests/mock_indicators.h (+1/-0)
tests/test_lockscreen_controller.cpp (+10/-2)
tests/test_main_xless.cpp (+4/-5)
tests/test_previews_music_payment.cpp (+1/-0)
tests/test_text_input.cpp (+1/-0)
tools/migration-scripts/03_unity_first_run_stamp_move (+35/-0)
unity-shared/CompizUtils.cpp (+77/-58)
unity-shared/CompizUtils.h (+36/-5)
unity-shared/DashStyle.cpp (+8/-11)
unity-shared/DecorationStyle.cpp (+2/-2)
unity-shared/GnomeKeyGrabber.cpp (+9/-0)
unity-shared/IconRenderer.cpp (+73/-43)
unity-shared/IconRenderer.h (+0/-2)
unity-shared/IconTexture.cpp (+1/-1)
unity-shared/IconTextureSource.cpp (+37/-1)
unity-shared/IconTextureSource.h (+10/-4)
unity-shared/LayoutSystem.cpp (+28/-4)
unity-shared/LayoutSystem.h (+2/-1)
unity-shared/PluginAdapter.cpp (+39/-2)
unity-shared/PluginAdapter.h (+3/-0)
unity-shared/SearchBar.cpp (+18/-12)
unity-shared/SearchBar.h (+9/-9)
unity-shared/SearchBarSpinner.h (+0/-2)
unity-shared/SpreadFilter.cpp (+3/-1)
unity-shared/StandaloneWindowManager.h (+2/-0)
unity-shared/TextInput.cpp (+138/-76)
unity-shared/TextInput.h (+17/-19)
unity-shared/UScreen.cpp (+26/-4)
unity-shared/UScreen.h (+0/-1)
unity-shared/UnitySettings.cpp (+9/-1)
unity-shared/WindowManager.h (+5/-0)
unity-shared/XWindowManager.cpp (+1/-1)

Revision history for this message

Gabriel Salles Rousseau Guedes (gabrielsalles-rg) wrote on 2014-09-11:

Dependencies.txt Edit (7.4 KiB, text/plain; charset="utf-8")
GsettingsGnomeLockdown.txt Edit (492 bytes, text/plain; charset="utf-8")
GsettingsGnomePowerManager.txt Edit (1.5 KiB, text/plain; charset="utf-8")
GsettingsGnomeScreensaver.txt Edit (1.1 KiB, text/plain; charset="utf-8")
ProcEnviron.txt Edit (316 bytes, text/plain; charset="utf-8")
XorgLog.txt Edit (56.8 KiB, text/plain; charset="utf-8")
XorgLogOld.txt Edit (55.3 KiB, text/plain; charset="utf-8")

Revision history for this message

Marco Trevisan (Treviño) (3v1n0) wrote on 2014-09-12:

Thanks for the detailed test case, we'll get a solution ASAP.

affects:	gnome-screensaver (Ubuntu) → unity (Ubuntu)
Changed in unity:
status:	New → Triaged
Changed in unity (Ubuntu):
status:	New → Triaged
Changed in unity:
importance:	Undecided → Critical
Changed in unity (Ubuntu):
importance:	Undecided → Critical
Changed in unity:
assignee:	nobody → Marco Trevisan (Treviño) (3v1n0)
Changed in unity (Ubuntu):
assignee:	nobody → Marco Trevisan (Treviño) (3v1n0)
Changed in unity:
milestone:	none → 7.3.1

Marco Trevisan (Treviño) (3v1n0) on 2014-09-19

Changed in unity:
status:	Triaged → In Progress
Changed in unity (Ubuntu):
status:	Triaged → In Progress

Marco Trevisan (Treviño) (3v1n0) on 2014-10-17

Changed in unity:
status:	In Progress → Fix Committed

Marco Trevisan (Treviño) (3v1n0) on 2014-10-17

Changed in unity (Ubuntu):
status:	In Progress → Fix Released

Revision history for this message

Marco Trevisan (Treviño) (3v1n0) wrote on 2015-01-17:

Hi Gabriel,

The fix has been just backported to ubuntu Trusty proposed channel (debs at http://launchpad.net/ubuntu/+source/unity/7.2.4+14.04.20141217-0ubuntu1), can you please enable that repo (https://wiki.ubuntu.com/Testing/EnableProposed), and verify that this bug has been fixed?

Thanks!

Revision history for this message

Gabriel Salles Rousseau Guedes (gabrielsalles-rg) wrote on 2015-01-18:

Hello!

I tried yesterday night and with more effort this morning to reproduce this bug, but for me the bug is fixed (which is partially sad, because I was using as a feature when I didn't want to type the password =P).

Nice job, Marco!
Thanks! =]

Revision history for this message

Marco Trevisan (Treviño) (3v1n0) wrote on 2015-01-18:

Ahah.. LOL, now you're making me feeling sad cause I removed your loved secret feature... :P

Thanks for your testing!

tags:

added: verification-done

Stephen M. Webb (bregma) on 2015-01-19

information type:

Private Security → Public Security

Revision history for this message

Chris J Arges (arges) wrote on 2015-02-04: Update Released

The verification of the Stable Release Update for unity has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Stephen M. Webb (bregma) on 2015-02-11

Changed in unity:
status:	Fix Committed → Fix Released

Report a bug

This report contains Public Security information

Everyone can see this security related information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Bug attachments

Add attachment

Remote bug watches

Bug watches keep track of this bug in other bug trackers.

Ubuntuunity package

With 2 monitors, after suspending, it is possible to skip the password

Bug Description

Related branches

Other bug subscribers

Bug attachments

Remote bug watches

Ubuntu
unity package