Google Chrome (or chromium with default borders) has no shadows in Unity
Bug #1608418 reported by
Marco Trevisan (Treviño)
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
unity (Ubuntu) |
Fix Released
|
Medium
|
Eleni Maria Stea | ||
Xenial |
Fix Released
|
Medium
|
Unassigned |
Bug Description
[Test case]
1. Open Google Chrome or Chromium
2. Go in chrome://settings/ and ensure that the "Use system titles and borders" checkbox is NOT ticked
Expected:
3. The browser window has shadows
Actual:
3. The window is not shadowed
[Possible regressions]
We tested multiple scenarios and none is known to regress, but there might be double-shadows in some client-side shadowed windows.
Related branches
lp://qastaging/~hikiko/unity/unity.shadows-on-existing-pixmaps
- Marco Trevisan (Treviño): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
- Andrea Azzarone: Pending requested
- Unity Team: Pending requested
-
Diff: 387 lines (+241/-11)8 files modifieddecorations/CMakeLists.txt (+1/-0)
decorations/DecoratedWindow.cpp (+61/-4)
decorations/DecorationsManager.cpp (+27/-0)
decorations/DecorationsPriv.h (+5/-1)
decorations/DecorationsShape.cpp (+102/-0)
decorations/DecorationsShape.h (+43/-0)
plugins/unityshell/src/unityshell.cpp (+1/-1)
unity-shared/CompizUtils.cpp (+1/-5)
lp://qastaging/~3v1n0/unity/shadows-on-existing-pixmaps-cleanup
- Andrea Azzarone (community): Approve
-
Diff: 567 lines (+171/-150)8 files modifieddecorations/DecoratedWindow.cpp (+58/-29)
decorations/DecoratedWindow.h (+1/-0)
decorations/DecorationsManager.cpp (+0/-27)
decorations/DecorationsPriv.h (+5/-3)
decorations/DecorationsShape.cpp (+72/-67)
decorations/DecorationsShape.h (+28/-17)
plugins/unityshell/src/unityshell.cpp (+1/-0)
unity-shared/CompizUtils.cpp (+6/-7)
lp://qastaging/~unity-team/unity/x-sru3
- Andrea Azzarone (community): Approve
-
Diff: 1128 lines (+505/-85)35 files modifiedCMakeLists.txt (+6/-0)
debian/changelog (+35/-0)
debian/control (+1/-0)
debian/libunity-core-6.0-9.install (+1/-1)
debian/unity-services.install (+1/-1)
debian/unity.install (+1/-0)
decorations/CMakeLists.txt (+1/-0)
decorations/DecoratedWindow.cpp (+101/-5)
decorations/DecoratedWindow.h (+1/-0)
decorations/DecorationsManager.cpp (+1/-1)
decorations/DecorationsPriv.h (+8/-0)
decorations/DecorationsShape.cpp (+107/-0)
decorations/DecorationsShape.h (+54/-0)
launcher/DeviceNotificationDisplay.h (+1/-1)
launcher/DeviceNotificationDisplayImp.cpp (+4/-26)
launcher/DeviceNotificationDisplayImp.h (+1/-1)
launcher/FileManagerLauncherIcon.cpp (+4/-2)
launcher/TrashLauncherIcon.cpp (+21/-17)
launcher/VolumeLauncherIcon.cpp (+1/-1)
lockscreen/LockScreenAcceleratorController.cpp (+12/-2)
plugins/unityshell/src/unityshell.cpp (+2/-1)
plugins/unityshell/unityshell.xml.in (+2/-0)
tests/test_mock_devices.h (+1/-1)
tests/test_unity_window_view.cpp (+6/-0)
tests/test_volume_launcher_icon.cpp (+2/-2)
tools/CMakeLists.txt (+22/-0)
tools/unity.cmake (+6/-0)
tools/unity_active_plugins_safety_check.cpp (+83/-0)
unity-shared/CompizUtils.cpp (+3/-4)
unity-shared/CompizUtils.h (+2/-1)
unity-shared/PluginAdapter.cpp (+1/-1)
unity-shared/TextInput.cpp (+4/-15)
unity-shared/TextInput.h (+0/-1)
unity-shared/UnityWindowView.cpp (+6/-1)
unity7.conf.in (+3/-0)
description: | updated |
tags: |
added: verification-done removed: verification-needed |
To post a comment you must log in.
Hello Marco, or anyone else affected,
Accepted unity into xenial-proposed. The package will build now and be available at https:/ /launchpad. net/ubuntu/ +source/ unity/7. 4.0+16. 04.20160801. 2-0ubuntu1 in a few hours, and then in the -proposed repository.
Please help us by testing this new package. See https:/ /wiki.ubuntu. com/Testing/ EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.
If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed. In either case, details of your testing will help us make a better decision.
Further information regarding the verification process can be found at https:/ /wiki.ubuntu. com/QATeam/ PerformingSRUVe rification . Thank you in advance!