Launcher - Add possibility to cancel Launcher icon drag and drop by pressing ESC
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ayatana Design |
Fix Released
|
Medium
|
John Lea | ||
Unity |
Fix Released
|
Medium
|
Marco Trevisan (Treviño) | ||
unity (Ubuntu) |
Fix Released
|
Medium
|
Marco Trevisan (Treviño) |
Bug Description
Within most GTK applications, it is possible to cancel a drag and drop operation using "Esc". This is especially helpful when one accidentally triggers drag and drop, and wants to cancel it without having any effect of the operation.
Steps to reproduce:
1. Drag an item from the launcher
2. Hit "Esc"
Current incorrect behavour:
- The item does not respond to "Esc" being hit, it is not possible to cancel the drag and drop operation.
-------
Desired resolution:
- When Esc is pressed while a Launcher icon drag is in progress, the Launcher icon should go back to its original position.
- The icon should move back to the Launcher in an animated fashion, with the icon sliding back to it's position in the Launcher when Esc is pressed.
Related branches
- Brandon Schaefer (community): Approve
-
Diff: 700 lines (+372/-46)11 files modifiedlauncher/Launcher.cpp (+47/-24)
launcher/Launcher.h (+3/-1)
launcher/LauncherDragWindow.cpp (+30/-3)
launcher/LauncherDragWindow.h (+8/-2)
launcher/LauncherModel.cpp (+35/-0)
launcher/LauncherModel.h (+2/-0)
launcher/MockLauncherIcon.h (+8/-2)
tests/CMakeLists.txt (+1/-0)
tests/test_launcher.cpp (+124/-14)
tests/test_launcher_drag_window.cpp (+70/-0)
tests/test_launcher_model.cpp (+44/-0)
Changed in unity (Ubuntu): | |
status: | New → Confirmed |
importance: | Undecided → Low |
Changed in unity: | |
status: | New → Confirmed |
importance: | Undecided → Low |
Changed in unity: | |
status: | Confirmed → Incomplete |
Changed in unity (Ubuntu): | |
status: | Confirmed → Incomplete |
tags: | added: needs-design |
description: | updated |
tags: |
added: udp removed: needs-design |
Changed in ayatana-design: | |
assignee: | nobody → John Lea (johnlea) |
importance: | Undecided → Low |
status: | New → Triaged |
Changed in unity (Ubuntu): | |
status: | Incomplete → Triaged |
Changed in unity: | |
status: | Incomplete → Triaged |
milestone: | none → backlog |
Changed in ayatana-design: | |
importance: | Low → Medium |
Changed in unity: | |
importance: | Low → Medium |
Changed in unity (Ubuntu): | |
importance: | Low → Medium |
summary: |
- Unity Launcher: Add possibility to cancel drag and drop + Launcher - Add possibility to cancel Launcher icon drag and drop by + pressing ESC |
Changed in ayatana-design: | |
status: | Triaged → Fix Committed |
Changed in unity: | |
status: | Triaged → In Progress |
assignee: | nobody → Marco Trevisan (Treviño) (3v1n0) |
Changed in unity (Ubuntu): | |
assignee: | nobody → Marco Trevisan (Treviño) (3v1n0) |
Changed in unity: | |
milestone: | backlog → 6.4 |
Changed in unity (Ubuntu): | |
status: | Triaged → In Progress |
Changed in unity: | |
status: | In Progress → Fix Committed |
Changed in unity (Ubuntu): | |
status: | In Progress → Fix Committed |
Changed in unity: | |
status: | Fix Committed → Fix Released |
Changed in unity: | |
status: | Fix Released → Fix Committed |
Changed in unity: | |
milestone: | 6.6 → 7.0 |
no longer affects: | unity/6.0 |
Changed in unity: | |
milestone: | 7.0 → 6.6 |
Changed in unity: | |
status: | Fix Committed → Fix Released |
Changed in ayatana-design: | |
status: | Fix Committed → Fix Released |
tags: |
added: reviewedbydesignq removed: udp |
Update: Unity 6.4 is revision 2632, so this is actually fix committed for Unity 6.6.