Ubuntu
unity8 package

unity8 test failures in trusty

Bug #1244549 reported by Timo Jyrinki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
unity-notifications
Fix Released
Undecided
Lars Karlitski
notify-osd (Ubuntu)
Fix Released
Undecided
Lars Karlitski
unity8 (Ubuntu)
Invalid
Critical
Unassigned

Bug Description

The following tests are failing according to cu2d in trusty:

    unity8.shell.tests.test_notifications.EphemeralNotificationsTests.test_urgency_order(Desktop Nexus 4)
    unity8.shell.tests.test_notifications.InteractiveNotificationBase.test_interactive(Desktop Nexus 4)
    unity8.shell.tests.test_notifications.InteractiveNotificationBase.test_sd_incoming_call(Desktop Nexus 4)
    unity8.shell.tests.test_notifications.EphemeralNotificationsTests.test_icon_summary_body(Desktop Nexus 4)
    unity8.shell.tests.test_notifications.EphemeralNotificationsTests.test_update_notification_layout_change(Desktop Nexus 4)
    unity8.shell.tests.test_notifications.EphemeralNotificationsTests.test_update_notification_same_layout(Desktop Nexus 4)
    unity8.shell.tests.test_notifications.EphemeralNotificationsTests.test_icon_summary(Desktop Nexus 4)
    unity8.shell.tests.test_notifications.EphemeralNotificationsTests.test_summary_only(Desktop Nexus 4)
    unity8.shell.tests.test_notifications.EphemeralNotificationsTests.test_summary_and_body(Desktop Nexus 4)
    unity8.shell.tests.test_notifications.EphemeralNotificationsTests.test_append_hint(Desktop Nexus 4)

We're now still using autopilot 1.3 branch, so the problems of the 1.4 branch should not affect this.

Related branches

lp://qastaging/~larsu/unity-notifications/replace-existing-service
Michał Sawicz: Approve
Jussi Pakkanen (community): Approve
PS Jenkins bot (community): Approve (continuous-integration)
Diff: 15 lines (+4/-1)
1 file modified
src/NotificationPlugin.cpp (+4/-1)
lp://qastaging/~larsu/notify-osd/allow-being-replaced
Mirco Müller (community): Approve
PS Jenkins bot (community): Approve (continuous-integration)
Diff: 12 lines (+1/-1)
1 file modified
src/dbus.c (+1/-1)
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :
Revision history for this message
Mirco Müller (macslow) wrote :

The AP-tests for notifications didn't change recently, so there's no possible regression introduced.

Looking through the attached log, this seems to be the typical timing-issue with the system running the test being so slow to respond, that the 10-seconds waiting-threshold is passed, causing these false positives.

Under Saucy this happend sometimes, but solved itself in the next run. Should this keep occuring we need to look into it. So right now, I'd say ignore it. It's a false positive.

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hi Mirco! Thanks for the comment. I re-ran the stack but we get a similar number of failures...
If the timings are the problem here, maybe we could increase the timeout for those particular checks? Autopilot allows that by passing a timeout=number to the Eventually() call.

Revision history for this message
Michał Sawicz (saviq) wrote :

This is not a timing issue, I'm certain notify-osd is running "behind" unity8 tests, which means unity8 doesn't get the notifications at all.

Something must be triggering notify-osd to start before unity8 is started (you can verify by looking at ~/.cache/upstart/unity8.log and see "Service name already taken" on each unity8 startup.

Ideally unity8 tests should be running in isolation, without unity7 behind it. Maybe it's time for us to create a unity8 session that will be started instead of the unity7 one for unity8 tests?

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

unity8 session sounds good all in all :)

Michał Sawicz (saviq)
Changed in unity8:
status: New → In Progress
Michał Sawicz (saviq)
Changed in unity8:
assignee: Michał Sawicz (saviq) → Mirco Müller (macslow)
status: In Progress → Invalid
Changed in notify-osd:
status: New → Fix Committed
Changed in unity-notifications:
status: New → Fix Committed
Changed in notify-osd:
assignee: nobody → Lars Uebernickel (larsu)
Changed in unity-notifications:
assignee: nobody → Lars Uebernickel (larsu)
Changed in unity8:
assignee: Mirco Müller (macslow) → nobody
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Still getting it with notify-osd and unity-notifications released into archives:

http://10.97.0.1:8080/job/autopilot-trusty-daily_release/304/#showFailuresLink

Revision history for this message
Michał Sawicz (saviq) wrote :

I'm expecting notify-osd wasn't upgraded on the test machines there.

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

It's possible. I updated them manually inside the containers to the 20131030 version, but let's wait for the next daily container build.

Matthew Paul Thomas (mpt)
affects: notify-osd → notify-osd (Ubuntu)
Lars Karlitski (larsu)
Changed in unity-notifications:
status: Fix Committed → Fix Released
Changed in notify-osd (Ubuntu):
status: Fix Committed → Fix Released
Michał Sawicz (saviq)
affects: unity8 → unity8 (Ubuntu)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.